Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]
JingGe merged PR #23870: URL: https://github.com/apache/flink/pull/23870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]
JingGe commented on PR #23870: URL: https://github.com/apache/flink/pull/23870#issuecomment-1858528411 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]
JingGe commented on PR #23870: URL: https://github.com/apache/flink/pull/23870#issuecomment-1857569661 Thanks @xintongsong for your review and comments. I have addressed all of them. Once you confirmed the PR, I will rebase it and squash all commits into one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]
xintongsong commented on code in PR #23870:
URL: https://github.com/apache/flink/pull/23870#discussion_r1427504078
##
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java:
##
@@ -173,6 +173,18 @@ public class TaskManagerOptions {
+ RPC_PORT.key()
+ "') will be used.");
+/** The default port that CollectSinkFunction$ServerThread is
using. */
+@Documentation.Section({
+Documentation.Sections.COMMON_HOST_PORT,
+Documentation.Sections.ALL_TASK_MANAGER
+})
+public static final ConfigOption COLLECT_PORT =
+key("taskmanager.collect.port")
Review Comment:
I'd suggest the key `taskmanager.collect-sink.port`.
##
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java:
##
@@ -173,6 +173,18 @@ public class TaskManagerOptions {
+ RPC_PORT.key()
+ "') will be used.");
+/** The default port that CollectSinkFunction$ServerThread is
using. */
+@Documentation.Section({
+Documentation.Sections.COMMON_HOST_PORT,
+Documentation.Sections.ALL_TASK_MANAGER
+})
+public static final ConfigOption COLLECT_PORT =
+key("taskmanager.collect.port")
+.intType()
+.defaultValue(0)
+.withDescription(
+"The local port that the
CollectSinkFunction$ServerThread binds to. The default is 0, which corresponds
to a random port assignment.");
Review Comment:
I think the current description is kind of developer oriented, rather than
user oriented. `CollectSinkFunction` is an `@Internal` class. Ideally, this
should only be used for Flink's client, and users should not be aware of it.
From a user's perspective, I think they only need to know that this port is for
the client to retrieve query results from the TaskManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]
flinkbot commented on PR #23870: URL: https://github.com/apache/flink/pull/23870#issuecomment-1839718853 ## CI report: * bafa44ff546c1b700477451f19e6bf924ac1d8ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]
JingGe opened a new pull request, #23870: URL: https://github.com/apache/flink/pull/23870 ## What is the purpose of the change CollectSinkFunction$ServerThread uses configured port ## Brief change log - Add new TaskManagerOptions#COLLECT_PORT - CollectSinkFunction$ServerThread uses the port configured in TaskManagerOptions#COLLECT_PORT - upgrade test to JUnit 5 and AssertJ - Add new test ## Verifying this change New test has been created in existing test `CollectSinkFunctionTest`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) - ## Documentation - Does this pull request introduce a new feature? (**yes** / no) - If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
