Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
snuyanzin merged PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
snuyanzin commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1826937228 ok, let's merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
snuyanzin commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1823069285 @MartijnVisser are you ok you'd like to have anything else improved? (asking since you are marked as one who requested changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
eskabetxe commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1823053525 > can you also change PR's description to match changes within this PR? done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
snuyanzin commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1823008918 great, thanks can you also change PR's description to match changes within this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
eskabetxe commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1822993091 @snuyanzin removed the 1.19-SNAPSHOT from PRs and Weekly.. all green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
snuyanzin commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1822878702 > can I remove 1.19-SNAPSHOT to allow this to be merged? yes, I think we could it split it into some subtasks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
eskabetxe commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1822864807 I have a problem now.. This was merged: https://issues.apache.org/jira/browse/FLINK-29541 Basically this class TableTestBase have been migrated to junit5, and this makes JdbcTablePlanTest fail on 1.19-SNAPSHOT @snuyanzin any guidance? can I remove 1.19-SNAPSHOT to allow this to be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
eskabetxe commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1402135237 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 2.13.4.20221013 4.13.2 -5.9.1 -3.23.1 -1.18.2 -2.21.0 +5.10.0 +3.24.2 +1.19.1 +3.4.6 Review Comment: bumped -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
eskabetxe commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1402057531 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 2.13.4.20221013 4.13.2 -5.9.1 -3.23.1 -1.18.2 -2.21.0 +5.10.0 +3.24.2 +1.19.1 Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
eskabetxe commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1402057255 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 2.13.4.20221013 4.13.2 -5.9.1 -3.23.1 -1.18.2 -2.21.0 +5.10.0 Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
snuyanzin commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1402042990 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 2.13.4.20221013 4.13.2 -5.9.1 -3.23.1 -1.18.2 -2.21.0 +5.10.0 +3.24.2 +1.19.1 +3.4.6 Review Comment: out of curiocity: can't we update to the latest 3.x version like 3.12.4? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
snuyanzin commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1402039298 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 2.13.4.20221013 4.13.2 -5.9.1 -3.23.1 -1.18.2 -2.21.0 +5.10.0 +3.24.2 +1.19.1 Review Comment: nit: ```suggestion 1.19.3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
snuyanzin commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1402037265 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 2.13.4.20221013 4.13.2 -5.9.1 -3.23.1 -1.18.2 -2.21.0 +5.10.0 Review Comment: nit ```suggestion 5.10.1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
eskabetxe commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397897431 ## pom.xml: ## @@ -315,6 +322,20 @@ under the License. 1.12.10 + + +com.google.guava +guava +31.1-jre Review Comment: Because convergence, it will fail CI if not added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
maver1ck commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397884392 ## pom.xml: ## @@ -315,6 +322,20 @@ under the License. 1.12.10 + + +com.google.guava +guava +31.1-jre Review Comment: Why we are adding guava dependency here ? Looks like start of dependency hell. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
eskabetxe commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397338085 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: exactly, as this should be the minimum version we are setting that minimum version. this was commented with @MartijnVisser offline I'm still not convinced about this, as I would prefer to have last version to see deprecations and start working on it and the compatibility with other versions is already tested with CI but I'm following the rules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
snuyanzin commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397216656 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: the minimum supported version should be here just a general rule for connector AFAIK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
davidradl commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397207308 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: I am wondering why the Flink version is going down here? I assume because it is a last one released - but it looks strange. If this is intended - could we add a comment to explain the thinking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
davidradl commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397207308 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: I am wondering why the Flink version is going down here? I assume because it is a last one released - but it looks strange -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
davidradl commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397207308 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: I am wondering why the Flink version is going down here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]
maver1ck commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1804449467 @MartijnVisser any chance to merge this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
