Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-15 Thread via GitHub 


Jiabao-Sun commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1857456731

   Thanks @snuyanzin, it makes sense to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-15 Thread via GitHub 


snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1857452824

   ArchUnit does not suport scala, it is mentioned in readme
   
https://github.com/apache/flink/blob/1c884ab48372f7a66f86c28aeaf9518000c7f357/flink-architecture-tests/README.md?plain=1#L62-L66


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-14 Thread via GitHub 


snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1855611405

   @XComp , @Jiabao-Sun 
   it seems current build failure is related
   could you please have a look 
   https://github.com/apache/flink/pull/23929


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-14 Thread via GitHub 


XComp commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1855535740

   Sounds reasonable. Can you create a follow-up ticket for that one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-14 Thread via GitHub 


Jiabao-Sun commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1855510460

   Thanks @XComp, the ArchUnit's rules require the `MiniclusteExtension` 
declared as `static final`, but in scala, we can only declare it `private val` 
in `object`, but this cannot be recognized well by the rules. Maybe we can 
modify the ArchUnit rules to identify this mode.
   
   ```scala
   object StreamingTestBase {
   
 @RegisterExtension
 private val _: MiniClusterExtension = new MiniClusterExtension(
   () =>
 new MiniClusterResourceConfiguration.Builder()
   .setNumberTaskManagers(1)
   .setNumberSlotsPerTaskManager(4)
   .build())
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-14 Thread via GitHub 


XComp merged PR #23914:
URL: https://github.com/apache/flink/pull/23914


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub 


snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1854769170

   @Jiabao-Sun 
   >I tend to avoid too much CI failure through this PR until we find the root 
cause.
   >WDYT 樂️
   
   I put commit with WA I've described above at 
https://github.com/apache/flink/pull/23917
   and it is green
   
   moreover I've scheduled it both in flink ci and my own ci more than 5 times 
in total and there is no any failure...
   
   If there is no objections we can merge it  to avoid too much ci failures and 
continue looking for more optimal solution in a calmer way
   
   
https://dev.azure.com/snuyanzin/flink/_build/results?buildId=2678=results
   
https://dev.azure.com/snuyanzin/flink/_build/results?buildId=2676=results
   
https://dev.azure.com/snuyanzin/flink/_build/results?buildId=2675=results
   
https://dev.azure.com/snuyanzin/flink/_build/results?buildId=2679=results
   
https://dev.azure.com/snuyanzin/flink/_build/results?buildId=2681=results
   
   
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=55493=results
   
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=55487=results
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub 


snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853781175

   I tested with junit5.10.1 and I think it also introduced some changes
   if you look at PR https://github.com/apache/flink/pull/23917 where there is 
only junit bump 5.9.1 -> 5.10.1
   ci failure is also different from what we have in master
   ```
   2023-12-13T01:01:30.0309316Z Dec 13 01:01:29 at 
java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
   2023-12-13T01:01:30.0310427Z Dec 13 01:01:29 at 
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)
   2023-12-13T01:01:30.0312635Z Dec 13 01:01:29 Suppressed: 
java.nio.file.NoSuchFileException: 
/tmp/junit8675027143221640473/b26755eb2623b363024e04d5db7543aa/chk-3
   2023-12-13T01:01:30.0313874Z Dec 13 01:01:29 at 
sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
   2023-12-13T01:01:30.0314987Z Dec 13 01:01:29 at 
sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
   2023-12-13T01:01:30.0316077Z Dec 13 01:01:29 at 
sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
   2023-12-13T01:01:30.0317253Z Dec 13 01:01:29 at 
sun.nio.fs.UnixFileAttributeViews$Basic.readAttributes(UnixFileAttributeViews.java:55)
   2023-12-13T01:01:30.0318483Z Dec 13 01:01:29 at 
sun.nio.fs.UnixFileSystemProvider.readAttributes(UnixFileSystemProvider.java:144)
   2023-12-13T01:01:30.0319812Z Dec 13 01:01:29 at 
sun.nio.fs.LinuxFileSystemProvider.readAttributes(LinuxFileSystemProvider.java:99)
   2023-12-13T01:01:30.0320982Z Dec 13 01:01:29 at 
java.nio.file.Files.readAttributes(Files.java:1737)
   2023-12-13T01:01:30.0322005Z Dec 13 01:01:29 at 
java.nio.file.FileTreeWalker.getAttributes(FileTreeWalker.java:219)
   2023-12-13T01:01:30.0323049Z Dec 13 01:01:29 at 
java.nio.file.FileTreeWalker.visit(FileTreeWalker.java:276)
   2023-12-13T01:01:30.0324067Z Dec 13 01:01:29 at 
java.nio.file.FileTreeWalker.next(FileTreeWalker.java:372)
   2023-12-13T01:01:30.0325253Z Dec 13 01:01:29 at 
java.nio.file.Files.walkFileTree(Files.java:2706)
   2023-12-13T01:01:30.0326179Z Dec 13 01:01:29 at 
java.nio.file.Files.walkFileTree(Files.java:2742)
   2023-12-13T01:01:30.0326926Z Dec 13 01:01:29 ... 40 more
   2023-12-13T01:01:30.0328421Z Dec 13 01:01:29 Suppressed: 
java.nio.file.NoSuchFileException: 
/tmp/junit8675027143221640473/b26755eb2623b363024e04d5db7543aa/chk-3
   2023-12-13T01:01:30.0329745Z Dec 13 01:01:29 at 
sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
   2023-12-13T01:01:30.0330947Z Dec 13 01:01:29 at 
sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
   2023-12-13T01:01:30.0332078Z Dec 13 01:01:29 at 
sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
   2023-12-13T01:01:30.0333192Z Dec 13 01:01:29 at 
sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:244)
   2023-12-13T01:01:30.0334389Z Dec 13 01:01:29 at 
sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:103)
   2023-12-13T01:01:30.0335445Z Dec 13 01:01:29 at 
java.nio.file.Files.delete(Files.java:1126)
   2023-12-13T01:01:30.0336348Z Dec 13 01:01:29 at 
java.nio.file.Files.walkFileTree(Files.java:2672)
   2023-12-13T01:01:30.0337105Z Dec 13 01:01:29 ... 41 
more
   ```
   
   May be they fixed something between these versions.
   My statement about checkpoint failure is for cases with JUnit 5.10.1 (which 
is not in master yet) since with current master I can not reproduce the problem 
locally
   
   I would propose to go with newer JUnit to avoid refixing this againafter 
update


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub 


Jiabao-Sun commented on code in PR #23914:
URL: https://github.com/apache/flink/pull/23914#discussion_r1425242859


##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/utils/StreamAbstractTestBase.java:
##
@@ -22,10 +22,14 @@
 import org.apache.flink.test.junit5.MiniClusterExtension;
 
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /** Base class for unit tests that run multiple tests and want to reuse the 
same Flink cluster. */
 public class StreamAbstractTestBase {

Review Comment:
   I made some attempts to put `MiniClusterExtension` in `StreamingTestBase`, 
but it violated the rules of Arch Unit Test (the scala code could not be well 
recognized).
   
   
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=55472=logs=0c940707-2659-5648-cbe6-a1ad63045f0a=075c2716-8010-5565-fe08-3c4bb45824a4=11485



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub 


Jiabao-Sun commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853767448

   Hi @snuyanzin, I think the `SnapshotDirectory.cleanup` may not be the root 
cause.
   
   I debugged it locally, and the directory structure cleared by 
SnapshotDirectory is start with `minicluster`, which is different from the 
directory structure that caused the error in CI.
   
   ```
   
/var/folders/7_/y05pf91d5x57xkzdbg05jyxmgn/T/junit5535370187595258518/junit5409077863179965513/minicluster_090d7d63818a49f384322545ef962853/tm_0/tmp/job_ba1234fb7067bbd96eebc77ce0e59f0b_op_SlicingWindowOperator_f6dc7f4d2283f4605b127b9364e21148__4_4__uuid_6d8887f8-f218-45e1-a6e5-3e2395b8a09c/chk-1
   
   Suppressed: java.nio.file.DirectoryNotEmptyException: 
/tmp/junit7546196118280881501/2e0195724b946eddf625188a385b28e8
   ```
   
   I tend to avoid too much CI failure through this PR until we find the root 
cause.
   WDYT 樂️


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub 


snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853578934

   > That would mean that we should wait for the snapshot cleanup to finish 
before calling @AfterEach-annotated methods, wouldn't it?
   
   ideally yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub 


Jiabao-Sun commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853575930

   Thanks @snuyanzin @XComp, I'll try to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub 


XComp commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853573483

   Thanks for this finding, @snuyanzin . That would mean that we should wait 
for the snapshot cleanup to finish before calling `@AfterEach`-annotated 
methods, wouldn't it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub 


snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853554316

   @Jiabao-Sun , @XComp 
   it seems I found the reason
   
   junit5.10.1 makes it always failing and it is becoming a bit more clear
   
   there are 2 threads
   1. junit5 trying to delete dir
   2. cleanup snapshot
   ```
at 
org.apache.flink.runtime.state.SnapshotDirectory.cleanup(SnapshotDirectory.java:93)
at 
org.apache.flink.contrib.streaming.state.snapshot.RocksDBSnapshotStrategyBase$NativeRocksDBSnapshotResources.release(RocksDBSnapshotStrategyBase.java:384)
at 
org.apache.flink.runtime.state.SnapshotStrategyRunner$1.cleanupProvidedResources(SnapshotStrategyRunner.java:97)
at 
org.apache.flink.runtime.state.AsyncSnapshotCallable.cleanup(AsyncSnapshotCallable.java:163)
at 
org.apache.flink.runtime.state.AsyncSnapshotCallable.call(AsyncSnapshotCallable.java:87)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
org.apache.flink.util.concurrent.FutureUtils.runIfNotDoneAndGet(FutureUtils.java:508)
at 
org.apache.flink.streaming.api.operators.OperatorSnapshotFinalizer.(OperatorSnapshotFinalizer.java:54)
at 
org.apache.flink.streaming.runtime.tasks.AsyncCheckpointRunnable.finalizeNonFinishedSnapshots(AsyncCheckpointRunnable.java:191)
at 
org.apache.flink.streaming.runtime.tasks.AsyncCheckpointRunnable.run(AsyncCheckpointRunnable.java:124)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:750)
   ```
   
suspect that in JUnit5 they made removal in `AfterEach` which makes it 
concurrent with checkpoint cleanup...

Since junit 5.10.1 makes it failing even locally
as a WA I replaced `TempDir` with 
```java
  val baseCheckpointPath = 
Files.createTempDirectory(getClass.getCanonicalName)
   Files.deleteIfExists(baseCheckpointPath);
   ```
   locally it helps
   
https://dev.azure.com/snuyanzin/flink/_build/results?buildId=2674=results
   now it is running on my ci to see whether it helps or not


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub 


XComp commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853544386

   > The var tempFolder: Path = _ defines in scala is an object field already, 
for each @Test method, it is different.
   
   Thanks for clarification. My lack of Scala knowledge made me mix up the 
class and companion object declaration.
   
   > However, if the test of the same test is allowed to be executed 
concurrently, it may also cause path errors.
   
   That, I still don't get. Why would concurrent execution of tests cause this 
issue if each test class/instance has it's own temporary directory (because the 
tempFolder field is an object field)? Or do you mean if test methods are run 
concurrently? As far as I understand, that shouldn't happen: The concurrent 
test method execution has to be enabled explicitly using 
`@Execution(ExecutionMode.CONCURRENT)` (see [parent 
pom.xml:1745ff](https://github.com/apache/flink/blob/ea4cdc28651ad91defd4fc7b371a1f520ea7a262/pom.xml#L1745)).
 Or do I miss something here?  :thinking: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-12 Thread via GitHub 


Jiabao-Sun commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853193955

   Thanks @XComp, @snuyanzin.
   The comments were addressed and print the files that are not deleted when 
IOException throws.
   
   > StreamingTestBase#tempFolder is a class field which makes all tests use 
the same temporary folder
   
   The `var tempFolder: Path = _` defines in scala is an object field already, 
for each `@Test` method, it is different.
   However, if the test of the same test is allowed to be executed 
concurrently, it may also cause path errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-12 Thread via GitHub 


snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853037273

   @Jiabao-Sun I would suggest to update JUnit 
https://github.com/apache/flink/pull/23917
   
   where they improved logging for `Tempdir` removal 
   at 
https://github.com/junit-team/junit5/pull/3249/files#diff-722173375ef777095d4d3ba36f4e5063f25c21f23701ad4cbd470018c2888fa8
   https://github.com/junit-team/junit5/issues/3236


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-12 Thread via GitHub 


XComp commented on code in PR #23914:
URL: https://github.com/apache/flink/pull/23914#discussion_r1424283608


##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/utils/StreamAbstractTestBase.java:
##
@@ -22,10 +22,14 @@
 import org.apache.flink.test.junit5.MiniClusterExtension;
 
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /** Base class for unit tests that run multiple tests and want to reuse the 
same Flink cluster. */
 public class StreamAbstractTestBase {
 
+protected final Logger log = LoggerFactory.getLogger(getClass());

Review Comment:
   nit: The logger is not used anywhere else except for 
`StreamingWithStateTestBase`. It feels like a premature optimization with the 
risk that other test classes will miss that there's a protected log field 
already present and will create their own logger, anyway. That's a proposal you 
can reject if you want, but to me it would be good enough to have the code 
change being done in `StreamingWithStateTestBase` as a private field.



##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala:
##
@@ -63,7 +64,7 @@ class StreamingWithStateTestBase(state: StateBackendMode) 
extends StreamingTestB
   override def before(): Unit = {
 super.before()
 // set state backend
-baseCheckpointPath = tempFolder.toFile
+baseCheckpointPath = Files.createTempDirectory("junit").toFile

Review Comment:
   ```suggestion
   baseCheckpointPath = Files.createTempDirectory(tempFolder, 
"junit").toFile
   ```
   maybe, we should still utilize the temporary folder that is created in the 
parent class to utilize JUnit5's temporary folder feature.



##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/utils/StreamAbstractTestBase.java:
##
@@ -22,10 +22,14 @@
 import org.apache.flink.test.junit5.MiniClusterExtension;
 
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /** Base class for unit tests that run multiple tests and want to reuse the 
same Flink cluster. */
 public class StreamAbstractTestBase {

Review Comment:
   `StreamAbstractTestBase` is only used by `StreamingTestBase`. Can't we merge 
the two? :thinking: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-12 Thread via GitHub 


flinkbot commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1852331226

   
   ## CI report:
   
   * 9de6704a23d33a78b3b8b7d94f59355f3335064e UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-12 Thread via GitHub 


Jiabao-Sun opened a new pull request, #23914:
URL: https://github.com/apache/flink/pull/23914

   
   
   ## What is the purpose of the change
   
   [FLINK-33641][test] Suppress the DirectoryNotEmptyException in 
StreamingWithStateTestBase to prevent test failures
   
   ## Brief change log
   Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to 
prevent test failures
   
   
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (yes / no / don't know)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
 - If yes, how is the feature documented? (not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org