Re: [PR] [FLINK-33643][runtime] Allow StreamExecutionEnvironment's executeAsync API to use default JobName [flink]

[via GitHub]

huwh merged PR #23794:
URL: https://github.com/apache/flink/pull/23794


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33643][runtime] Allow StreamExecutionEnvironment's executeAsync API to use default JobName [flink]

[via GitHub]

wangzzu commented on code in PR #23794:
URL: https://github.com/apache/flink/pull/23794#discussion_r1406146111


##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##
@@ -2213,12 +2211,24 @@ public final JobClient executeAsync() throws Exception {
  */
 @PublicEvolving
 public JobClient executeAsync(String jobName) throws Exception {
-Preconditions.checkNotNull(jobName, "Streaming Job name should not be 
null.");
 final StreamGraph streamGraph = getStreamGraph();
-streamGraph.setJobName(jobName);
+setJobNameForJobGraph(streamGraph, jobName);

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33643][runtime] Allow StreamExecutionEnvironment's executeAsync API to use default JobName [flink]

[via GitHub]

huwh commented on code in PR #23794:
URL: https://github.com/apache/flink/pull/23794#discussion_r1405565272


##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##
@@ -2213,12 +2211,24 @@ public final JobClient executeAsync() throws Exception {
  */
 @PublicEvolving
 public JobClient executeAsync(String jobName) throws Exception {
-Preconditions.checkNotNull(jobName, "Streaming Job name should not be 
null.");
 final StreamGraph streamGraph = getStreamGraph();
-streamGraph.setJobName(jobName);
+setJobNameForJobGraph(streamGraph, jobName);

Review Comment:
   IMO, The logic is simple and clear, and there is no need to introduce a new 
function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33643][runtime] Allow StreamExecutionEnvironment's executeAsync API to use default JobName [flink]

[via GitHub]

flinkbot commented on PR #23794:
URL: https://github.com/apache/flink/pull/23794#issuecomment-1825607773

   
   ## CI report:
   
   * f7ec60f2828f0349bc285e9d54cf470477728ae1 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [FLINK-33643][runtime] Allow StreamExecutionEnvironment's executeAsync API to use default JobName [flink]

[via GitHub]

wangzzu opened a new pull request, #23794:
URL: https://github.com/apache/flink/pull/23794

   
   
   
   ## What is the purpose of the change
   
   *(For example: This pull request makes task deployment go through the blob 
server, rather than through RPC. That way we avoid re-transferring them on each 
deployment (during recovery).)*
   
   
   ## Brief change log
   
   - Regarding the processing of JobName, `StreamExecutionEnvironment` ensures 
that the logic of `executeAsync` and `execute` is consistent.
   
   ## Verifying this change
   
   This change has already taken effect in `execute`.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
 - The serializers: no
 - The runtime per-record code paths (performance sensitive): no
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
 - The S3 file system connector: no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
 - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org