Re: [PR] [FLINK-33723] Disallow triggering incremental checkpoint explicitly from REST API [flink]

2023-12-13 Thread via GitHub


masteryhx closed pull request #23853: [FLINK-33723] Disallow triggering 
incremental checkpoint explicitly from REST API
URL: https://github.com/apache/flink/pull/23853


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-33723] Disallow triggering incremental checkpoint explicitly from REST API [flink]

2023-12-01 Thread via GitHub


flinkbot commented on PR #23853:
URL: https://github.com/apache/flink/pull/23853#issuecomment-1835916010

   
   ## CI report:
   
   * 43e3a97820462f7a88961e005c32b4d3f82a1556 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [FLINK-33723] Disallow triggering incremental checkpoint explicitly from REST API [flink]

2023-12-01 Thread via GitHub


Zakelly opened a new pull request, #23853:
URL: https://github.com/apache/flink/pull/23853

   ## What is the purpose of the change
   
   Currently, when a job is configured to run with incremental checkpoint 
disabled, user manually triggers an incremental checkpoint actually triggering 
a full checkpoint. That is because the files from full checkpoint cannot be 
shared with an incremental checkpoint. This PR removes the "INCREMENTAL" option 
in triggering checkpoint from REST API and throw exception if user tried to 
avoid misunderstanding.
   
   
   ## Brief change log
   
- Throw exception in 
```org.apache.flink.runtime.rest.handler.job.checkpoints.CheckpointHandlers```
- Remove the 'INCREMENTAL' options in docs
   
   ## Verifying this change
   
- Added unit test 
```CheckpointHandlersTest#testDisallowTriggeringIncrementalCheckpoint``` for 
this case.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / **no**)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
 - The serializers: (yes / **no** / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
 - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / **no**)
 - If yes, how is the feature documented? (not applicable / **docs** / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org