[PR] [FLINK-33731][Scheduler] Remove the redundant flip1 package [flink]

2023-12-03 Thread via GitHub


1996fanrui opened a new pull request, #23862:
URL: https://github.com/apache/flink/pull/23862

   ## What is the purpose of the change
   
   
   Currently, there is a org.apache.flink.runtime.executiongraph.failover.flip1 
package.
   
   I propose rename the failover.flip1 to failover, in the other word: removing 
the flip1. I have 2 reasons:
   
   - The naming of the package should be based on business semantics, not FLIP 
number, and the code under the failover.flip1 package has also many changes 
after FLIP-1.
   - All code under the failover.flip1 package are Internal code instead of 
`@Public` code, so they can be renamed directly.
   
   
   ## Brief change log
   
   [FLINK-33731][Scheduler] Remove the redundant flip1 package
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
 - The serializers: no
 - The runtime per-record code paths (performance sensitive):  no
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
 - The S3 file system connector:no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-33731][Scheduler] Remove the redundant flip1 package [flink]

2023-12-03 Thread via GitHub


flinkbot commented on PR #23862:
URL: https://github.com/apache/flink/pull/23862#issuecomment-1837775224

   
   ## CI report:
   
   * f3b29fe0bffcd2511bfaf4f3c3284d0751120259 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-33731][Scheduler] Remove the redundant flip1 package [flink]

2023-12-04 Thread via GitHub


1996fanrui merged PR #23862:
URL: https://github.com/apache/flink/pull/23862


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org