Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
fsk119 merged PR #24096: URL: https://github.com/apache/flink/pull/24096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1897827367 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1897742954 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1897687775 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1897681337 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1896013475 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1895992057 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1895814613 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1895763918 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1895668532 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1895601194 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1895584274 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1895257322 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1894994260 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1894758649 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1893787707 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1893766802 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1893725883 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1893551801 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1893520357 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1893348581 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1893317005 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
flinkbot commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1892213323 ## CI report: * 8fb2566c788fdca75da1e6b720655051b67e4e13 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]
swuferhong opened a new pull request, #24096: URL: https://github.com/apache/flink/pull/24096 ## What is the purpose of the change In issue FLINK-33490, the view name need to validate to check whether the name is conflict in new view. However, for syntax: `create view view1(a, b) as select t1.name, t2.name from t1 join t1 t2 on t1.score = t2.score; `. If user specify the column name, planner should not throw exception while creating view with specify field names even if the query conflicts in field names. ## Brief change log - support the syntax `create view view1(a, b) as select t1.name, t2.name from t1 join t1 t2 on t1.score = t2.score; ` not throw exception. - add test to cover it. ## Verifying this change ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? no docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org