Re: [PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]
dawidwys merged PR #24154: URL: https://github.com/apache/flink/pull/24154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]
bvarghese1 commented on PR #24154: URL: https://github.com/apache/flink/pull/24154#issuecomment-1940403064 @dawidwys Rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]
dawidwys commented on PR #24154: URL: https://github.com/apache/flink/pull/24154#issuecomment-1938921254 @bvarghese1 Do you mind rebasing on top of the current master? I believe failures should be fixed now: https://issues.apache.org/jira/browse/FLINK-34420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]
flinkbot commented on PR #24154: URL: https://github.com/apache/flink/pull/24154#issuecomment-1900799197 ## CI report: * 8c65d2c4b13b3ab943fa600efb4b544ba0882d30 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]
bvarghese1 commented on code in PR #24154:
URL: https://github.com/apache/flink/pull/24154#discussion_r1459374849
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/IncrementalGroupAggregateTestPrograms.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.stream;
+
+import org.apache.flink.table.api.config.ExecutionConfigOptions;
+import org.apache.flink.table.api.config.OptimizerConfigOptions;
+import org.apache.flink.table.test.program.SinkTestStep;
+import org.apache.flink.table.test.program.SourceTestStep;
+import org.apache.flink.table.test.program.TableTestProgram;
+import org.apache.flink.types.Row;
+
+import java.time.Duration;
+
+/** {@link TableTestProgram} definitions for testing {@link
StreamExecGroupAggregate}. */
+public class IncrementalGroupAggregateTestPrograms {
+
+static final Row[] BEFORE_DATA = {
+Row.of(1, 1L, "hi"), Row.of(2, 2L, "hello"), Row.of(3, 2L, "hello
world")
+};
+
+static final Row[] AFTER_DATA = {
+Row.of(3, 2L, "foo"), Row.of(4, 4L, "bar"), Row.of(5, 2L, "foo bar")
+};
+
+static final String[] SOURCE_SCHEMA = {"a INT", "b BIGINT", "c VARCHAR"};
+
+static final TableTestProgram INCREMENTAL_GROUP_AGGREGATE_SIMPLE =
+TableTestProgram.of(
+"incremental-group-aggregate-simple",
+"validates incremental group aggregation")
+.setupTableSource(
+SourceTestStep.newBuilder("source_t")
+.addSchema(SOURCE_SCHEMA)
+.producedBeforeRestore(BEFORE_DATA)
+.producedAfterRestore(AFTER_DATA)
+.build())
+
.setupConfig(ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ENABLED, true)
+.setupConfig(
+
ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ALLOW_LATENCY,
+Duration.ofSeconds(1))
+
.setupConfig(ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_SIZE, 5L)
+.setupConfig(
+
OptimizerConfigOptions.TABLE_OPTIMIZER_DISTINCT_AGG_SPLIT_ENABLED, true)
+.setupTableSink(
+SinkTestStep.newBuilder("sink_t")
+.addSchema("b BIGINT", "a BIGINT")
+.consumedBeforeRestore("+I[1, 1]", "+I[2,
2]")
+.consumedAfterRestore("-U[2, 2]", "+U[2,
3]", "+I[4, 1]")
+.build())
+.runSql(
+"INSERT INTO sink_t\n"
++ " SELECT\n"
++ " b,\n"
++ " COUNT(DISTINCT a) AS a\n"
++ " FROM source_t\n"
++ " GROUP BY b")
+.build();
+
+static final TableTestProgram INCREMENTAL_GROUP_AGGREGATE_COMPLEX =
+TableTestProgram.of(
+"incremental-group-aggregate-complex",
+"validates incremental group aggregation with
multiple aggregations")
+.setupTableSource(
+SourceTestStep.newBuilder("source_t")
+.addSchema(SOURCE_SCHEMA)
+.producedBeforeRestore(BEFORE_DATA)
+.producedAfterRestore(AFTER_DATA)
+.build())
+
.setupConfig(ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ENABLED, true)
+.setupConfig(
+
ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ALLOW_LATENCY,
+Duration.ofSeconds(10))
+
.setupConfig(ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_SIZE, 1L)
Review
[PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]
bvarghese1 opened a new pull request, #24154: URL: https://github.com/apache/flink/pull/24154 ## What is the purpose of the change *Add restore tests for IncrementalGroupAggregate node* ## Verifying this change This change added tests and can be verified as follows: - Added restore tests for IncrementalGroupAggregate node which verifies the generated compiled plan with the saved compiled plan. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]
dawidwys merged PR #24028: URL: https://github.com/apache/flink/pull/24028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]
flinkbot commented on PR #24028: URL: https://github.com/apache/flink/pull/24028#issuecomment-1878101061 ## CI report: * 44ff132411251b97117799a727005c87bc4e7a1d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-34000] Implement restore tests for IncrementalGroupAgg node [flink]
bvarghese1 opened a new pull request, #24028: URL: https://github.com/apache/flink/pull/24028 ## What is the purpose of the change *Add restore tests for IncrementalGroupAggregate node* ## Verifying this change This change added tests and can be verified as follows: - Added restore tests for IncrementalGroupAggregate node which verifies the generated compiled plan with the saved compiled plan. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
