[PR] [FLINK-34001][docs][table] Fix ambiguous document description towards the default value for configuring operator-level state TTL [flink]

2024-01-07 Thread via GitHub


LadyForest opened a new pull request, #24039:
URL: https://github.com/apache/flink/pull/24039

   ## What is the purpose of the change
   
   This is a trivial PR to eliminate the ambiguous description about the 
meaning of 0ms when configuring operator-level state TTL for SQL/TableAPI using 
compiled plan.
   
   
   ## Brief change log
   
   Change "state retention is not enabled" to "state never expires"
   
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / **no**)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
 - The serializers: (yes / **no** / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
 - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / **no**)
 - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-34001][docs][table] Fix ambiguous document description towards the default value for configuring operator-level state TTL [flink]

2024-01-07 Thread via GitHub


xuyangzhong commented on PR #24039:
URL: https://github.com/apache/flink/pull/24039#issuecomment-1880311358

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-34001][docs][table] Fix ambiguous document description towards the default value for configuring operator-level state TTL [flink]

2024-01-07 Thread via GitHub


flinkbot commented on PR #24039:
URL: https://github.com/apache/flink/pull/24039#issuecomment-1880311788

   
   ## CI report:
   
   * 0025867642132f37810d2abf6679a0cad3de3ea3 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-34001][docs][table] Fix ambiguous document description towards the default value for configuring operator-level state TTL [flink]

2024-01-07 Thread via GitHub


LadyForest commented on PR #24039:
URL: https://github.com/apache/flink/pull/24039#issuecomment-1880416082

   The CI failure is not relevant to the changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-34001][docs][table] Fix ambiguous document description towards the default value for configuring operator-level state TTL [flink]

2024-01-07 Thread via GitHub


LadyForest commented on PR #24039:
URL: https://github.com/apache/flink/pull/24039#issuecomment-1880416354

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-34001][docs][table] Fix ambiguous document description towards the default value for configuring operator-level state TTL [flink]

2024-01-07 Thread via GitHub


LadyForest commented on PR #24039:
URL: https://github.com/apache/flink/pull/24039#issuecomment-1880476143

   The CI failure is caused by FLINK-34012


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-34001][docs][table] Fix ambiguous document description towards the default value for configuring operator-level state TTL [flink]

2024-01-08 Thread via GitHub


LadyForest merged PR #24039:
URL: https://github.com/apache/flink/pull/24039


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org