Re: [PR] [FLINK-34333][k8s] 1.18 backport of FLINK-34007 [flink]

2024-02-13 Thread via GitHub


XComp merged PR #24245:
URL: https://github.com/apache/flink/pull/24245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-34333][k8s] 1.18 backport of FLINK-34007 [flink]

2024-02-01 Thread via GitHub


flinkbot commented on PR #24245:
URL: https://github.com/apache/flink/pull/24245#issuecomment-1921277811

   
   ## CI report:
   
   * 087ef9d4311dcacaa6d7e7caf15d9abce0e8fb95 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [FLINK-34333][k8s] 1.18 backport of FLINK-34007 [flink]

2024-02-01 Thread via GitHub


XComp opened a new pull request, #24245:
URL: https://github.com/apache/flink/pull/24245

   ## What is the purpose of the change
   
   This is the fix of FLINK-34007 applied to Flink 1.18. In the end, it's a 
straight-forward backport including the upgrade to fabric8io:kubernetes-client 
v6.9.0. See FLINK-34333 for further details on the discussion whether the 
dependency upgrade is suitable.
   
   ## Brief change log
   
   * Makes `KubernetesLeaderElector` re-instantiate the fabric8io LeaderElector 
at the beginning of a new leadership lifecycle.
   * Upgrades `fabric8io:kubernetes-client` from `v6.6.2` to `v6.9.0` in order 
to include https://github.com/fabric8io/kubernetes-client/issues/5463
   
   ## Verifying this change
   
   * Extends `KubernetesLeaderElectorITCase` to include a test case for the 
scenario that was revealed in FLINK-34007 and a check that verifies the 
leadership lost event being sent when stopping the `KubernetesLeaderElector`
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
 - The serializers: no
 - The runtime per-record code paths (performance sensitive): no
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
 - The S3 file system connector: no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
 - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org