Re: [PR] [FLINK-34437][SQL Client] Fix typo [flink]
JingGe merged PR #24310: URL: https://github.com/apache/flink/pull/24310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34437][SQL Client] Fix typo [flink]
rmoff commented on PR #24310: URL: https://github.com/apache/flink/pull/24310#issuecomment-1946084609 squashed, thanks @JingGe ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34437][SQL Client] Fix typo [flink]
JingGe commented on PR #24310: URL: https://github.com/apache/flink/pull/24310#issuecomment-1945700702 @rmoff Thanks for your contribution! Would you please squash your commits into one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34437][SQL Client] Fix typo [flink]
flinkbot commented on PR #24310: URL: https://github.com/apache/flink/pull/24310#issuecomment-1941853000 ## CI report: * 2dbe5769fbe2b7dfec652d1360136901ae227b80 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-34437][SQL Client] Fix typo [flink]
rmoff opened a new pull request, #24310:
URL: https://github.com/apache/flink/pull/24310
## What is the purpose of the change
The SQL Client issues a message when a statement successfully executes. For
example:
```sql
Flink SQL> CREATE CATALOG c_new WITH ('type'='generic_in_memory');
[INFO] Execute statement succeed.
```
The use of `succeed` is incorrect, and should read `succeeded`. This PR
fixes this.
## Brief change log
* Changed the actual message
* Changed the tests and docs that reference it.
## Verifying this change
Please make sure both new and modified tests in this PR follows the
conventions defined in our code quality guide:
https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
-> This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
