[PR] [FLINK-34503][table] Migrate JoinDeriveNullFilterRule to java. [flink]
liuyongvs opened a new pull request, #24373: URL: https://github.com/apache/flink/pull/24373 ## What is the purpose of the change The PR migrates JoinDeriveNullFilterRule to java it doesn't touch JoinDeriveNullFilterRuleTest to be sure that java version continues passing it ## Verifying this change This change is already covered by existing tests ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34503][table] Migrate JoinDeriveNullFilterRule to java. [flink]
liuyongvs commented on PR #24373: URL: https://github.com/apache/flink/pull/24373#issuecomment-2111617766 hi @snuyanzin will you help review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34503][table] Migrate JoinDeriveNullFilterRule to java. [flink]
liuyongvs commented on code in PR #24373: URL: https://github.com/apache/flink/pull/24373#discussion_r1500411569 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinDeriveNullFilterRule.java: ## @@ -59,7 +59,7 @@ public class JoinDeriveNullFilterRule // It is an experimental config, will may be removed later. @Experimental -private static final ConfigOption TABLE_OPTIMIZER_JOIN_NULL_FILTER_THRESHOLD = +public static final ConfigOption TABLE_OPTIMIZER_JOIN_NULL_FILTER_THRESHOLD = Review Comment: comments: unit test access it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34503][table] Migrate JoinDeriveNullFilterRule to java. [flink]
liuyongvs commented on PR #24373: URL: https://github.com/apache/flink/pull/24373#issuecomment-2043128185 hi @snuyanzin will you also help review this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34503][table] Migrate JoinDeriveNullFilterRule to java. [flink]
flinkbot commented on PR #24373: URL: https://github.com/apache/flink/pull/24373#issuecomment-1960739934 ## CI report: * 66a51ec643ce5844fb05cb76fce2e390e8ac12d1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34503][table] Migrate JoinDeriveNullFilterRule to java. [flink]
liuyongvs commented on code in PR #24373: URL: https://github.com/apache/flink/pull/24373#discussion_r1500411569 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinDeriveNullFilterRule.java: ## @@ -59,7 +59,7 @@ public class JoinDeriveNullFilterRule // It is an experimental config, will may be removed later. @Experimental -private static final ConfigOption TABLE_OPTIMIZER_JOIN_NULL_FILTER_THRESHOLD = +public static final ConfigOption TABLE_OPTIMIZER_JOIN_NULL_FILTER_THRESHOLD = Review Comment: comments: unit test access it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34503][table] Migrate JoinDeriveNullFilterRule to java. [flink]
liuyongvs commented on PR #24373: URL: https://github.com/apache/flink/pull/24373#issuecomment-1980642419 hi @dawidwys will you also help review this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34503][table] Migrate JoinDeriveNullFilterRule to java. [flink]
liuyongvs commented on PR #24373: URL: https://github.com/apache/flink/pull/24373#issuecomment-1987508136 hi @snuyanzin will you also help review this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
