[PR] [FLINK-35027][runtime/checkpoint] Implement checkpoint drain in AsyncExecutionController [flink]
fredia opened a new pull request, #24676: URL: https://github.com/apache/flink/pull/24676 ## What is the purpose of the change This PR implements checkpoint drain in `AsyncExecutionController`, and wires it to `AbstractAsyncStateStreamOperator/AbstractAsyncStateStreamOperatorV2`. ## Brief change log - Add `AsyncExecutionController#drainInflightRecords` - Override `AbstractAsyncStateStreamOperator/AbstractAsyncStateStreamOperatorV2#snapshotState()`. ## Verifying this change This change is already covered by existing tests, such as *(please describe tests)*. - `AsyncExecutionControllerTest#testInFlightRecordControl()` - ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes, checkpointing) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35027][runtime/checkpoint] Implement checkpoint drain in AsyncExecutionController [flink]
flinkbot commented on PR #24676: URL: https://github.com/apache/flink/pull/24676#issuecomment-2062993344 ## CI report: * bc18939af1ffea146d6f2214d061cca4dc136ca6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35027][runtime/checkpoint] Implement checkpoint drain in AsyncExecutionController [flink]
Zakelly commented on code in PR #24676:
URL: https://github.com/apache/flink/pull/24676#discussion_r1571777947
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##
@@ -133,6 +136,20 @@ public final ThrowingConsumer,
Exception> getRecordProcessor
getClass().getName(), inputId));
}
+@Override
+public final OperatorSnapshotFutures snapshotState(
+long checkpointId,
+long timestamp,
+CheckpointOptions checkpointOptions,
+CheckpointStreamFactory factory)
+throws Exception {
+asyncExecutionController.drainInflightRecords(0);
Review Comment:
Ah... almost forget. Should we check `isAsyncStateProcessingEnabled` first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-35027][runtime/checkpoint] Implement checkpoint drain in AsyncExecutionController [flink]
fredia merged PR #24676: URL: https://github.com/apache/flink/pull/24676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
