Re: [PR] [FLINK-35044][state] Init flink-statebackend-forst module [flink]
masteryhx closed pull request #24631: [FLINK-35044][state] Init flink-statebackend-forst module URL: https://github.com/apache/flink/pull/24631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35044][state] Init flink-statebackend-forst module [flink]
ljz2051 commented on code in PR #24631: URL: https://github.com/apache/flink/pull/24631#discussion_r1556933308 ## flink-state-backends/flink-statebackend-forst/pom.xml: ## @@ -0,0 +1,92 @@ + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + + 4.0.0 + + + org.apache.flink + flink-state-backends + 1.20-SNAPSHOT + + + flink-statebackend-forst + Flink : State backends : ForSt + + jar + + + --add-opens=java.base/java.util=ALL-UNNAMED + Review Comment: Thanks for the explanation! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35044][state] Init flink-statebackend-forst module [flink]
Re: [PR] [FLINK-35044][state] Init flink-statebackend-forst module [flink]
masteryhx commented on code in PR #24631: URL: https://github.com/apache/flink/pull/24631#discussion_r1556741472 ## flink-state-backends/flink-statebackend-forst/pom.xml: ## @@ -0,0 +1,92 @@ + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + + 4.0.0 + + + org.apache.flink + flink-state-backends + 1.20-SNAPSHOT + + + flink-statebackend-forst + Flink : State backends : ForSt + + jar + + + --add-opens=java.base/java.util=ALL-UNNAMED + Review Comment: It's introduce by FLINK-25002 to supports JDK-17 temporarily. IIUC, it's better to also introduce it if current dependencies may contains some used modules which should be open, e.g. chill-java in flink-streaming-java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35044][state] Init flink-statebackend-forst module [flink]
ljz2051 commented on code in PR #24631: URL: https://github.com/apache/flink/pull/24631#discussion_r142660 ## flink-state-backends/flink-statebackend-forst/pom.xml: ## @@ -0,0 +1,92 @@ + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + + 4.0.0 + + + org.apache.flink + flink-state-backends + 1.20-SNAPSHOT + + + flink-statebackend-forst + Flink : State backends : ForSt + + jar + + + --add-opens=java.base/java.util=ALL-UNNAMED + Review Comment: Could you please briefly explain why we need the "" property? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35044][state] Init flink-statebackend-forst module [flink]
masteryhx commented on PR #24631: URL: https://github.com/apache/flink/pull/24631#issuecomment-2042211506 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
