[PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]
liuyongvs opened a new pull request, #24642: URL: https://github.com/apache/flink/pull/24642 ## What is the purpose of the change A bit reasoning for the change The reason is that since 1.28.0 ( [CALCITE-4787](https://issues.apache.org/jira/browse/CALCITE-4787) - Move core to use Immutables instead of ImmutableBeans ) Calcite started to use Immutables (https://immutables.github.io/) and since 1.29.0 removed ImmutableBeans ( [CALCITE-4839](https://issues.apache.org/jira/browse/CALCITE-4839) - Remove remnants of ImmutableBeans post 1.28 release ). All rule configuration related api which is not Immutables based is marked as deprecated. Since Immutables implies code generation while java compilation it is seems impossible to use for rules in Scala code. The PR migrates RewriteMultiJoinConditionRule to java ## Verifying this change This change is already covered by existing tests ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]
liuyongvs opened a new pull request, #24648: URL: https://github.com/apache/flink/pull/24648 ## What is the purpose of the change A bit reasoning for the change The reason is that since 1.28.0 ( [CALCITE-4787](https://issues.apache.org/jira/browse/CALCITE-4787) - Move core to use Immutables instead of ImmutableBeans ) Calcite started to use Immutables (https://immutables.github.io/) and since 1.29.0 removed ImmutableBeans ( [CALCITE-4839](https://issues.apache.org/jira/browse/CALCITE-4839) - Remove remnants of ImmutableBeans post 1.28 release ). All rule configuration related api which is not Immutables based is marked as deprecated. Since Immutables implies code generation while java compilation it is seems impossible to use for rules in Scala code. The PR migrates RewriteMultiJoinConditionRule to java ## Verifying this change This change is already covered by existing tests ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]
flinkbot commented on PR #24642: URL: https://github.com/apache/flink/pull/24642#issuecomment-2044794801 ## CI report: * 617267343d1be461104994c10bc4fd43e3018977 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]
liuyongvs commented on PR #24642: URL: https://github.com/apache/flink/pull/24642#issuecomment-2046414515 the reason of ci failed is the scala map hashcode is different with java. make the 'map.value' (to list) order different. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]
liuyongvs commented on PR #24642: URL: https://github.com/apache/flink/pull/24642#issuecomment-2046440061 we can solve it two ways: 1. using scala map in the java code, new pr here https://github.com/apache/flink/pull/24648 ``` scala.collection.mutable.Map> equiJoinFilterMap = new scala.collection.mutable.HashMap<>(); ``` 2. change the plan to passed the unit test because the plan just change the description, not impact the DAG. so i suggest adopt the 2, what do you think @snuyanzin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]
flinkbot commented on PR #24648: URL: https://github.com/apache/flink/pull/24648#issuecomment-2046446805 ## CI report: * 0507bb8bb896a725ce3a2f8f79bdd28eeb628d70 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]
liuyongvs commented on PR #24648: URL: https://github.com/apache/flink/pull/24648#issuecomment-2056392924 hi @snuyanzin will you help review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]
liuyongvs commented on PR #24642: URL: https://github.com/apache/flink/pull/24642#issuecomment-2314897443 hi @snuyanzin will you help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
