[PR] [FLINK-35300][cdc][mysql] Improve MySqlStreamingChangeEventSource to skip null events in event deserializer [flink-cdc]

[via GitHub]

Shawn-Hx opened a new pull request, #3299:
URL: https://github.com/apache/flink-cdc/pull/3299

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-35300][cdc][mysql] Improve MySqlStreamingChangeEventSource to skip null events in event deserializer [flink-cdc]

[via GitHub]

leonardBang commented on PR #3299:
URL: https://github.com/apache/flink-cdc/pull/3299#issuecomment-2133251944

   @lvyanquan Could you help review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-35300][cdc][mysql] Improve MySqlStreamingChangeEventSource to skip null events in event deserializer [flink-cdc]

[via GitHub]

lvyanquan commented on code in PR #3299:
URL: https://github.com/apache/flink-cdc/pull/3299#discussion_r1615909988


##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/MySqlStreamingChangeEventSource.java:
##
@@ -257,6 +260,9 @@ public Event nextEvent(ByteArrayInputStream inputStream) 
throws IOException {
 try {
 // Delegate to the superclass ...
 Event event = super.nextEvent(inputStream);
+if (event == null) {
+return null;

Review Comment:
   There is no logic to go to this place because currently we don't need to 
read the binlog file on the local path using 
`com.github.shyiko.mysql.binlog.BinaryLogFileReader`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-35300][cdc][mysql] Improve MySqlStreamingChangeEventSource to skip null events in event deserializer [flink-cdc]

[via GitHub]

leonardBang closed pull request #3299: [FLINK-35300][cdc][mysql] Improve 
MySqlStreamingChangeEventSource to skip null events in event deserializer
URL: https://github.com/apache/flink-cdc/pull/3299


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-35300][cdc][mysql] Improve MySqlStreamingChangeEventSource to skip null events in event deserializer [flink-cdc]

[via GitHub]

leonardBang commented on code in PR #3299:
URL: https://github.com/apache/flink-cdc/pull/3299#discussion_r1615917895


##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/MySqlStreamingChangeEventSource.java:
##
@@ -257,6 +260,9 @@ public Event nextEvent(ByteArrayInputStream inputStream) 
throws IOException {
 try {
 // Delegate to the superclass ...
 Event event = super.nextEvent(inputStream);
+if (event == null) {
+return null;

Review Comment:
   +1, I also did't see why we need to skip the null events



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org