Re: [PR] [FLINK-35432]Support catch modify event for the mysql. [flink-cdc]
ruanhang1993 merged PR #3352: URL: https://github.com/apache/flink-cdc/pull/3352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35432]Support catch modify event for the mysql. [flink-cdc]
ruanhang1993 commented on code in PR #3352:
URL: https://github.com/apache/flink-cdc/pull/3352#discussion_r1694788416
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/parser/CustomAlterTableParserListener.java:
##
@@ -234,6 +234,32 @@ public void
enterAlterByRenameColumn(MySqlParser.AlterByRenameColumnContext ctx)
super.enterAlterByRenameColumn(ctx);
}
+@Override
+public void
enterAlterByModifyColumn(MySqlParser.AlterByModifyColumnContext ctx) {
+String oldColumnName = parser.parseName(ctx.uid(0));
+ColumnEditor columnEditor = Column.editor().name(oldColumnName);
+columnEditor.unsetDefaultValueExpression();
Review Comment:
@hk-lrzy Thanks for this PR.
`MODIFY` event is a difficult change event to support.
According to mysql
doc(https://dev.mysql.com/doc/refman/8.4/en/alter-table.html), multi parts
about this column may be changed from this DDL.
For the example in this doc, not only the data type, but also the default
value is changed. But we cannot get that change from this message.
We have plans to support changes in default values. Please add some notes
about this problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-35432]Support catch modify event for the mysql. [flink-cdc]
ruanhang1993 commented on code in PR #3352:
URL: https://github.com/apache/flink-cdc/pull/3352#discussion_r1694788416
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/parser/CustomAlterTableParserListener.java:
##
@@ -234,6 +234,32 @@ public void
enterAlterByRenameColumn(MySqlParser.AlterByRenameColumnContext ctx)
super.enterAlterByRenameColumn(ctx);
}
+@Override
+public void
enterAlterByModifyColumn(MySqlParser.AlterByModifyColumnContext ctx) {
+String oldColumnName = parser.parseName(ctx.uid(0));
+ColumnEditor columnEditor = Column.editor().name(oldColumnName);
+columnEditor.unsetDefaultValueExpression();
Review Comment:
@hk-lrzy Thanks for this PR.
`MODIFY` event is a difficult change event to support.
According to mysql
doc(https://dev.mysql.com/doc/refman/8.4/en/alter-table.html), multi parts
about this column may be changed from this DDL.
For the example in this doc, not only the data type, but also the default
value is changed. But we cannot get that change from this message.
We have plans to support changes in default values. Please some notes about
this problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-35432]Support catch modify event for the mysql. [flink-cdc]
yuxiqian commented on PR #3352: URL: https://github.com/apache/flink-cdc/pull/3352#issuecomment-2255011225 Could @ruanhang1993 take a look on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35432]Support catch modify event for the mysql. [flink-cdc]
github-actions[bot] commented on PR #3352: URL: https://github.com/apache/flink-cdc/pull/3352#issuecomment-2254287277 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35432]Support catch modify event for the mysql. [flink-cdc]
yuxiqian commented on PR #3352: URL: https://github.com/apache/flink-cdc/pull/3352#issuecomment-2134293705 > @yuxiqian can you help me trigger cicd? Sorry I do not have such privilege, either. You may create a PR to your fork repository (e.g. from `hk-lrzy:FLINK-35432` to `hk-lrzy:master`) to run CI on your own repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35432]Support catch modify event for the mysql. [flink-cdc]
hk-lrzy commented on PR #3352: URL: https://github.com/apache/flink-cdc/pull/3352#issuecomment-2134282172 @yuxiqian can you help me trigger cicd? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35432]Support catch modify event for the mysql. [flink-cdc]
hk-lrzy closed pull request #3352: [FLINK-35432]Support catch modify event for the mysql. URL: https://github.com/apache/flink-cdc/pull/3352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35432]Support catch modify event for the mysql. [flink-cdc]
yuxiqian commented on PR #3352: URL: https://github.com/apache/flink-cdc/pull/3352#issuecomment-2127127618 Hi @hk-lrzy, thanks for your contribution! Missing of `MODIFY COLUMN` in MySQL DDL parsing is a glitch and needs to be resolved. As for downstream sink support, I'm currently working on FLINK-35242 to provide "Partial Schema Apply" ability. Feel free to leave your comments since it's still in very early stage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
