Re: [PR] [FLINK-35464] Fixes operator state backwards compatibility from CDC 3.0.x [flink-cdc]
PatrickRen merged PR #3369: URL: https://github.com/apache/flink-cdc/pull/3369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35464] Fixes operator state backwards compatibility from CDC 3.0.x [flink-cdc]
yuxiqian commented on PR #3369: URL: https://github.com/apache/flink-cdc/pull/3369#issuecomment-2147045294 Thanks for the tips! Addressed your comments to simplify pom files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35464] Fixes operator state backwards compatibility from CDC 3.0.x [flink-cdc]
PatrickRen commented on code in PR #3369: URL: https://github.com/apache/flink-cdc/pull/3369#discussion_r1625602137 ## flink-cdc-migration-tests/pom.xml: ## @@ -19,13 +19,10 @@ limitations under the License. xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> 4.0.0 - Review Comment: Actually you can keep the section here. Removing `flink-cdc-migration-tests` from the section in the parent pom should be enough. ## pom.xml: ## @@ -40,7 +40,6 @@ limitations under the License. flink-cdc-connect flink-cdc-runtime flink-cdc-e2e-tests -flink-cdc-migration-tests Review Comment: Is it possible to use profiles to control whether to build `flink-cdc-migration-tests` module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35464] Fixes operator state backwards compatibility from CDC 3.0.x [flink-cdc]
yuxiqian commented on PR #3369: URL: https://github.com/apache/flink-cdc/pull/3369#issuecomment-2144714724 Thanks for @PatrickRen's comments! I too agree that it's not very elegant to package all history versions just for compatibility test, but seems to be inevitable since there's no such thing like C's macro or conditional compilation in Java. What I'm thinking of is 1) moving those dummy projects to somewhere outside (like `yuxiqian/dummy-cdc-migration-test` repo), or 2) write a script to dynamically generate dummy projects during the CI. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35464] Fixes operator state backwards compatibility from CDC 3.0.x [flink-cdc]
yuxiqian commented on PR #3369: URL: https://github.com/apache/flink-cdc/pull/3369#issuecomment-2134691687 @leonardBang @PatrickRen PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-35464] Fixes operator state backwards compatibility from CDC 3.0.x [flink-cdc]
yuxiqian opened a new pull request, #3369: URL: https://github.com/apache/flink-cdc/pull/3369 This closes FLINK-35441 and FLINK-35464. Flink CDC 3.1 changes how SchemaRegistry [de]serializes state data, which causes any checkpoint states saved with earlier version could not be restored in version 3.1.0. This PR adds serialization versioning for state payloads and ensures 3.0.x state could be successfully restored. Unfortunately 3.1.0 introduces breaking changes without bumping serialization version, so this release will be excluded from state compatibility guarantee. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
