Re: [PR] [FLINK-35468][Connectors/Pulsar] update isEnableAutoAcknowledgeMessage config comment [flink-connector-pulsar]

[via GitHub]

boring-cyborg[bot] commented on PR #93:
URL: 
https://github.com/apache/flink-connector-pulsar/pull/93#issuecomment-2134308720

   Thanks for opening this pull request! Please check out our contributing 
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [FLINK-35468][Connectors/Pulsar] update isEnableAutoAcknowledgeMessage config comment [flink-connector-pulsar]

[via GitHub]

geniusjoe opened a new pull request, #93:
URL: https://github.com/apache/flink-connector-pulsar/pull/93

   
   
   ## Purpose of the change
   
   
   Since we [deleted shared and key-shared subscription 
type](https://issues.apache.org/jira/browse/FLINK-30413) in pulsar source 
connector, I think it is better to remove these subscription type in 
isEnableAutoAcknowledgeMessage option comment to prevent misunderstanding.
   
   ## Brief change log
   update SourceConfiguration.java `isEnableAutoAcknowledgeMessage` comment.
   
   ## Significant changes
   
   - [ ] Dependencies have been added or upgraded
   - [ ] Public API has been changed (Public API is any class annotated with 
`@Public(Evolving)`)
   - [ ] Serializers have been changed
   - [ ] New feature has been introduced
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org