Re: [PR] [build] fix jackson conflicts among cdc connectors [flink-cdc]

2024-06-04 Thread via GitHub


leonardBang merged PR #2987:
URL: https://github.com/apache/flink-cdc/pull/2987


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [build] fix jackson conflicts among cdc connectors [flink-cdc]

2024-03-27 Thread via GitHub


link3280 commented on PR #2987:
URL: https://github.com/apache/flink-cdc/pull/2987#issuecomment-2024287943

   ping @leonardBang @PatrickRen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [build] fix jackson conflicts among cdc connectors [flink-cdc]

2024-03-18 Thread via GitHub


link3280 commented on code in PR #2987:
URL: https://github.com/apache/flink-cdc/pull/2987#discussion_r1528102292


##
pom.xml:
##
@@ -95,6 +96,36 @@ under the License.
 
 
 
+
+com.fasterxml.jackson.core

Review Comment:
   Good point. Thanks a lot for your input!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [build] fix jackson conflicts among cdc connectors [flink-cdc]

2024-03-17 Thread via GitHub


Shawn-Hx commented on code in PR #2987:
URL: https://github.com/apache/flink-cdc/pull/2987#discussion_r1527909731


##
pom.xml:
##
@@ -95,6 +96,36 @@ under the License.
 
 
 
+
+com.fasterxml.jackson.core

Review Comment:
   Thanks for your contribution. I think using 
[jackson-bom](https://github.com/FasterXML/jackson-bom) here is more clear.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [build] fix jackson conflicts among cdc connectors [flink-cdc]

2024-03-17 Thread via GitHub


link3280 commented on PR #2987:
URL: https://github.com/apache/flink-cdc/pull/2987#issuecomment-2002817974

   ping @leonardBang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org