Re: [PR] [hotfix][core][test] fix ArchUnit typo in pom [flink]
JingGe merged PR #23826: URL: https://github.com/apache/flink/pull/23826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][core][test] fix ArchUnit typo in pom [flink]
JingGe commented on PR #23826: URL: https://github.com/apache/flink/pull/23826#issuecomment-1837976261 Thanks @TanYuxin-tyx for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][core][test] fix ArchUnit typo in pom [flink]
JingGe commented on code in PR #23826: URL: https://github.com/apache/flink/pull/23826#discussion_r1411584321 ## flink-formats/flink-orc/pom.xml: ## @@ -182,7 +182,7 @@ under the License. test-jar - + Review Comment: Thanks @TanYuxin-tyx for the review. I have addressed it. Please check if there is still any one missed. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][core][test] fix ArchUnit typo in pom [flink]
TanYuxin-tyx commented on code in PR #23826: URL: https://github.com/apache/flink/pull/23826#discussion_r1409175868 ## flink-formats/flink-orc/pom.xml: ## @@ -182,7 +182,7 @@ under the License. test-jar - + Review Comment: @JingGe Thanks for the fix. But there are many similar typos and you can find them by global search. (e.g., https://github.com/apache/flink/blob/667d3a4cf7f59eb488dbbc4d4333df5220c85158/flink-formats/flink-compress/pom.xml#L94, https://github.com/apache/flink/blob/667d3a4cf7f59eb488dbbc4d4333df5220c85158/flink-table/flink-table-planner/pom.xml#L153, etc.) We'd better fix them together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][core][test] fix ArchUnit typo in pom [flink]
flinkbot commented on PR #23826: URL: https://github.com/apache/flink/pull/23826#issuecomment-1831307968 ## CI report: * e01506ef2edf4b73bf86440f77512f50239fa0d5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [hotfix][core][test] fix ArchUnit typo in pom [flink]
JingGe opened a new pull request, #23826: URL: https://github.com/apache/flink/pull/23826 ## What is the purpose of the change fix ArchUnit typo in pom of flink-core ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
