Re: [PR] [hotfix][table] refactoring to template method to separate concerns [flink]

[via GitHub]

JingGe merged PR #23857:
URL: https://github.com/apache/flink/pull/23857


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table] refactoring to template method to separate concerns [flink]

[via GitHub]

JingGe commented on PR #23857:
URL: https://github.com/apache/flink/pull/23857#issuecomment-1838480627

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table] refactoring to template method to separate concerns [flink]

[via GitHub]

fsk119 commented on code in PR #23857:
URL: https://github.com/apache/flink/pull/23857#discussion_r1413440533


##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/print/TableauStyle.java:
##
@@ -115,14 +115,26 @@ public final class TableauStyle implements PrintStyle {
 return columnWidths;
 }
 
-@Override

Review Comment:
   Why remove Override?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix][table] refactoring to template method to separate concerns [flink]

[via GitHub]

flinkbot commented on PR #23857:
URL: https://github.com/apache/flink/pull/23857#issuecomment-1837186832

   
   ## CI report:
   
   * b7f62e249f5ad4280b0a994bf87ef64323d2dee3 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [hotfix][table] refactoring to template method to separate concerns [flink]

[via GitHub]

JingGe opened a new pull request, #23857:
URL: https://github.com/apache/flink/pull/23857

   ## What is the purpose of the change
   
   refactoring to template method to separate concerns
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as TableauStyleTest.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / **no**)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
 - The serializers: (yes / **no** / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
 - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / **no**)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org