[PR] [hotfix] [docs] Update README.md to remove Maven [flink]
asafm opened a new pull request, #23981: URL: https://github.com/apache/flink/pull/23981 ## What is the purpose of the change Small fix to README ## Brief change log No need for pre-installed maven, since we have Maven Wrapper ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing This change is a trivial rework / code cleanup without any test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] [docs] Update README.md to remove Maven [flink]
asafm closed pull request #23981: [hotfix] [docs] Update README.md to remove Maven URL: https://github.com/apache/flink/pull/23981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] [docs] Update README.md to remove Maven [flink]
flinkbot commented on PR #23981: URL: https://github.com/apache/flink/pull/23981#issuecomment-1866287852 ## CI report: * 8bac98b51ccb4a13d5a498e377f17bb86b953b1d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] [docs] Update README.md to remove Maven [flink]
snuyanzin commented on PR #23981: URL: https://github.com/apache/flink/pull/23981#issuecomment-1866302758 having maven wrapper does not protect from running with installed maven -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] [docs] Update README.md to remove Maven [flink]
asafm commented on PR #23981: URL: https://github.com/apache/flink/pull/23981#issuecomment-1868536450 @snuyanzin Why would you want users, to run with their installed Maven? If you want all users to have reproducible builds, they should only use the maven wrapper, pinned to a specific version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] [docs] Update README.md to remove Maven [flink]
snuyanzin commented on PR #23981: URL: https://github.com/apache/flink/pull/23981#issuecomment-1868594128 1. the PR is incomplete: removal requirement for maven is not enough since to make it reproducible there is no info how to enable it in IDE. In that case in terminal there will be wrapper used and in IDE not if follow instructions only 2. across the documentation there are lots of of mentions of just `mvn ...` without mentioing `./mvnw` 3. Is there any issue which could be reproduced by wraper and not reproduced by installed maven or vice versa or what is the reason to have the restriction to wrapper only? 4. Should we have a restriction for maven-wrapper version then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] [docs] Update README.md to remove Maven [flink]
asafm commented on PR #23981: URL: https://github.com/apache/flink/pull/23981#issuecomment-1871374396 Guys, I just thought it make sense that if you use internally maven wrapper, then the getting started README should mention that and not "force" users to download maven and run the build incompatible with the way you guys run internally. Feel free to close this PR :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
