Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]
TestBoost commented on PR #23910: URL: https://github.com/apache/flink/pull/23910#issuecomment-1856543512 Hi, So to clarify, would the preferred change be to start a cluster per-test-class and to share between test methods? Looking at the test class, perhaps this could be accomplished by sharing the `JobClient` object that each test method creates (though perhaps `testJobRunningIfDisableClientHeartbeat` cannot easily share due to a difference in configuration)? Or perhaps do you have another kind of change in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]
reswqa commented on PR #23910: URL: https://github.com/apache/flink/pull/23910#issuecomment-1857249121 To be honest, I prefer to leave it as it is. Since I don't see much benefit, this `1s` speed up doesn't necessarily show up in the CI environment, but it does increase the instability of the test class (especially this class shows the characteristics of flaky test to some extent 😞). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
