Re: [PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]
echauchot merged PR #31: URL: https://github.com/apache/flink-connector-shared-utils/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]
echauchot commented on PR #31: URL: https://github.com/apache/flink-connector-shared-utils/pull/31#issuecomment-1857840750 @snuyanzin regarding [our version question](https://github.com/apache/flink-connector-shared-utils/pull/28#issuecomment-1845318521) let's not bother @zentol, I found part of the answer in Flink [release process](https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release) in "Create a new version in JIRA section": the process is to increment the minor version in jira version tag and only PMC members can do so. So I guess we shall use the minor version and not the patch version as PMC did. Merging this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]
echauchot opened a new pull request, #31: URL: https://github.com/apache/flink-connector-shared-utils/pull/31 @zentol next version jira label for new connector-parent already exists but contains version 1.1.0 and not 1.0.1 (hence this change). Do you agree that the yet-to-release changes [1] are worth incrementing the minor version instead of the patch version? [1]: https://github.com/apache/flink-connector-shared-utils/commit/813ab45461ef29dd841d63995e97b40125a0d7e4 https://github.com/apache/flink-connector-shared-utils/commit/808184ab723d678a4966ae4c45096c4bd6d3e756 https://github.com/apache/flink-connector-shared-utils/commit/ac09d18d874691f00629c90726458011034ea106 https://github.com/apache/flink-connector-shared-utils/commit/7c2745af777c6681b9eb14f0b05b2136fb141784 CC: @snuyanzin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]
echauchot commented on PR #28: URL: https://github.com/apache/flink-connector-shared-utils/pull/28#issuecomment-1856141477 I just realized that I submitted the PR against main branch instead of parent-pom branch, closing and reopening ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]
echauchot closed pull request #28: [hotfix] Set version to 1.1.0 and not 1.0.1 URL: https://github.com/apache/flink-connector-shared-utils/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]
snuyanzin commented on PR #28: URL: https://github.com/apache/flink-connector-shared-utils/pull/28#issuecomment-1845318521 That's a good question... frankly I don't know the answer, in jira i selected the only available one... I didn't participate in 1.0.0 release, may be @MartijnVisser or @zentol have more insides about that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]
echauchot opened a new pull request, #28: URL: https://github.com/apache/flink-connector-shared-utils/pull/28 @snuyanzin I realised that the version label in jira was 1.1.0 and not 1.0.1 hence this update. Are the recent changes considered patches of the 1.0 version or a new minor version 1.1 ? I tend to chose the later. WDYT ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
