Re: [PR] Bump org.yaml:snakeyaml from 1.31 to 2.0 [flink-connector-elasticsearch]

2024-02-13 Thread via GitHub


MartijnVisser commented on PR #90:
URL: 
https://github.com/apache/flink-connector-elasticsearch/pull/90#issuecomment-1941612550

   > where did you get this info?
   
   Hmmm I would have sworn that was the case, but apparently I was wrong 
because https://bitbucket.org/snakeyaml/snakeyaml/wiki/Changes lists as 
requiring Java 7 to run (and 11 to build)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.yaml:snakeyaml from 1.31 to 2.0 [flink-connector-elasticsearch]

2024-02-13 Thread via GitHub


snuyanzin commented on PR #90:
URL: 
https://github.com/apache/flink-connector-elasticsearch/pull/90#issuecomment-1940820849

   @MartijnVisser 
   >since SnakeYAML requires JDK17
   
   where did you get this info?
   
   here it is a quote from official SnakeYAML readme [1]
   >SnakeYAML is a YAML 1.1 processor for the Java Virtual Machine version 8+.
   
   [1] https://bitbucket.org/snakeyaml/snakeyaml/src/snakeyaml-2.1/README.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.yaml:snakeyaml from 1.31 to 2.0 [flink-connector-elasticsearch]

2024-02-13 Thread via GitHub


MartijnVisser commented on PR #90:
URL: 
https://github.com/apache/flink-connector-elasticsearch/pull/90#issuecomment-1940775718

   @snuyanzin I'm confused, I would have expected CI to fail since SnakeYAML 
requires JDK17; any idea why everything passed on JDK8 and JDK11? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org