[jira] [Comment Edited] (FLINK-10569) Clean up uses of Scheduler and Instance in valid tests
[
https://issues.apache.org/jira/browse/FLINK-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655620#comment-16655620
]
TisonKun edited comment on FLINK-10569 at 10/18/18 5:22 PM:
I find this topic is more complex than I ever thought. We actually have two
version of slot implementation and current {{ExecutionGraph}} tests heavily
depend on legacy slot implementation. Maybe we should separate this thread into
stepwise issues decouples existing valid tests with legacy slot
implementation(as well as Scheduler and Instance).
cc [~till.rohrmann].
was (Author: tison):
I find this topic is more complex than I ever thought. We actually have two
version of slot implementation and current {{ExecutionGraph}} tests heavily
depend on legacy slot implementation. Maybe we should separated this thread
into stepwise issues decouples existing valid tests with legacy slot
implementation(as well as Scheduler and Instance).
cc [~till.rohrmann].
> Clean up uses of Scheduler and Instance in valid tests
> --
>
> Key: FLINK-10569
> URL: https://issues.apache.org/jira/browse/FLINK-10569
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
> Fix For: 1.7.0
>
>
> Legacy class {{Scheduler}} and {{Instance}} are still used in some valid
> tests like {{ExecutionGraphRestartTest}}. We should replace them with FLIP-6
> schedule mode. The best way I can find is use {{SimpleSlotProvider}}.
> Note that we need not to remove all use points among all files since most of
> them stay in legacy codebase like {{JobManager.scala}} and would be removed
> later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-10569) Clean up uses of Scheduler and Instance in valid tests
[
https://issues.apache.org/jira/browse/FLINK-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655620#comment-16655620
]
TisonKun edited comment on FLINK-10569 at 10/18/18 5:22 PM:
I find this topic is more complex than I ever thought. We actually have two
version of slot implementation and current {{ExecutionGraph}} tests heavily
depend on legacy slot implementation. Maybe we should separated this thread
into stepwise issues decouples existing valid tests with legacy slot
implementation(as well as Scheduler and Instance).
cc [~till.rohrmann].
was (Author: tison):
I find this topic is more complex than I ever thought. We actually have two
version of slot implementation and current {{ExecutionGraph}} related tests
heavily depend on legacy slot implementation. Maybe we should separated this
thread into stepwise issues decouples existing valid tests with legacy slot
implementation(as well as Scheduler and Instance).
cc [~till.rohrmann].
> Clean up uses of Scheduler and Instance in valid tests
> --
>
> Key: FLINK-10569
> URL: https://issues.apache.org/jira/browse/FLINK-10569
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
> Fix For: 1.7.0
>
>
> Legacy class {{Scheduler}} and {{Instance}} are still used in some valid
> tests like {{ExecutionGraphRestartTest}}. We should replace them with FLIP-6
> schedule mode. The best way I can find is use {{SimpleSlotProvider}}.
> Note that we need not to remove all use points among all files since most of
> them stay in legacy codebase like {{JobManager.scala}} and would be removed
> later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
