[jira] [Comment Edited] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-05-02 Thread Cliff Resnick (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831932#comment-16831932
 ] 

Cliff Resnick edited comment on FLINK-12334 at 5/2/19 8:28 PM:
---

Hi [~fan_li_ya]

We have a custom StreamOperator with an open() method like:

 

{{override def open(): Unit = {}}
{{ getRuntimeContext.addAccumulator("combiner-in", recordsIn)}}
{{  getRuntimeContext.addAccumulator("combiner-out", recordsOut)}}

{{}}}

The `getRuntimeContext.addAccumulator` call no longer works in 1.8 because the 
MockStreamTask  returned by getRuntimeContext is trying to add the accumulator 
to an immutable empty map.

 

 

 


was (Author: cre...@gmail.com):
Hi [~fan_li_ya]

We have a custom StreamOperator with an open() method like:

 

{{override def open(): Unit = {}}
{{ getRuntimeContext.addAccumulator("combiner-in", recordsIn)}}
{{ getRuntimeContext.addAccumulator("combiner-out", recordsOut)}}

{{ getProcessingTimeService.scheduleAtFixedRate(this, pause, pause)}}
{{}}}

The `getRuntimeContext.addAccumulator` call no longer works in 1.8 because the 
MockStreamTask  returned by getRuntimeContext is trying to add the accumulator 
to an immutable empty map.

 

 

 

> change to MockStreamTask breaks OneInputStreamOperatorTestHarness
> -
>
> Key: FLINK-12334
> URL: https://issues.apache.org/jira/browse/FLINK-12334
> Project: Flink
>  Issue Type: Bug
>  Components: API / DataStream
>Affects Versions: 1.8.0
>Reporter: Cliff Resnick
>Priority: Major
>
> The move to the MockStreamTask is created with does not include 
> initialization of an Accumulator Map when using the builder
> [https://github.com/apache/flink/blob/e43d55445e7abcadb92460bb4d61e28540f1189d/flink-streaming-java/src/test/java/org/apache/flink/streaming/util/AbstractStreamOperatorTestHarness.java#L198]
> This results in with a TestHarness whose context contains an immutable empty 
> map and is breaking tests. The fix is simple, please include an actual map in 
> the builder call.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-05-02 Thread Cliff Resnick (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831932#comment-16831932
 ] 

Cliff Resnick edited comment on FLINK-12334 at 5/2/19 8:27 PM:
---

Hi [~fan_li_ya]

We have a custom StreamOperator with an open() method like:

{{override def open(): Unit = {}}
{{ getRuntimeContext.addAccumulator("combiner-in", recordsIn)}}
{{ getRuntimeContext.addAccumulator("combiner-out", recordsOut)}}

{{ getProcessingTimeService.scheduleAtFixedRate(this, pause, pause)}}
{{}}}

 

The `getRuntimeContext.addAccumulator` call no longer works in 1.8 because the 
MockStreamTask  returned by getRuntimeContext is trying to add the accumulator 
to an immutable empty map.

 

 

 


was (Author: cre...@gmail.com):
Hi [~fan_li_ya]

We have a custom StreamOperator with an open() method like:
{{
  override def open(): Unit = {
getRuntimeContext.addAccumulator("combiner-in", recordsIn)
getRuntimeContext.addAccumulator("combiner-out", recordsOut)

getProcessingTimeService.scheduleAtFixedRate(this, pause, pause)
  }
}}
 

The `getRuntimeContext.addAccumulator` call no longer works in 1.8 because the 
MockStreamTask  returned by getRuntimeContext is trying to add the accumulator 
to an immutable empty map.

 

 

 

> change to MockStreamTask breaks OneInputStreamOperatorTestHarness
> -
>
> Key: FLINK-12334
> URL: https://issues.apache.org/jira/browse/FLINK-12334
> Project: Flink
>  Issue Type: Bug
>  Components: API / DataStream
>Affects Versions: 1.8.0
>Reporter: Cliff Resnick
>Priority: Major
>
> The move to the MockStreamTask is created with does not include 
> initialization of an Accumulator Map when using the builder
> [https://github.com/apache/flink/blob/e43d55445e7abcadb92460bb4d61e28540f1189d/flink-streaming-java/src/test/java/org/apache/flink/streaming/util/AbstractStreamOperatorTestHarness.java#L198]
> This results in with a TestHarness whose context contains an immutable empty 
> map and is breaking tests. The fix is simple, please include an actual map in 
> the builder call.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-05-02 Thread Cliff Resnick (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831932#comment-16831932
 ] 

Cliff Resnick edited comment on FLINK-12334 at 5/2/19 8:27 PM:
---

Hi [~fan_li_ya]

We have a custom StreamOperator with an open() method like:

 

{{override def open(): Unit = {}}
{{ getRuntimeContext.addAccumulator("combiner-in", recordsIn)}}
{{ getRuntimeContext.addAccumulator("combiner-out", recordsOut)}}

{{ getProcessingTimeService.scheduleAtFixedRate(this, pause, pause)}}
{{}}}

The `getRuntimeContext.addAccumulator` call no longer works in 1.8 because the 
MockStreamTask  returned by getRuntimeContext is trying to add the accumulator 
to an immutable empty map.

 

 

 


was (Author: cre...@gmail.com):
Hi [~fan_li_ya]

We have a custom StreamOperator with an open() method like:

{{override def open(): Unit = {}}
{{ getRuntimeContext.addAccumulator("combiner-in", recordsIn)}}
{{ getRuntimeContext.addAccumulator("combiner-out", recordsOut)}}

{{ getProcessingTimeService.scheduleAtFixedRate(this, pause, pause)}}
{{}}}

 

The `getRuntimeContext.addAccumulator` call no longer works in 1.8 because the 
MockStreamTask  returned by getRuntimeContext is trying to add the accumulator 
to an immutable empty map.

 

 

 

> change to MockStreamTask breaks OneInputStreamOperatorTestHarness
> -
>
> Key: FLINK-12334
> URL: https://issues.apache.org/jira/browse/FLINK-12334
> Project: Flink
>  Issue Type: Bug
>  Components: API / DataStream
>Affects Versions: 1.8.0
>Reporter: Cliff Resnick
>Priority: Major
>
> The move to the MockStreamTask is created with does not include 
> initialization of an Accumulator Map when using the builder
> [https://github.com/apache/flink/blob/e43d55445e7abcadb92460bb4d61e28540f1189d/flink-streaming-java/src/test/java/org/apache/flink/streaming/util/AbstractStreamOperatorTestHarness.java#L198]
> This results in with a TestHarness whose context contains an immutable empty 
> map and is breaking tests. The fix is simple, please include an actual map in 
> the builder call.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-05-02 Thread Cliff Resnick (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831932#comment-16831932
 ] 

Cliff Resnick edited comment on FLINK-12334 at 5/2/19 8:26 PM:
---

Hi [~fan_li_ya]

We have a custom StreamOperator with an open() method like:
{{
  override def open(): Unit = {
getRuntimeContext.addAccumulator("combiner-in", recordsIn)
getRuntimeContext.addAccumulator("combiner-out", recordsOut)

getProcessingTimeService.scheduleAtFixedRate(this, pause, pause)
  }
}}
 

The `getRuntimeContext.addAccumulator` call no longer works in 1.8 because the 
MockStreamTask  returned by getRuntimeContext is trying to add the accumulator 
to an immutable empty map.

 

 

 


was (Author: cre...@gmail.com):
Hi [~fan_li_ya]

We have a custom StreamOperator with an open() method like:

override def open(): Unit = {
 getRuntimeContext.addAccumulator("combiner-in", recordsIn)
 getRuntimeContext.addAccumulator("combiner-out", recordsOut)

 getProcessingTimeService.scheduleAtFixedRate(this, pause, pause)
}

The `getRuntimeContext.addAccumulator` call no longer works in 1.8 because the 
MockStreamTask  returned by getRuntimeContext is trying to add the accumulator 
to an immutable empty map.

 

 

 

> change to MockStreamTask breaks OneInputStreamOperatorTestHarness
> -
>
> Key: FLINK-12334
> URL: https://issues.apache.org/jira/browse/FLINK-12334
> Project: Flink
>  Issue Type: Bug
>  Components: API / DataStream
>Affects Versions: 1.8.0
>Reporter: Cliff Resnick
>Priority: Major
>
> The move to the MockStreamTask is created with does not include 
> initialization of an Accumulator Map when using the builder
> [https://github.com/apache/flink/blob/e43d55445e7abcadb92460bb4d61e28540f1189d/flink-streaming-java/src/test/java/org/apache/flink/streaming/util/AbstractStreamOperatorTestHarness.java#L198]
> This results in with a TestHarness whose context contains an immutable empty 
> map and is breaking tests. The fix is simple, please include an actual map in 
> the builder call.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)