[jira] [Comment Edited] (FLINK-14178) maven-shade-plugin 3.2.1 doesn't work on ARM for Flink

2019-09-24 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936693#comment-16936693
 ] 

Dian Fu edited comment on FLINK-14178 at 9/24/19 11:36 AM:
---

Hi [~wangxiyuan], 
 Thanks a lot for your great work. The maven-shade-plugin is bumped because it 
introduces the dependency of Beam for Python UDF support and maven-shade-plugin 
of version below 3.1.0 does not work well with ASM 6.0 (MSHADE-258) which is 
dependent by Beam. It bump it directly from 3.0.0 to 3.2.1 because we noticed 
that profile java11 has upgraded maven-shade-plugin to 3.2.1 as it only 
supports java11 since [3.2.1|https://github.com/apache/flink/pull/9294]. So 
downgrade maven-shade-plugin to 3.1.0 will not break the functionality of 
Python UDF and I'm +1 if downgrade is needed. Just want to point out that as 
maven-shade-plugin only supports java11 since 3.2.1 and it doesn't work on ARM 
for 3.2.1. It means that it's not possible to build flink on ARM for java11. 
Could you confirm this?


was (Author: dian.fu):
Hi [~wangxiyuan], 
 Thanks a lot for your great work. The maven-shade-plugin is bumped because it 
introduces the dependency of Beam for Python UDF support and maven-shade-plugin 
of version below 3.1.0 does not work well with ASM 6.0 (MSHADE-258) which is 
dependent by Beam. It bump it directly from 3.0.0 to 3.2.1 because we noticed 
that profile java11 has upgraded maven-shade-plugin to 3.2.1 as it only 
supports java11 since [3.2.1|https://github.com/apache/flink/pull/9294]. So 
downgrade maven-shade-plugin to 3.1.0 will not break the functionality of 
Python UDF and I'm +1 if downgrade is needed. Just want to point out that as 
maven-shade-plugin only supports java11 since 3.2.1 and it doesn't work on ARM 
for 3.2.1. It means that it's not possible to build flink on ARM for java11. 
Could you verify this?

> maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
> --
>
> Key: FLINK-14178
> URL: https://issues.apache.org/jira/browse/FLINK-14178
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Affects Versions: 2.0.0
>Reporter: wangxiyuan
>Priority: Minor
> Fix For: 2.0.0
>
>
> recently, maven-shade-plugin  is bumped from 3.0.0 to 3.2.1 by the 
> [commit|https://github.com/apache/flink/commit/e7216eebc846a69272c21375af0f4db8009c2e3e].
>  While with my test locally on ARM, The Flink build process will be jammed. 
> After debugging, I found there is an infinite loop.
> Downgrade maven-shade-plugin to 3.1.0 can solve this problem.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FLINK-14178) maven-shade-plugin 3.2.1 doesn't work on ARM for Flink

2019-09-24 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936693#comment-16936693
 ] 

Dian Fu edited comment on FLINK-14178 at 9/24/19 11:35 AM:
---

Hi [~wangxiyuan], 
 Thanks a lot for your great work. The maven-shade-plugin is bumped because it 
introduces the dependency of Beam for Python UDF support and maven-shade-plugin 
of version below 3.1.0 does not work well with ASM 6.0 (MSHADE-258) which is 
dependent by Beam. It bump it directly from 3.0.0 to 3.2.1 because we noticed 
that profile java11 has upgraded maven-shade-plugin to 3.2.1 as it only 
supports java11 since [3.2.1|https://github.com/apache/flink/pull/9294]. So 
downgrade maven-shade-plugin to 3.1.0 will not break the functionality of 
Python UDF and I'm +1 if downgrade is needed. Just want to point out that as 
maven-shade-plugin only supports java11 since 3.2.1 and it doesn't work on ARM 
for 3.2.1. It means that it's not possible to build flink on ARM for java11. 
Could you verify this?


was (Author: dian.fu):
Hi [~wangxiyuan], 
Thanks a lot for your great work. The maven-shade-plugin is bumped because it 
introduces the dependency of Beam for Python UDF support and maven-shade-plugin 
of version below 3.1.0 does not work well with ASM 6.0 (MSHADE-258) which is 
dependent by Beam. It bump it directly from 3.0.0 to 3.2.1 because we noticed 
that profile java11 has upgraded maven-shade-plugin to 3.2.1 as it only 
supports java11 since [3.2.1|[https://github.com/apache/flink/pull/9294]]. So 
downgrade maven-shade-plugin to 3.1.0 will not break the functionality of 
Python UDF and I'm +1 if downgrade is needed. Just want to point out that as 
maven-shade-plugin only supports java11 since 3.2.1 and it doesn't work on ARM 
for 3.2.1. It means that it's not possible to build flink on ARM for java11. 
Could you verify this?

> maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
> --
>
> Key: FLINK-14178
> URL: https://issues.apache.org/jira/browse/FLINK-14178
> Project: Flink
>  Issue Type: Sub-task
>  Components: Build System
>Affects Versions: 2.0.0
>Reporter: wangxiyuan
>Priority: Minor
> Fix For: 2.0.0
>
>
> recently, maven-shade-plugin  is bumped from 3.0.0 to 3.2.1 by the 
> [commit|https://github.com/apache/flink/commit/e7216eebc846a69272c21375af0f4db8009c2e3e].
>  While with my test locally on ARM, The Flink build process will be jammed. 
> After debugging, I found there is an infinite loop.
> Downgrade maven-shade-plugin to 3.1.0 can solve this problem.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)