[jira] [Comment Edited] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option

2021-09-16 Thread Robert Metzger (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416020#comment-17416020
 ] 

Robert Metzger edited comment on FLINK-15816 at 9/16/21, 9:56 AM:
--

I reopened the issue, because I believe the "MAXIMUM_CHARACTERS_OF_CLUSTER_ID" 
is wrong for the K8s HA.

The longest string Flink appends is "-resourcemanager-leader" for the K8s HA 
config maps, which is 24 characters long.
63 - 24 = 39


was (Author: rmetzger):
I reopened the issue, because I believe the "MAXIMUM_CHARACTERS_OF_CLUSTER_ID" 
is wrong. 

The longest string Flink appends is "-resourcemanager-leader" for the K8s HA 
config maps, which is 24 characters long.
63 - 24 = 39

> Limit the maximum length of the value of kubernetes.cluster-id configuration 
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
>  Issue Type: Sub-task
>  Components: Deployment / Kubernetes
>Affects Versions: 1.10.0, 1.14.1
>Reporter: Canbin Zheng
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Two Kubernetes Service will be created when a session cluster is deployed, 
> one is the internal Service and the other is the rest Service, we set the 
> internal Service name to the value of the _kubernetes.cluster-id_ 
> configuration option and then set the rest Service name to  
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the 
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name 
> will be *session-test* and the rest Service name be *session-test-rest;* 
> there is a constraint in Kubernetes that the Service name must be no more 
> than 63 characters, for the current naming convention it leads to that the 
> value of _kubernetes.cluster-id_ should not be more than 58 characters, 
> otherwise there are scenarios that the internal Service is created 
> successfully then comes up with a ClusterDeploymentException when trying to 
> create the rest Service.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option

2020-02-02 Thread Yang Wang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028648#comment-17028648
 ] 

Yang Wang edited comment on FLINK-15816 at 2/3/20 3:23 AM:
---

[~felixzheng] The Flink client will throw a {{ClusterDeploymentException}} 
caused by {{KubernetesClientException}}. Do we really need to check this 
limitation additionally? I think what we need to do is to clean up the residual 
resources when the Flink client failed.


was (Author: fly_in_gis):
[~felixzheng] I think the Flink client will throw a 
{{ClusterDeploymentException}} caused by {{KubernetesClientException}}. Do we 
really need to check this limitation additionally? I think what we need to do 
is to clean up the residual resources when the Flink client failed.

> Limit the maximum length of the value of kubernetes.cluster-id configuration 
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
>  Issue Type: Sub-task
>  Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Minor
> Fix For: 1.11.0, 1.10.1
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>
> Two Kubernetes Service will be created when a session cluster is deployed, 
> one is the internal Service and the other is the rest Service, we set the 
> internal Service name to the value of the _kubernetes.cluster-id_ 
> configuration option and then set the rest Service name to  
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the 
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name 
> will be *session-test* and the rest Service name be *session-test-rest;* 
> there is a constraint in Kubernetes that the Service name must be no more 
> than 63 characters, for the current naming convention it leads to that the 
> value of _kubernetes.cluster-id_ should not be more than 58 characters, 
> otherwise there are scenarios that the internal Service is created 
> successfully then comes up with a ClusterDeploymentException when trying to 
> create the rest Service.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option

2020-01-30 Thread Canbin Zheng (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027126#comment-17027126
 ] 

Canbin Zheng edited comment on FLINK-15816 at 1/31/20 1:51 AM:
---

cc [~yangwang166] [~trohrmann]


was (Author: felixzheng):
cc [~yangwang166] @[~trohrmann]

> Limit the maximum length of the value of kubernetes.cluster-id configuration 
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
>  Issue Type: Sub-task
>  Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Priority: Minor
> Fix For: 1.11.0, 1.10.1
>
>
> Two Kubernetes Service will be created when a session cluster is deployed, 
> one is the internal Service and the other is the rest Service, we set the 
> internal Service name to the value of the _kubernetes.cluster-id_ 
> configuration option and then set the rest Service name to  
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the 
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name 
> will be *session-test* and the rest Service name be *session-test-rest;* 
> there is a constraint in Kubernetes that the Service name must be no more 
> than 63 characters, for the current naming convention it leads to that the 
> value of _kubernetes.cluster-id_ should not be more than 58 characters, 
> otherwise there are scenarios that the internal Service is created 
> successfully then comes up with a ClusterDeploymentException when trying to 
> create the rest Service.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)