[jira] [Comment Edited] (FLINK-23545) Use new schema in SqlCreateTableConverter

[zck (Jira)]

[ 
https://issues.apache.org/jira/browse/FLINK-23545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489934#comment-17489934
 ] 

zck edited comment on FLINK-23545 at 2/10/22, 3:50 AM:
---

I like this feature.

1.15  publish it?


was (Author: kcz):
I like this feature.

1.15 Can you publish it?

> Use new schema in SqlCreateTableConverter
> -
>
> Key: FLINK-23545
> URL: https://issues.apache.org/jira/browse/FLINK-23545
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / API
>Reporter: jinfeng
>Assignee: jinfeng
>Priority: Major
>  Labels: pull-request-available, stale-assigned
> Fix For: 1.15.0
>
>
> In order to support column comment in sql create table dll. We should  use 
> new schema in SqlCreateeTableConverter. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Comment Edited] (FLINK-23545) Use new schema in SqlCreateTableConverter

[Jark Wu (Jira)]

[ 
https://issues.apache.org/jira/browse/FLINK-23545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393979#comment-17393979
 ] 

Jark Wu edited comment on FLINK-23545 at 8/5/21, 1:00 PM:
--

Maybe we should use {{catalogTable}} instead of {{catalogTable.getOrigin()}} 
here? 
https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/FlinkCalciteCatalogReader.java#L202

cc [~twalthr]


was (Author: jark):
Maybe we should use {{catalogTable}} instead of {{catalogTable.getOrigin()}} 
here? 
https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/FlinkCalciteCatalogReader.java#L202

> Use new schema in SqlCreateTableConverter
> -
>
> Key: FLINK-23545
> URL: https://issues.apache.org/jira/browse/FLINK-23545
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / API
>Reporter: jinfeng
>Assignee: jinfeng
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> In order to support column comment in sql create table dll. We should  use 
> new schema in SqlCreateeTableConverter. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)