[jira] [Comment Edited] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-05 Thread Rui Fan (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851478#comment-17851478
 ] 

Rui Fan edited comment on FLINK-35496 at 6/5/24 9:28 AM:
-

Merged to main(jdbc-3.3.0) via:
 * b955e8b5479c65512f94ee7270eb2868a4a14ebe
 * 2defbbcf4fc550a76dd9c664e1eed7d261e028ca (revert the 
b955e8b5479c65512f94ee7270eb2868a4a14ebe)

 


was (Author: fanrui):
Merged to main(jdbc-3.2.0) via:
 * b955e8b5479c65512f94ee7270eb2868a4a14ebe
 * 2defbbcf4fc550a76dd9c664e1eed7d261e028ca (revert the 
b955e8b5479c65512f94ee7270eb2868a4a14ebe)

 

> The annotations of the new JDBC connector should be changed to 
> non-Public/non-PublicEvolving
> 
>
> Key: FLINK-35496
> URL: https://issues.apache.org/jira/browse/FLINK-35496
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Connectors / JDBC
>Reporter: RocMarshal
>Assignee: João Boto
>Priority: Major
>  Labels: pull-request-available
> Fix For: jdbc-3.2.0
>
>
> In general, we use the Experimental annotation instead of {{PublicEvolving}}  
> or {{Public}}  for new features or new apis. But  {{JdbcSink}} and 
> JdbcSource(merged ) was marked as {{PublicEvolving}}  in the first version. 
> [~fanrui]  commented it to the original PR[1].[1] 
> [https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1621857589]
> CC [~eskabetxe] [~Sergey Nuyanzin] [~fanrui] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-05 Thread Rui Fan (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851478#comment-17851478
 ] 

Rui Fan edited comment on FLINK-35496 at 6/5/24 9:28 AM:
-

Merged to main(jdbc-3.2.0) via:
 * b955e8b5479c65512f94ee7270eb2868a4a14ebe
 * 2defbbcf4fc550a76dd9c664e1eed7d261e028ca (revert the 
b955e8b5479c65512f94ee7270eb2868a4a14ebe)

 


was (Author: fanrui):
Merged to main(jdbc-3.2.0) via: b955e8b5479c65512f94ee7270eb2868a4a14ebe

> The annotations of the new JDBC connector should be changed to 
> non-Public/non-PublicEvolving
> 
>
> Key: FLINK-35496
> URL: https://issues.apache.org/jira/browse/FLINK-35496
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Connectors / JDBC
>Reporter: RocMarshal
>Assignee: João Boto
>Priority: Major
>  Labels: pull-request-available
> Fix For: jdbc-3.2.0
>
>
> In general, we use the Experimental annotation instead of {{PublicEvolving}}  
> or {{Public}}  for new features or new apis. But  {{JdbcSink}} and 
> JdbcSource(merged ) was marked as {{PublicEvolving}}  in the first version. 
> [~fanrui]  commented it to the original PR[1].[1] 
> [https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1621857589]
> CC [~eskabetxe] [~Sergey Nuyanzin] [~fanrui] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-03 Thread Leonard Xu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851671#comment-17851671
 ] 

Leonard Xu edited comment on FLINK-35496 at 6/3/24 2:43 PM:


I just want to clarify two points here: 
（1）We can mark class as PublicEvolving  in the first version of Java 
Class/Interface (usually we called public interfaces) if we discussed it in dev 
mailing list and be approved via FLIP vote. 
  (2)  Experimental annotation is used for experimental feature, Using 
PublicEvolving is also okay when a connector functionality migrate from legacy 
API implementation to new API implementation,  because the unified Sink API is 
Public instead of Experimental. 


was (Author: leonard xu):
I lust want to clarify two points here: 
（1）We can mark class as PublicEvolving  in the first version of Java 
Class/Interface (usually we called public interfaces) if we discussed it in dev 
mailing list and be approved via FLIP vote. 
  (2)  Experimental annotation is used for experimental feature, Using 
PublicEvolving is also okay when a connector functionality migrate from legacy 
API implementation to new API implementation,  because the unified Sink API is 
Public instead of Experimental. 

> The annotations of the new JDBC connector should be changed to 
> non-Public/non-PublicEvolving
> 
>
> Key: FLINK-35496
> URL: https://issues.apache.org/jira/browse/FLINK-35496
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Connectors / JDBC
>Reporter: RocMarshal
>Assignee: João Boto
>Priority: Major
>  Labels: pull-request-available
> Fix For: jdbc-3.2.0
>
>
> In general, we use the Experimental annotation instead of {{PublicEvolving}}  
> or {{Public}}  for new features or new apis. But  {{JdbcSink}} and 
> JdbcSource(merged ) was marked as {{PublicEvolving}}  in the first version. 
> [~fanrui]  commented it to the original PR[1].[1] 
> [https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1621857589]
> CC [~eskabetxe] [~Sergey Nuyanzin] [~fanrui] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-02 Thread Rui Fan (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851478#comment-17851478
 ] 

Rui Fan edited comment on FLINK-35496 at 6/3/24 2:00 AM:
-

Merged to main(jdbc-3.2.0) via: b955e8b5479c65512f94ee7270eb2868a4a14ebe


was (Author: fanrui):
Merged to main(jdbc-3.3.0) via: b955e8b5479c65512f94ee7270eb2868a4a14ebe

> The annotations of the new JDBC connector should be changed to 
> non-Public/non-PublicEvolving
> 
>
> Key: FLINK-35496
> URL: https://issues.apache.org/jira/browse/FLINK-35496
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Connectors / JDBC
>Reporter: RocMarshal
>Assignee: João Boto
>Priority: Major
>  Labels: pull-request-available
> Fix For: jdbc-3.2.0
>
>
> In general, we use the Experimental annotation instead of {{PublicEvolving}}  
> or {{Public}}  for new features or new apis. But  {{JdbcSink}} and 
> JdbcSource(merged ) was marked as {{PublicEvolving}}  in the first version. 
> [~fanrui]  commented it to the original PR[1].[1] 
> [https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1621857589]
> CC [~eskabetxe] [~Sergey Nuyanzin] [~fanrui] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)