[jira] [Commented] (FLINK-10010) Deprecate unused BaseAlignedWindowAssigner related components
[
https://issues.apache.org/jira/browse/FLINK-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628505#comment-16628505
]
ASF GitHub Bot commented on FLINK-10010:
aljoscha closed pull request #6471: [FLINK-10010][DataStream API] Deprecate
unused BaseAlignedWindowAssigner related components
URL: https://github.com/apache/flink/pull/6471
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/BaseAlignedWindowAssigner.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/BaseAlignedWindowAssigner.java
index 06e85e45044..bbff850e44c 100644
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/BaseAlignedWindowAssigner.java
+++
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/BaseAlignedWindowAssigner.java
@@ -27,15 +27,12 @@
import java.util.Collection;
/**
- * A base {@link WindowAssigner} used to instantiate one of the deprecated
- * {@link
org.apache.flink.streaming.runtime.operators.windowing.AccumulatingProcessingTimeWindowOperator
- * AccumulatingProcessingTimeWindowOperator} and
- * {@link
org.apache.flink.streaming.runtime.operators.windowing.AggregatingProcessingTimeWindowOperator
- * AggregatingProcessingTimeWindowOperator}.
+ * A base {@link WindowAssigner} used to instantiate one of the deprecated
operators.
*
- * For assigner that extend this one, the user can check the
- * {@link TumblingAlignedProcessingTimeWindows} and the {@link
SlidingAlignedProcessingTimeWindows}.
- * */
+ * @deprecated will be removed in a future version. please use other {@link
WindowAssigner}s listed under
+ * {@link org.apache.flink.streaming.api.windowing.assigners}.
+ */
+@Deprecated
public class BaseAlignedWindowAssigner extends WindowAssigner {
private static final long serialVersionUID = -6214980179706960234L;
@@ -57,7 +54,7 @@ public long getSize() {
@Override
public Trigger
getDefaultTrigger(StreamExecutionEnvironment env) {
- return null;
+ throw new UnsupportedOperationException("This assigner should
not be used with the WindowOperator.");
}
@Override
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingAlignedProcessingTimeWindows.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingAlignedProcessingTimeWindows.java
deleted file mode 100644
index dc2984bdc7c..000
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingAlignedProcessingTimeWindows.java
+++ /dev/null
@@ -1,76 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.streaming.api.windowing.assigners;
-
-import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.streaming.api.windowing.time.Time;
-
-/**
- * This is a special window assigner used to tell the system to use the
- * "Fast Aligned Processing Time Window Operator" for windowing.
- *
- * Prior Flink versions used that operator automatically for simple
processing time
- * windows (tumbling and sliding) when no custom trigger and no evictor was
specified.
- * In the current Flink version, that operator is only used when programs
explicitly
- * specify this window assigner. This is only intended for special cases where
programs relied on
- * the better performance of the fast aligned window operator, and are willing
to accept the lack
- * of support for various features as indicated below:
- *
- *
- * No custom state backend can be selected, the operator always stores
data on the Java heap.
- * The operator does not support key groups, meaning it cannot change
the parallelism.
- * Future versions of Flink
[jira] [Commented] (FLINK-10010) Deprecate unused BaseAlignedWindowAssigner related components
[
https://issues.apache.org/jira/browse/FLINK-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628504#comment-16628504
]
ASF GitHub Bot commented on FLINK-10010:
aljoscha commented on issue #6471: [FLINK-10010][DataStream API] Deprecate
unused BaseAlignedWindowAssigner related components
URL: https://github.com/apache/flink/pull/6471#issuecomment-424659529
Thanks @walterddr! I merged this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate unused BaseAlignedWindowAssigner related components
> -
>
> Key: FLINK-10010
> URL: https://issues.apache.org/jira/browse/FLINK-10010
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
>Reporter: Rong Rong
>Assignee: Rong Rong
>Priority: Major
> Labels: pull-request-available
>
> {{BaseAlignedWindowAssigner}} should be marked as deprecated and
> {{SlidingAlignedProcessingTimeWindows}} should be removed from the Flink Repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10010) Deprecate unused BaseAlignedWindowAssigner related components
[
https://issues.apache.org/jira/browse/FLINK-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613652#comment-16613652
]
ASF GitHub Bot commented on FLINK-10010:
walterddr commented on issue #6471: [FLINK-10010][DataStream API] Deprecate
unused BaseAlignedWindowAssigner related components
URL: https://github.com/apache/flink/pull/6471#issuecomment-421048859
Hi @fhueske @aljoscha, could you kindly take a look at this PR? We would
like to make some changes to the "align" window assigner concept. It would be
nice to depreciate current implementation to avoid confusions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate unused BaseAlignedWindowAssigner related components
> -
>
> Key: FLINK-10010
> URL: https://issues.apache.org/jira/browse/FLINK-10010
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
>Reporter: Rong Rong
>Assignee: Rong Rong
>Priority: Major
> Labels: pull-request-available
>
> {{BaseAlignedWindowAssigner}} should be marked as deprecated and
> {{SlidingAlignedProcessingTimeWindows}} should be removed from the Flink Repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10010) Deprecate unused BaseAlignedWindowAssigner related components
[
https://issues.apache.org/jira/browse/FLINK-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566023#comment-16566023
]
ASF GitHub Bot commented on FLINK-10010:
walterddr opened a new pull request #6471: [FLINK-10010][DataStream API]
Deprecate unused BaseAlignedWindowAssigner related components
URL: https://github.com/apache/flink/pull/6471
## What is the purpose of the change
Deprecate unused AlignedWindow related components. the links in comments are
all dead and WindowOperator already decline assigners of such type.
## Brief change log
- Mark Deprecated BaseAlignedWindowAssigner
- Remove SlidingAlignedProcessingTimeWindows
## Verifying this change
N/A
## Does this pull request potentially affect one of the following parts:
N/A
## Documentation
N/A
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate unused BaseAlignedWindowAssigner related components
> -
>
> Key: FLINK-10010
> URL: https://issues.apache.org/jira/browse/FLINK-10010
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
>Reporter: Rong Rong
>Assignee: Rong Rong
>Priority: Major
> Labels: pull-request-available
>
> {{BaseAlignedWindowAssigner}} should be marked as deprecated and
> {{SlidingAlignedProcessingTimeWindows}} should be removed from the Flink Repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10010) Deprecate unused BaseAlignedWindowAssigner related components
[
https://issues.apache.org/jira/browse/FLINK-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566337#comment-16566337
]
ASF GitHub Bot commented on FLINK-10010:
yanghua commented on a change in pull request #6471: [FLINK-10010][DataStream
API] Deprecate unused BaseAlignedWindowAssigner related components
URL: https://github.com/apache/flink/pull/6471#discussion_r207099935
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/BaseAlignedWindowAssigner.java
##
@@ -27,15 +27,13 @@
import java.util.Collection;
/**
- * A base {@link WindowAssigner} used to instantiate one of the deprecated
- * {@link
org.apache.flink.streaming.runtime.operators.windowing.AccumulatingProcessingTimeWindowOperator
- * AccumulatingProcessingTimeWindowOperator} and
- * {@link
org.apache.flink.streaming.runtime.operators.windowing.AggregatingProcessingTimeWindowOperator
- * AggregatingProcessingTimeWindowOperator}.
+ * A base {@link WindowAssigner} used to instantiate one of the deprecated
operators.
*
- * For assigner that extend this one, the user can check the
- * {@link TumblingAlignedProcessingTimeWindows} and the {@link
SlidingAlignedProcessingTimeWindows}.
+ * @deprecated will be removed in a future version. please use other {@link
WindowAssigner}s listed under
+ * * {@link org.apache.flink.streaming.api.windowing.assigners}.
Review comment:
extra '*'
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate unused BaseAlignedWindowAssigner related components
> -
>
> Key: FLINK-10010
> URL: https://issues.apache.org/jira/browse/FLINK-10010
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
>Reporter: Rong Rong
>Assignee: Rong Rong
>Priority: Major
> Labels: pull-request-available
>
> {{BaseAlignedWindowAssigner}} should be marked as deprecated and
> {{SlidingAlignedProcessingTimeWindows}} should be removed from the Flink Repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10010) Deprecate unused BaseAlignedWindowAssigner related components
[
https://issues.apache.org/jira/browse/FLINK-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566338#comment-16566338
]
ASF GitHub Bot commented on FLINK-10010:
yanghua commented on a change in pull request #6471: [FLINK-10010][DataStream
API] Deprecate unused BaseAlignedWindowAssigner related components
URL: https://github.com/apache/flink/pull/6471#discussion_r207100012
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/BaseAlignedWindowAssigner.java
##
@@ -27,15 +27,13 @@
import java.util.Collection;
/**
- * A base {@link WindowAssigner} used to instantiate one of the deprecated
- * {@link
org.apache.flink.streaming.runtime.operators.windowing.AccumulatingProcessingTimeWindowOperator
- * AccumulatingProcessingTimeWindowOperator} and
- * {@link
org.apache.flink.streaming.runtime.operators.windowing.AggregatingProcessingTimeWindowOperator
- * AggregatingProcessingTimeWindowOperator}.
+ * A base {@link WindowAssigner} used to instantiate one of the deprecated
operators.
*
- * For assigner that extend this one, the user can check the
- * {@link TumblingAlignedProcessingTimeWindows} and the {@link
SlidingAlignedProcessingTimeWindows}.
+ * @deprecated will be removed in a future version. please use other {@link
WindowAssigner}s listed under
+ * * {@link org.apache.flink.streaming.api.windowing.assigners}.
* */
Review comment:
replace '* */' to '*/'
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate unused BaseAlignedWindowAssigner related components
> -
>
> Key: FLINK-10010
> URL: https://issues.apache.org/jira/browse/FLINK-10010
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
>Reporter: Rong Rong
>Assignee: Rong Rong
>Priority: Major
> Labels: pull-request-available
>
> {{BaseAlignedWindowAssigner}} should be marked as deprecated and
> {{SlidingAlignedProcessingTimeWindows}} should be removed from the Flink Repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10010) Deprecate unused BaseAlignedWindowAssigner related components
[
https://issues.apache.org/jira/browse/FLINK-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566339#comment-16566339
]
ASF GitHub Bot commented on FLINK-10010:
yanghua commented on a change in pull request #6471: [FLINK-10010][DataStream
API] Deprecate unused BaseAlignedWindowAssigner related components
URL: https://github.com/apache/flink/pull/6471#discussion_r207100160
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/BaseAlignedWindowAssigner.java
##
@@ -27,15 +27,13 @@
import java.util.Collection;
/**
- * A base {@link WindowAssigner} used to instantiate one of the deprecated
- * {@link
org.apache.flink.streaming.runtime.operators.windowing.AccumulatingProcessingTimeWindowOperator
- * AccumulatingProcessingTimeWindowOperator} and
- * {@link
org.apache.flink.streaming.runtime.operators.windowing.AggregatingProcessingTimeWindowOperator
- * AggregatingProcessingTimeWindowOperator}.
+ * A base {@link WindowAssigner} used to instantiate one of the deprecated
operators.
*
- * For assigner that extend this one, the user can check the
- * {@link TumblingAlignedProcessingTimeWindows} and the {@link
SlidingAlignedProcessingTimeWindows}.
+ * @deprecated will be removed in a future version. please use other {@link
WindowAssigner}s listed under
+ * * {@link org.apache.flink.streaming.api.windowing.assigners}.
* */
+
Review comment:
please remove this empty line
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate unused BaseAlignedWindowAssigner related components
> -
>
> Key: FLINK-10010
> URL: https://issues.apache.org/jira/browse/FLINK-10010
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
>Reporter: Rong Rong
>Assignee: Rong Rong
>Priority: Major
> Labels: pull-request-available
>
> {{BaseAlignedWindowAssigner}} should be marked as deprecated and
> {{SlidingAlignedProcessingTimeWindows}} should be removed from the Flink Repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10010) Deprecate unused BaseAlignedWindowAssigner related components
[
https://issues.apache.org/jira/browse/FLINK-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567042#comment-16567042
]
ASF GitHub Bot commented on FLINK-10010:
walterddr commented on issue #6471: [FLINK-10010][DataStream API] Deprecate
unused BaseAlignedWindowAssigner related components
URL: https://github.com/apache/flink/pull/6471#issuecomment-409989144
thx for the review @yanghua . for some reason java checkstyle did not catch
these problems. just fixed it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate unused BaseAlignedWindowAssigner related components
> -
>
> Key: FLINK-10010
> URL: https://issues.apache.org/jira/browse/FLINK-10010
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
>Reporter: Rong Rong
>Assignee: Rong Rong
>Priority: Major
> Labels: pull-request-available
>
> {{BaseAlignedWindowAssigner}} should be marked as deprecated and
> {{SlidingAlignedProcessingTimeWindows}} should be removed from the Flink Repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
