[jira] [Commented] (FLINK-10201) The batchTestUtil was mistakenly used in some stream sql tests

2018-08-24 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592372#comment-16592372
 ] 

ASF GitHub Bot commented on FLINK-10201:


xccui closed pull request #6605: [FLINK-10201] [table] [test] The batchTestUtil 
was mistakenly used in some stream sql tests
URL: https://github.com/apache/flink/pull/6605
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/CorrelateTest.scala
 
b/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/CorrelateTest.scala
index efb83b456ed..f179ae6cfac 100644
--- 
a/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/CorrelateTest.scala
+++ 
b/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/CorrelateTest.scala
@@ -106,7 +106,7 @@ class CorrelateTest extends TableTestBase {
 
   @Test
   def testLeftOuterJoinAsSubQuery(): Unit = {
-val util = batchTestUtil()
+val util = streamTestUtil()
 val func1 = new TableFunc1
 util.addTable[(Int, Long, String)]("MyTable", 'a, 'b, 'c)
 util.addTable[(Int, Long, String)]("MyTable2", 'a2, 'b2, 'c2)
@@ -121,13 +121,13 @@ class CorrelateTest extends TableTestBase {
 | ON c2 = s """.stripMargin
 
 val expected = binaryNode(
-  "DataSetJoin",
-  batchTableNode(1),
+  "DataStreamJoin",
+  streamTableNode(1),
   unaryNode(
-"DataSetCalc",
+"DataStreamCalc",
 unaryNode(
-  "DataSetCorrelate",
-  batchTableNode(0),
+  "DataStreamCorrelate",
+  streamTableNode(0),
   term("invocation", "func1($cor0.c)"),
   term("correlate", "table(func1($cor0.c))"),
   term("select", "a", "b", "c", "f0"),
diff --git 
a/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/SetOperatorsTest.scala
 
b/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/SetOperatorsTest.scala
index 97dbe0dad66..fb4b4b5f409 100644
--- 
a/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/SetOperatorsTest.scala
+++ 
b/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/SetOperatorsTest.scala
@@ -173,29 +173,26 @@ class SetOperatorsTest extends TableTestBase {
 
   @Test
   def testValuesWithCast(): Unit = {
-val util = batchTestUtil()
+val util = streamTestUtil()
 
 val expected = naryNode(
-  "DataSetUnion",
+  "DataStreamUnion",
   List(
-unaryNode("DataSetCalc",
-  values("DataSetValues",
-tuples(List("0")),
-"values=[ZERO]"),
+unaryNode("DataStreamCalc",
+  values("DataStreamValues",
+tuples(List("0"))),
   term("select", "1 AS EXPR$0, 1 AS EXPR$1")),
-unaryNode("DataSetCalc",
-  values("DataSetValues",
-tuples(List("0")),
-"values=[ZERO]"),
+unaryNode("DataStreamCalc",
+  values("DataStreamValues",
+tuples(List("0"))),
   term("select", "2 AS EXPR$0, 2 AS EXPR$1")),
-unaryNode("DataSetCalc",
-  values("DataSetValues",
-tuples(List("0")),
-"values=[ZERO]"),
+unaryNode("DataStreamCalc",
+  values("DataStreamValues",
+tuples(List("0"))),
   term("select", "3 AS EXPR$0, 3 AS EXPR$1"))
   ),
   term("all", "true"),
-  term("union", "EXPR$0, EXPR$1")
+  term("union all", "EXPR$0, EXPR$1")
 )
 
 util.verifySql(


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The batchTestUtil was mistakenly used in some stream sql tests
> --
>
> Key: FLINK-10201
> URL: https://issues.apache.org/jira/browse/FLINK-10201
> Project: Flink
>  Issue Type: Test
>  Components: Table API  SQL
>Reporter: Xingcan Cui
>Assignee: Xingcan Cui
>Priority: Minor
>  Labels: pull-request-available
>
> The {{batchTestUtil}} was mistakenly used in stream sql tests 
> {{SetOperatorsTest.testValuesWithCast()}} and 
> {{CorrelateTest.testLeftOuterJoinAsSubQuery()}}. That should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10201) The batchTestUtil was mistakenly used in some stream sql tests

2018-08-24 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591328#comment-16591328
 ] 

ASF GitHub Bot commented on FLINK-10201:


xccui commented on issue #6605: [FLINK-10201] [table] [test] The batchTestUtil 
was mistakenly used in some stream sql tests
URL: https://github.com/apache/flink/pull/6605#issuecomment-415692162
 
 
   Thanks for your review, @fhueske. I'll merge this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The batchTestUtil was mistakenly used in some stream sql tests
> --
>
> Key: FLINK-10201
> URL: https://issues.apache.org/jira/browse/FLINK-10201
> Project: Flink
>  Issue Type: Test
>  Components: Table API  SQL
>Reporter: Xingcan Cui
>Assignee: Xingcan Cui
>Priority: Minor
>  Labels: pull-request-available
>
> The {{batchTestUtil}} was mistakenly used in stream sql tests 
> {{SetOperatorsTest.testValuesWithCast()}} and 
> {{CorrelateTest.testLeftOuterJoinAsSubQuery()}}. That should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10201) The batchTestUtil was mistakenly used in some stream sql tests

2018-08-23 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590544#comment-16590544
 ] 

ASF GitHub Bot commented on FLINK-10201:


fhueske commented on issue #6605: [FLINK-10201] [table] [test] The 
batchTestUtil was mistakenly used in some stream sql tests
URL: https://github.com/apache/flink/pull/6605#issuecomment-415496307
 
 
   Thanks for the PR @xccui.
   +1 to merge


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The batchTestUtil was mistakenly used in some stream sql tests
> --
>
> Key: FLINK-10201
> URL: https://issues.apache.org/jira/browse/FLINK-10201
> Project: Flink
>  Issue Type: Test
>  Components: Table API  SQL
>Reporter: Xingcan Cui
>Assignee: Xingcan Cui
>Priority: Minor
>  Labels: pull-request-available
>
> The {{batchTestUtil}} was mistakenly used in stream sql tests 
> {{SetOperatorsTest.testValuesWithCast()}} and 
> {{CorrelateTest.testLeftOuterJoinAsSubQuery()}}. That should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10201) The batchTestUtil was mistakenly used in some stream sql tests

2018-08-22 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589679#comment-16589679
 ] 

ASF GitHub Bot commented on FLINK-10201:


xccui opened a new pull request #6605: [FLINK-10201] [table] [test] The 
batchTestUtil was mistakenly used in some stream sql tests
URL: https://github.com/apache/flink/pull/6605
 
 
   ## What is the purpose of the change
   
   This PR fixes two improper test cases that mistakenly use batchTestUtil for 
stream sql.
   
   ## Brief change log
   
   Replaces the `batchTestUtil` with `streamTestUti`l in 
`SetOperatorsTest.testValuesWithCast()` and 
`CorrelateTest.testLeftOuterJoinAsSubQuery()`.
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
 - If yes, how is the feature documented? (not applicable)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The batchTestUtil was mistakenly used in some stream sql tests
> --
>
> Key: FLINK-10201
> URL: https://issues.apache.org/jira/browse/FLINK-10201
> Project: Flink
>  Issue Type: Test
>  Components: Table API  SQL
>Reporter: Xingcan Cui
>Assignee: Xingcan Cui
>Priority: Minor
>  Labels: pull-request-available
>
> The {{batchTestUtil}} was mistakenly used in stream sql tests 
> {{SetOperatorsTest.testValuesWithCast()}} and 
> {{CorrelateTest.testLeftOuterJoinAsSubQuery()}}. That should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)