[jira] [Commented] (FLINK-10418) Add COTH math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767911#comment-16767911 ] Aleksei Izmalkin commented on FLINK-10418: -- The PR is closed. So I close the JIRA. > Add COTH math function supported in Table API and SQL > - > > Key: FLINK-10418 > URL: https://issues.apache.org/jira/browse/FLINK-10418 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Assignee: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Inspired by FLINK-10398 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10418) Add COTH math function supported in Table API and SQL
[
https://issues.apache.org/jira/browse/FLINK-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629709#comment-16629709
]
ASF GitHub Bot commented on FLINK-10418:
yanghua commented on a change in pull request #6764: [FLINK-10418] [Table API &
SQL] Add COTH math function supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6764#discussion_r220784635
##
File path: docs/dev/table/functions.md
##
@@ -1230,6 +1230,17 @@ COT(numeric)
+
+
+{% highlight text %}
+COTH(numeric)
+{% endhighlight %}
+
+
+Returns the hyperbolic cotangent of a numeric.
Review comment:
please add some information about returned types, refer to @pnowojski 's
review suggestion in #6700
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add COTH math function supported in Table API and SQL
> -
>
> Key: FLINK-10418
> URL: https://issues.apache.org/jira/browse/FLINK-10418
> Project: Flink
> Issue Type: Sub-task
> Components: Table API SQL
>Reporter: Aleksei Izmalkin
>Priority: Minor
> Labels: pull-request-available
>
> Inspired by FLINK-10398
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10418) Add COTH math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628700#comment-16628700 ] Aleksei Izmalkin commented on FLINK-10418: -- Hello [~yanghua], I created a pull request for this issue: [https://github.com/apache/flink/pull/6764] > Add COTH math function supported in Table API and SQL > - > > Key: FLINK-10418 > URL: https://issues.apache.org/jira/browse/FLINK-10418 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > > Inspired by FLINK-10398 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10418) Add COTH math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628688#comment-16628688 ] ASF GitHub Bot commented on FLINK-10418: aai95 opened a new pull request #6764: [FLINK-10418] [Table API & SQL] Add COTH math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6764 ## What is the purpose of the change *This pull request adds `Coth` math function supported in Table API and SQL.* ## Brief change log - *Added `Coth` math function supported in Table API and SQL.* - *Added `ScalarFunctionsTest#testCoth`.* ## Verifying this change *This change added test `ScalarFunctionsTest#testCoth`.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add COTH math function supported in Table API and SQL > - > > Key: FLINK-10418 > URL: https://issues.apache.org/jira/browse/FLINK-10418 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > > Inspired by FLINK-10398 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10418) Add COTH math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627271#comment-16627271 ] vinoyang commented on FLINK-10418: -- [~Aleksei_Izmalkin] I did it. > Add COTH math function supported in Table API and SQL > - > > Key: FLINK-10418 > URL: https://issues.apache.org/jira/browse/FLINK-10418 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Priority: Minor > > Inspired by FLINK-10398 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10418) Add COTH math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627224#comment-16627224 ] vinoyang commented on FLINK-10418: -- Hi [~Aleksei_Izmalkin] thanks for opening this issue, please mark this issue as a sub task of FLINK-6810 > Add COTH math function supported in Table API and SQL > - > > Key: FLINK-10418 > URL: https://issues.apache.org/jira/browse/FLINK-10418 > Project: Flink > Issue Type: Task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Priority: Minor > > Inspired by https://issues.apache.org/jira/browse/FLINK-10398 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
