[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812271#comment-16812271 ] Ji Liu commented on FLINK-10437: [~Tison] I have checked usages of _ConfigOption.withDeparecatedKeys_ and find only the case mentioned above meet the requirements. Could please help review this PR? thanks very much! [PR|[https://github.com/apache/flink/pull/8121]] > Some of keys under withDeprecatedKeys aren't marked as @depreacted > -- > > Key: FLINK-10437 > URL: https://issues.apache.org/jira/browse/FLINK-10437 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Affects Versions: 1.7.0 >Reporter: TisonKun >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > as title. For example {{RestOptions#BIND_ADDRESS}} is > {{withDeprecatedKeys(WebOptions.ADDRESS.key())}}, but {{WebOptions.ADDRESS}} > isn't marked as deprecated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812233#comment-16812233 ] TisonKun commented on FLINK-10437: -- Yes. You might decide whether replace with {{withFallbackKeys}} or mark it as {{@Deprecated}} > Some of keys under withDeprecatedKeys aren't marked as @depreacted > -- > > Key: FLINK-10437 > URL: https://issues.apache.org/jira/browse/FLINK-10437 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Affects Versions: 1.7.0 >Reporter: TisonKun >Priority: Major > > as title. For example {{RestOptions#BIND_ADDRESS}} is > {{withDeprecatedKeys(WebOptions.ADDRESS.key())}}, but {{WebOptions.ADDRESS}} > isn't marked as deprecated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812138#comment-16812138 ] LiuJi commented on FLINK-10437: --- You mean we should check all classes which use _withDeprecatedKeys_,if the key is not marked as deprecated, then it should be replaced with _withFallbackKeys_, right? [~Tison] > Some of keys under withDeprecatedKeys aren't marked as @depreacted > -- > > Key: FLINK-10437 > URL: https://issues.apache.org/jira/browse/FLINK-10437 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Affects Versions: 1.7.0 >Reporter: TisonKun >Priority: Major > > as title. For example {{RestOptions#BIND_ADDRESS}} is > {{withDeprecatedKeys(WebOptions.ADDRESS.key())}}, but {{WebOptions.ADDRESS}} > isn't marked as deprecated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811909#comment-16811909 ] TisonKun commented on FLINK-10437: -- [~tianchen92] it's still our case at least as described above. I think a totally fix of it requiring an investigation(checklist) of such cases. > Some of keys under withDeprecatedKeys aren't marked as @depreacted > -- > > Key: FLINK-10437 > URL: https://issues.apache.org/jira/browse/FLINK-10437 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Affects Versions: 1.7.0 >Reporter: TisonKun >Priority: Major > > as title. For example {{RestOptions#BIND_ADDRESS}} is > {{withDeprecatedKeys(WebOptions.ADDRESS.key())}}, but {{WebOptions.ADDRESS}} > isn't marked as deprecated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811899#comment-16811899 ] LiuJi commented on FLINK-10437: --- Hi [~Tison] Does the problem still exist? if so, I would like to fix this. > Some of keys under withDeprecatedKeys aren't marked as @depreacted > -- > > Key: FLINK-10437 > URL: https://issues.apache.org/jira/browse/FLINK-10437 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Affects Versions: 1.7.0 >Reporter: TisonKun >Priority: Major > > as title. For example {{RestOptions#BIND_ADDRESS}} is > {{withDeprecatedKeys(WebOptions.ADDRESS.key())}}, but {{WebOptions.ADDRESS}} > isn't marked as deprecated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)