[jira] [Commented] (FLINK-10472) Add CBRT math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767910#comment-16767910 ] Aleksei Izmalkin commented on FLINK-10472: -- The PR is closed. So I close the JIRA. > Add CBRT math function supported in Table API and SQL > - > > Key: FLINK-10472 > URL: https://issues.apache.org/jira/browse/FLINK-10472 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Assignee: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Implement the function to calculate the cube root. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10472) Add CBRT math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643105#comment-16643105 ] ASF GitHub Bot commented on FLINK-10472: aai95 commented on issue #6783: [FLINK-10472] [table] Add CBRT math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6783#issuecomment-428144132 @Guibo-Pan thank you for your suggestion. The idea about adding the "Nth root" function sounds good to me. It will be analog of existing `POWER(x, y) = x ^ y`, but can be more useful in SQL like `ROOT(125, 3)` will produce 5, instead of `POWER(125, 1.0 / 3.0)`. More pleasent syntax, I can rename this issue and rewrite implementation based on idea that `root(x, y) = power(x, 1 / y)`. What do you think about it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add CBRT math function supported in Table API and SQL > - > > Key: FLINK-10472 > URL: https://issues.apache.org/jira/browse/FLINK-10472 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Assignee: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > > Implement the function to calculate the cube root. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10472) Add CBRT math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642767#comment-16642767 ] ASF GitHub Bot commented on FLINK-10472: Guibo-Pan commented on issue #6783: [FLINK-10472] [table] Add CBRT math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6783#issuecomment-428051714 @aai95 From my side, I wonder if we are going on to add "the fourth root", "the fifth root" and so on, or add a standard "the nth root" function. In that case, I think consistency should take into consideration. It's just an opinion, feel free to remain this or discuss more if you think not. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add CBRT math function supported in Table API and SQL > - > > Key: FLINK-10472 > URL: https://issues.apache.org/jira/browse/FLINK-10472 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Assignee: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > > Implement the function to calculate the cube root. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10472) Add CBRT math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641813#comment-16641813 ] ASF GitHub Bot commented on FLINK-10472: aai95 commented on issue #6783: [FLINK-10472] [table] Add CBRT math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6783#issuecomment-427824001 Hello @Guibo-Pan, do you mean that it will be better to use `power(numeric, 1.0 / 3.0)` instead of `java.lang.Math.cbrt()`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add CBRT math function supported in Table API and SQL > - > > Key: FLINK-10472 > URL: https://issues.apache.org/jira/browse/FLINK-10472 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Assignee: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > > Implement the function to calculate the cube root. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10472) Add CBRT math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641799#comment-16641799 ] ASF GitHub Bot commented on FLINK-10472: Guibo-Pan commented on issue #6783: [FLINK-10472] [table] Add CBRT math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6783#issuecomment-427819481 Hi, @aai95 thanks for your PR. We already have a previous `sqrt(numeric)`, which is actually `power(numeric, 0.5)`. I think it's better to align to the previous one. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add CBRT math function supported in Table API and SQL > - > > Key: FLINK-10472 > URL: https://issues.apache.org/jira/browse/FLINK-10472 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Assignee: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > > Implement the function to calculate the cube root. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10472) Add CBRT math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635107#comment-16635107 ] ASF GitHub Bot commented on FLINK-10472: aai95 opened a new pull request #6783: [FLINK-10472] [table] Add CBRT math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6783 ## What is the purpose of the change *This pull request adds `Cbrt` math function supported in Table API and SQL.* ## Brief change log - *Added `Cbrt` math function supported in Table API and SQL.* - *Added `ScalarFunctionsTest#testCbrt`.* ## Verifying this change *This change added test `ScalarFunctionsTest#testCbrt`.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (**yes** / no) - If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add CBRT math function supported in Table API and SQL > - > > Key: FLINK-10472 > URL: https://issues.apache.org/jira/browse/FLINK-10472 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > > Implement the function to calculate the cube root. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10472) Add CBRT math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634160#comment-16634160 ] vinoyang commented on FLINK-10472: -- [~Aleksei_Izmalkin] Done. Ping [~twalthr] or [~till.rohrmann] , please give him JIRA permission. Thanks. > Add CBRT math function supported in Table API and SQL > - > > Key: FLINK-10472 > URL: https://issues.apache.org/jira/browse/FLINK-10472 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > > Implement the function to calculate the cube root. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10472) Add CBRT math function supported in Table API and SQL
[ https://issues.apache.org/jira/browse/FLINK-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633930#comment-16633930 ] Aleksei Izmalkin commented on FLINK-10472: -- I will work on this issue. Hello [~yanghua], please mark this issue as a sub-task of FLINK-6810. I can't select this type from the drop-down list (maybe there are no permissions). > Add CBRT math function supported in Table API and SQL > - > > Key: FLINK-10472 > URL: https://issues.apache.org/jira/browse/FLINK-10472 > Project: Flink > Issue Type: Task > Components: Table API SQL >Reporter: Aleksei Izmalkin >Priority: Minor > Labels: pull-request-available > > Implement the function to calculate the cube root. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
