[jira] [Commented] (FLINK-10520) Job save points REST API fails unless parameters are specified
[
https://issues.apache.org/jira/browse/FLINK-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279413#comment-17279413
]
Matthias commented on FLINK-10520:
--
That's reasonable. I agree (y)
> Job save points REST API fails unless parameters are specified
> --
>
> Key: FLINK-10520
> URL: https://issues.apache.org/jira/browse/FLINK-10520
> Project: Flink
> Issue Type: Bug
> Components: Runtime / REST
>Affects Versions: 1.6.1
>Reporter: Elias Levy
>Assignee: Chesnay Schepler
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.13.0
>
>
> The new REST API POST endpoint, {{/jobs/:jobid/savepoints}}, returns an error
> unless the request includes a body with all parameters ({{target-directory}}
> and {{cancel-job}})), even thought the
> [documentation|https://ci.apache.org/projects/flink/flink-docs-master/api/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.html]
> suggests these are optional.
> If a POST request with no data is made, the response is a 400 status code
> with the error message "Bad request received."
> If the POST request submits an empty JSON object ( {} ), the response is a
> 400 status code with the error message "Request did not match expected format
> SavepointTriggerRequestBody." The same is true if only the
> {{target-directory}} or {{cancel-job}} parameters are included.
> As the system is configured with a default savepoint location, there
> shouldn't be a need to include the parameter in the quest.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-10520) Job save points REST API fails unless parameters are specified
[
https://issues.apache.org/jira/browse/FLINK-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278761#comment-17278761
]
Chesnay Schepler commented on FLINK-10520:
--
Any existing user should have already dealt with it so I'm not sure whether it
adds a lot of value.
> Job save points REST API fails unless parameters are specified
> --
>
> Key: FLINK-10520
> URL: https://issues.apache.org/jira/browse/FLINK-10520
> Project: Flink
> Issue Type: Bug
> Components: Runtime / REST
>Affects Versions: 1.6.1
>Reporter: Elias Levy
>Assignee: Chesnay Schepler
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.13.0
>
>
> The new REST API POST endpoint, {{/jobs/:jobid/savepoints}}, returns an error
> unless the request includes a body with all parameters ({{target-directory}}
> and {{cancel-job}})), even thought the
> [documentation|https://ci.apache.org/projects/flink/flink-docs-master/api/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.html]
> suggests these are optional.
> If a POST request with no data is made, the response is a 400 status code
> with the error message "Bad request received."
> If the POST request submits an empty JSON object ( {} ), the response is a
> 400 status code with the error message "Request did not match expected format
> SavepointTriggerRequestBody." The same is true if only the
> {{target-directory}} or {{cancel-job}} parameters are included.
> As the system is configured with a default savepoint location, there
> shouldn't be a need to include the parameter in the quest.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-10520) Job save points REST API fails unless parameters are specified
[
https://issues.apache.org/jira/browse/FLINK-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278640#comment-17278640
]
Matthias commented on FLINK-10520:
--
[~chesnay] Shouldn't we also backport the fix to {{1.12.2}} and {{1.11.4}}?
What do you think?
> Job save points REST API fails unless parameters are specified
> --
>
> Key: FLINK-10520
> URL: https://issues.apache.org/jira/browse/FLINK-10520
> Project: Flink
> Issue Type: Bug
> Components: Runtime / REST
>Affects Versions: 1.6.1
>Reporter: Elias Levy
>Assignee: Chesnay Schepler
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.13.0
>
>
> The new REST API POST endpoint, {{/jobs/:jobid/savepoints}}, returns an error
> unless the request includes a body with all parameters ({{target-directory}}
> and {{cancel-job}})), even thought the
> [documentation|https://ci.apache.org/projects/flink/flink-docs-master/api/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.html]
> suggests these are optional.
> If a POST request with no data is made, the response is a 400 status code
> with the error message "Bad request received."
> If the POST request submits an empty JSON object ( {} ), the response is a
> 400 status code with the error message "Request did not match expected format
> SavepointTriggerRequestBody." The same is true if only the
> {{target-directory}} or {{cancel-job}} parameters are included.
> As the system is configured with a default savepoint location, there
> shouldn't be a need to include the parameter in the quest.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-10520) Job save points REST API fails unless parameters are specified
[
https://issues.apache.org/jira/browse/FLINK-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839292#comment-16839292
]
Gary Yao commented on FLINK-10520:
--
There is no one working on it at the moment. If you have time, you can take it,
[~vicTTim]
> Job save points REST API fails unless parameters are specified
> --
>
> Key: FLINK-10520
> URL: https://issues.apache.org/jira/browse/FLINK-10520
> Project: Flink
> Issue Type: Bug
> Components: Runtime / REST
>Affects Versions: 1.6.1
>Reporter: Elias Levy
>Priority: Minor
>
> The new REST API POST endpoint, {{/jobs/:jobid/savepoints}}, returns an error
> unless the request includes a body with all parameters ({{target-directory}}
> and {{cancel-job}})), even thought the
> [documentation|https://ci.apache.org/projects/flink/flink-docs-master/api/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.html]
> suggests these are optional.
> If a POST request with no data is made, the response is a 400 status code
> with the error message "Bad request received."
> If the POST request submits an empty JSON object ( {} ), the response is a
> 400 status code with the error message "Request did not match expected format
> SavepointTriggerRequestBody." The same is true if only the
> {{target-directory}} or {{cancel-job}} parameters are included.
> As the system is configured with a default savepoint location, there
> shouldn't be a need to include the parameter in the quest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10520) Job save points REST API fails unless parameters are specified
[
https://issues.apache.org/jira/browse/FLINK-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837525#comment-16837525
]
Tim commented on FLINK-10520:
-
Is there any update on this issue?
> Job save points REST API fails unless parameters are specified
> --
>
> Key: FLINK-10520
> URL: https://issues.apache.org/jira/browse/FLINK-10520
> Project: Flink
> Issue Type: Bug
> Components: Runtime / REST
>Affects Versions: 1.6.1
>Reporter: Elias Levy
>Assignee: Chesnay Schepler
>Priority: Minor
>
> The new REST API POST endpoint, {{/jobs/:jobid/savepoints}}, returns an error
> unless the request includes a body with all parameters ({{target-directory}}
> and {{cancel-job}})), even thought the
> [documentation|https://ci.apache.org/projects/flink/flink-docs-master/api/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.html]
> suggests these are optional.
> If a POST request with no data is made, the response is a 400 status code
> with the error message "Bad request received."
> If the POST request submits an empty JSON object ( {} ), the response is a
> 400 status code with the error message "Request did not match expected format
> SavepointTriggerRequestBody." The same is true if only the
> {{target-directory}} or {{cancel-job}} parameters are included.
> As the system is configured with a default savepoint location, there
> shouldn't be a need to include the parameter in the quest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10520) Job save points REST API fails unless parameters are specified
[
https://issues.apache.org/jira/browse/FLINK-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675404#comment-16675404
]
Elias Levy commented on FLINK-10520:
[~huide] as I said " the system is configured with a default savepoint
location". As for {{cancel-job}}, the JSON schema documentation does not mark
the key as mandatory.
> Job save points REST API fails unless parameters are specified
> --
>
> Key: FLINK-10520
> URL: https://issues.apache.org/jira/browse/FLINK-10520
> Project: Flink
> Issue Type: Bug
> Components: REST
>Affects Versions: 1.6.1
>Reporter: Elias Levy
>Assignee: Chesnay Schepler
>Priority: Minor
>
> The new REST API POST endpoint, {{/jobs/:jobid/savepoints}}, returns an error
> unless the request includes a body with all parameters ({{target-directory}}
> and {{cancel-job}})), even thought the
> [documentation|https://ci.apache.org/projects/flink/flink-docs-master/api/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.html]
> suggests these are optional.
> If a POST request with no data is made, the response is a 400 status code
> with the error message "Bad request received."
> If the POST request submits an empty JSON object ( {} ), the response is a
> 400 status code with the error message "Request did not match expected format
> SavepointTriggerRequestBody." The same is true if only the
> {{target-directory}} or {{cancel-job}} parameters are included.
> As the system is configured with a default savepoint location, there
> shouldn't be a need to include the parameter in the quest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10520) Job save points REST API fails unless parameters are specified
[
https://issues.apache.org/jira/browse/FLINK-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673505#comment-16673505
]
Huide Yin commented on FLINK-10520:
---
I wonder if `state.savepoints.dir:` specified as the default savpoint path in
your flink-conf.yaml file?
`target-directory` is must have for specify the target location for saving
savepoint
`cancel-job` is must since there's no separate `cacnel` request defined here:
https://ci.apache.org/projects/flink/flink-docs-stable/monitoring/rest_api.html
> Job save points REST API fails unless parameters are specified
> --
>
> Key: FLINK-10520
> URL: https://issues.apache.org/jira/browse/FLINK-10520
> Project: Flink
> Issue Type: Bug
> Components: REST
>Affects Versions: 1.6.1
>Reporter: Elias Levy
>Assignee: Chesnay Schepler
>Priority: Minor
>
> The new REST API POST endpoint, {{/jobs/:jobid/savepoints}}, returns an error
> unless the request includes a body with all parameters ({{target-directory}}
> and {{cancel-job}})), even thought the
> [documentation|https://ci.apache.org/projects/flink/flink-docs-master/api/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.html]
> suggests these are optional.
> If a POST request with no data is made, the response is a 400 status code
> with the error message "Bad request received."
> If the POST request submits an empty JSON object ( {} ), the response is a
> 400 status code with the error message "Request did not match expected format
> SavepointTriggerRequestBody." The same is true if only the
> {{target-directory}} or {{cancel-job}} parameters are included.
> As the system is configured with a default savepoint location, there
> shouldn't be a need to include the parameter in the quest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
