[jira] [Commented] (FLINK-10530) ProcessFailureCancelingITCase.testCancelingOnProcessFailure failed on Travis.

2018-10-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649932#comment-16649932
 ] 

ASF GitHub Bot commented on FLINK-10530:


tillrohrmann closed pull request #6827: [FLINK-10530][tests] Harden 
ProcessFailureCancelingITCase and AbstractTaskManagerProcessFailureRecovery
URL: https://github.com/apache/flink/pull/6827
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
 
b/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
index 5d7f26bb886..83298aa78ec 100644
--- 
a/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
+++ 
b/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
@@ -18,18 +18,19 @@
 
 package org.apache.flink.test.recovery;
 
+import org.apache.flink.api.java.utils.ParameterTool;
 import org.apache.flink.configuration.AkkaOptions;
 import org.apache.flink.configuration.Configuration;
 import org.apache.flink.configuration.HeartbeatManagerOptions;
+import org.apache.flink.configuration.HighAvailabilityOptions;
 import org.apache.flink.configuration.JobManagerOptions;
-import org.apache.flink.configuration.RestOptions;
 import org.apache.flink.configuration.TaskManagerOptions;
 import org.apache.flink.runtime.clusterframework.types.ResourceID;
 import org.apache.flink.runtime.entrypoint.StandaloneSessionClusterEntrypoint;
 import org.apache.flink.runtime.taskexecutor.TaskManagerRunner;
 import org.apache.flink.runtime.testutils.CommonTestUtils;
 import org.apache.flink.runtime.util.BlobServerResource;
-import org.apache.flink.util.NetUtils;
+import org.apache.flink.runtime.zookeeper.ZooKeeperResource;
 import org.apache.flink.util.TestLogger;
 
 import org.junit.Rule;
@@ -42,6 +43,8 @@
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.StringWriter;
+import java.util.ArrayList;
+import java.util.Map;
 import java.util.concurrent.atomic.AtomicReference;
 
 import static 
org.apache.flink.runtime.testutils.CommonTestUtils.getCurrentClasspath;
@@ -76,6 +79,9 @@
@Rule
public final BlobServerResource blobServerResource = new 
BlobServerResource();
 
+   @Rule
+   public final ZooKeeperResource zooKeeperResource = new 
ZooKeeperResource();
+
@Test
public void testTaskManagerProcessFailure() throws Exception {
 
@@ -89,18 +95,19 @@ public void testTaskManagerProcessFailure() throws 
Exception {
 
File coordinateTempDir = null;
 
-   final int jobManagerPort = NetUtils.getAvailablePort();
-   final int restPort = NetUtils.getAvailablePort();
-
-   Configuration jmConfig = new Configuration();
-   jmConfig.setString(AkkaOptions.ASK_TIMEOUT, "100 s");
-   jmConfig.setString(JobManagerOptions.ADDRESS, "localhost");
-   jmConfig.setInteger(JobManagerOptions.PORT, jobManagerPort);
-   jmConfig.setLong(HeartbeatManagerOptions.HEARTBEAT_INTERVAL, 
500L);
-   jmConfig.setLong(HeartbeatManagerOptions.HEARTBEAT_TIMEOUT, 
1L);
-   jmConfig.setInteger(RestOptions.PORT, restPort);
-
-   try (final StandaloneSessionClusterEntrypoint clusterEntrypoint 
= new StandaloneSessionClusterEntrypoint(jmConfig)) {
+   Configuration config = new Configuration();
+   config.setString(AkkaOptions.ASK_TIMEOUT, "100 s");
+   config.setString(JobManagerOptions.ADDRESS, "localhost");
+   config.setLong(HeartbeatManagerOptions.HEARTBEAT_INTERVAL, 
500L);
+   config.setLong(HeartbeatManagerOptions.HEARTBEAT_TIMEOUT, 
1L);
+   config.setString(HighAvailabilityOptions.HA_MODE, "zookeeper");
+   config.setString(HighAvailabilityOptions.HA_ZOOKEEPER_QUORUM, 
zooKeeperResource.getConnectString());
+   config.setString(HighAvailabilityOptions.HA_STORAGE_PATH, 
temporaryFolder.newFolder().getAbsolutePath());
+   config.setInteger(TaskManagerOptions.NUM_TASK_SLOTS, 2);
+   config.setString(TaskManagerOptions.MANAGED_MEMORY_SIZE, "4m");
+   config.setInteger(TaskManagerOptions.NETWORK_NUM_BUFFERS, 100);
+
+   try (final StandaloneSessionClusterEntrypoint clusterEntrypoint 
= new StandaloneSessionClusterEntrypoint(config)) {
// check that we run this test only if the java command
// is available on this machine
  

[jira] [Commented] (FLINK-10530) ProcessFailureCancelingITCase.testCancelingOnProcessFailure failed on Travis.

2018-10-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646536#comment-16646536
 ] 

ASF GitHub Bot commented on FLINK-10530:


tillrohrmann opened a new pull request #6827: [FLINK-10530][tests] Harden 
ProcessFailureCancelingITCase and AbstractTaskManagerProcessFailureRecovery
URL: https://github.com/apache/flink/pull/6827
 
 
   ## What is the purpose of the change
   
   
   The problem is that the Dispatcher actor is being started before it gains 
leadership. When using the
   standalone high availability services, then we don't wait until the 
Dispatcher has confirmed its
   leader session id. We only wait until the actor has become available. Due to 
that it can happen that
   we try to send a RPC message to the Dispatcher before it has actually set 
its leader session id.
   
   This commit adds a helper function which waits until the Dispatcher has 
become available and has set
   its leader session id. The proper way to handle this situation would be to 
move the leader ship grant
   and revokal out of the Dispatcher into a DispatcherRunner which creates a 
Dispatcher actor once it
   gained leadership.
   
   ## Verifying this change
   
   - Covered by the hardened tests
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
 - If yes, how is the feature documented? (not applicable)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ProcessFailureCancelingITCase.testCancelingOnProcessFailure failed on Travis.
> -
>
> Key: FLINK-10530
> URL: https://issues.apache.org/jira/browse/FLINK-10530
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.7.0
>Reporter: Kostas Kloudas
>Assignee: Till Rohrmann
>Priority: Critical
>  Labels: pull-request-available, test-stability
> Fix For: 1.7.0
>
>
> The logs from Travis: https://api.travis-ci.org/v3/job/440109944/log.txt



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)