[jira] [Commented] (FLINK-10552) Provide RichAsyncFunction for scala API
[
https://issues.apache.org/jira/browse/FLINK-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696751#comment-16696751
]
ASF GitHub Bot commented on FLINK-10552:
Clark closed pull request #6878: [FLINK-10552][DataStream API]Add supports
for RichAsyncFunction in Scala API
URL: https://github.com/apache/flink/pull/6878
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/RichAsyncFunction.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/RichAsyncFunction.java
index 8d9ac8fa185..c4051516b51 100644
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/RichAsyncFunction.java
+++
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/RichAsyncFunction.java
@@ -97,10 +97,10 @@ public void setRuntimeContext(RuntimeContext
runtimeContext) {
* context only supports basic operations which are thread safe.
Consequently, state access,
* accumulators, broadcast variables and the distributed cache are
disabled.
*/
- private static class RichAsyncFunctionRuntimeContext implements
RuntimeContext {
+ public static class RichAsyncFunctionRuntimeContext implements
RuntimeContext {
private final RuntimeContext runtimeContext;
- RichAsyncFunctionRuntimeContext(RuntimeContext context) {
+ public RichAsyncFunctionRuntimeContext(RuntimeContext context) {
runtimeContext = Preconditions.checkNotNull(context);
}
@@ -239,11 +239,16 @@ public boolean hasBroadcastVariable(String name) {
}
}
- private static class RichAsyncFunctionIterationRuntimeContext extends
RichAsyncFunctionRuntimeContext implements IterationRuntimeContext {
+ /**
+* A wrapper class for async function's {@link
IterationRuntimeContext}. The async function runtime
+* context only supports basic operations which are thread safe.
Consequently, state access,
+* accumulators, broadcast variables, the distributed cache and
iteration aggregator are disabled.
+*/
+ public static class RichAsyncFunctionIterationRuntimeContext extends
RichAsyncFunctionRuntimeContext implements IterationRuntimeContext {
private final IterationRuntimeContext iterationRuntimeContext;
-
RichAsyncFunctionIterationRuntimeContext(IterationRuntimeContext
iterationRuntimeContext) {
+ public
RichAsyncFunctionIterationRuntimeContext(IterationRuntimeContext
iterationRuntimeContext) {
super(iterationRuntimeContext);
this.iterationRuntimeContext =
Preconditions.checkNotNull(iterationRuntimeContext);
diff --git
a/flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/async/RichAsyncFunction.scala
b/flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/async/RichAsyncFunction.scala
new file mode 100644
index 000..6d88eef7643
--- /dev/null
+++
b/flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/async/RichAsyncFunction.scala
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.scala.async
+
+import org.apache.flink.api.common.functions.{AbstractRichFunction,
IterationRuntimeContext, RuntimeContext}
+import
org.apache.flink.streaming.api.functions.async.RichAsyncFunction.{RichAsyncFunctionIterationRuntimeContext,
RichAsyncFunctionRuntimeContext}
+import org.apache.flink.util.Preconditions
+
+/**
+ * Rich variant of the [[AsyncFunction]].
+ * As a [[org.apache.flink.api.common.functions.RichFunction]], it gives
access to
+ * the [[RuntimeContext]] and provides setup and teardown methods.
+
[jira] [Commented] (FLINK-10552) Provide RichAsyncFunction for scala API
[ https://issues.apache.org/jira/browse/FLINK-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688990#comment-16688990 ] ASF GitHub Bot commented on FLINK-10552: Clark commented on issue #6878: [FLINK-10552][DataStream API]Add supports for RichAsyncFunction in Scala API URL: https://github.com/apache/flink/pull/6878#issuecomment-439272911 Hi @dawidwys , seems like the assignee is not working on this anymore. Is it cool if I take this over? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide RichAsyncFunction for scala API > --- > > Key: FLINK-10552 > URL: https://issues.apache.org/jira/browse/FLINK-10552 > Project: Flink > Issue Type: Improvement > Components: DataStream API >Reporter: Shimin Yang >Assignee: Shimin Yang >Priority: Major > > Currently, only Java API provide a RichAsyncFunction abstract class while > scala dose not. Thought it would be nice to provide the same function for > scala api. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10552) Provide RichAsyncFunction for scala API
[ https://issues.apache.org/jira/browse/FLINK-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688151#comment-16688151 ] ASF GitHub Bot commented on FLINK-10552: dawidwys commented on issue #6878: [FLINK-10552][DataStream API]Add supports for RichAsyncFunction in Scala API URL: https://github.com/apache/flink/pull/6878#issuecomment-439059970 Hi @Clark thanks for your contribution, I think there is some ongoing effort in https://issues.apache.org/jira/browse/FLINK-6756 to solve it, that I think is a bit closer to the desired design. Could you coordinate your efforts in the jira? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide RichAsyncFunction for scala API > --- > > Key: FLINK-10552 > URL: https://issues.apache.org/jira/browse/FLINK-10552 > Project: Flink > Issue Type: Improvement > Components: DataStream API >Reporter: Shimin Yang >Assignee: Shimin Yang >Priority: Major > > Currently, only Java API provide a RichAsyncFunction abstract class while > scala dose not. Thought it would be nice to provide the same function for > scala api. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10552) Provide RichAsyncFunction for scala API
[ https://issues.apache.org/jira/browse/FLINK-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672865#comment-16672865 ] ASF GitHub Bot commented on FLINK-10552: tillrohrmann commented on issue #6878: [FLINK-10552][DataStream API]Add supports for RichAsyncFunction in Scala API URL: https://github.com/apache/flink/pull/6878#issuecomment-435332579 Thanks for opening this PR @Clark. We are currently in the release testing phase. Thus, I will need a bit more time for the review. Thanks for your patience! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide RichAsyncFunction for scala API > --- > > Key: FLINK-10552 > URL: https://issues.apache.org/jira/browse/FLINK-10552 > Project: Flink > Issue Type: Improvement > Components: DataStream API >Reporter: Shimin Yang >Assignee: Shimin Yang >Priority: Major > > Currently, only Java API provide a RichAsyncFunction abstract class while > scala dose not. Thought it would be nice to provide the same function for > scala api. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10552) Provide RichAsyncFunction for scala API
[ https://issues.apache.org/jira/browse/FLINK-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664830#comment-16664830 ] ASF GitHub Bot commented on FLINK-10552: Clark commented on issue #6878: [FLINK-10552][DataStream API]Add supports for RichAsyncFunction in Scala API URL: https://github.com/apache/flink/pull/6878#issuecomment-433321698 cc @tillrohrmann This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide RichAsyncFunction for scala API > --- > > Key: FLINK-10552 > URL: https://issues.apache.org/jira/browse/FLINK-10552 > Project: Flink > Issue Type: Improvement > Components: DataStream API >Reporter: Shimin Yang >Assignee: Shimin Yang >Priority: Major > > Currently, only Java API provide a RichAsyncFunction abstract class while > scala dose not. Thought it would be nice to provide the same function for > scala api. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10552) Provide RichAsyncFunction for scala API
[ https://issues.apache.org/jira/browse/FLINK-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656315#comment-16656315 ] ASF GitHub Bot commented on FLINK-10552: Clark opened a new pull request #6878: [FLINK-10552][DataStream API]Add supports for RichAsyncFunction in Scala API URL: https://github.com/apache/flink/pull/6878 ## What is the purpose of the change Support RichAsyncFunction in Scala API ## Brief change log - Change Async related RuntimeContext to public - Add RichAsyncFunction of Scala version ## Verifying this change The runtime context has been tested in RichAsyncFunctionTest. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide RichAsyncFunction for scala API > --- > > Key: FLINK-10552 > URL: https://issues.apache.org/jira/browse/FLINK-10552 > Project: Flink > Issue Type: Improvement > Components: DataStream API >Reporter: Shimin Yang >Assignee: Shimin Yang >Priority: Major > > Currently, only Java API provide a RichAsyncFunction abstract class while > scala dose not. Thought it would be nice to provide the same function for > scala api. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
