[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712503#comment-16712503 ] ASF GitHub Bot commented on FLINK-10665: TisonKun commented on issue #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917#issuecomment-445164746 ping @tillrohrmann as a reminder This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702683#comment-16702683 ] ASF GitHub Bot commented on FLINK-10665: TisonKun commented on issue #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917#issuecomment-442696454 @zentol I have resolved travis issue. Could you review this when you're free? There are little changes though. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702682#comment-16702682 ] ASF GitHub Bot commented on FLINK-10665: TisonKun removed a comment on issue #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917#issuecomment-433074450 @zentol I fix the checkstyle issue. Can you review this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702680#comment-16702680 ] ASF GitHub Bot commented on FLINK-10665: TisonKun removed a comment on issue #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917#issuecomment-440876707 cc @GJL @StefanRRichter This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695444#comment-16695444 ] ASF GitHub Bot commented on FLINK-10665: TisonKun commented on issue #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917#issuecomment-440876707 cc @GJL @StefanRRichter This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663816#comment-16663816 ] ASF GitHub Bot commented on FLINK-10665: TisonKun commented on issue #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917#issuecomment-433074450 @zentol I fix the checkstyle issue. Can you review this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663546#comment-16663546 ] ASF GitHub Bot commented on FLINK-10665: TisonKun commented on issue #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917#issuecomment-432995984 @zentol thanks and sorry I should have paid more attention This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663348#comment-16663348 ] ASF GitHub Bot commented on FLINK-10665: zentol commented on issue #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917#issuecomment-432937536 ``` 20:26:56.337 [INFO] --- maven-checkstyle-plugin:2.17:check (validate) @ flink-yarn-tests_2.11 --- 20:26:56.533 [INFO] There is 1 error reported by Checkstyle 8.9 with /tools/maven/checkstyle.xml ruleset. 20:26:56.534 [ERROR] src/test/java/org/apache/flink/yarn/YARNITCase.java:[31,8] (imports) UnusedImports: Unused import: org.apache.flink.streaming.api.functions.source.ParallelSourceFunction. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662439#comment-16662439 ] ASF GitHub Bot commented on FLINK-10665: TisonKun commented on issue #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917#issuecomment-432711697 @zentol thanks for the review, add a hotfix :-) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662430#comment-16662430 ] ASF GitHub Bot commented on FLINK-10665: zentol commented on issue #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917#issuecomment-432709017 ``` 14:45:49.851 [INFO] There are 3 errors reported by Checkstyle 8.9 with /tools/maven/checkstyle.xml ruleset. 14:45:49.852 [ERROR] src/test/java/org/apache/flink/yarn/YARNITCase.java:[127] (javadoc) JavadocType: Missing a Javadoc comment. 14:45:49.852 [ERROR] src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java:[38] (imports) ImportOrder: Import org.apache.flink.yarn.util.YarnTestUtils appears after other imports that it should precede 14:45:49.852 [ERROR] src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java:[39] (imports) ImportOrder: 'org.apache.hadoop.fs.Path' should be separated from previous imports. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-10665) Port YARNSessionFIFOITCase#testJavaAPI to new codebase
[ https://issues.apache.org/jira/browse/FLINK-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662161#comment-16662161 ] ASF GitHub Bot commented on FLINK-10665: TisonKun opened a new pull request #6917: [FLINK-10665] [tests] Port YARNSessionFIFOITCase#testJavaAPI to new c… URL: https://github.com/apache/flink/pull/6917 …odebase ## What is the purpose of the change Port `YARNSessionFIFOITCase#testJavaAPI` to new codebase. Mainly to get rid of dependence of `LegacyYarnClusterDescriptor` ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (**no**) - The public API, i.e., is any changed class annotated with `(Evolving)`: (**no**) - The serializers: (**no**) - The runtime per-record code paths (performance sensitive): (**no**) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**) - The S3 file system connector: (**no**) ## Documentation - Does this pull request introduce a new feature? (**no**) - If yes, how is the feature documented? (**not applicable**) cc @tillrohrmann This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Port YARNSessionFIFOITCase#testJavaAPI to new codebase > -- > > Key: FLINK-10665 > URL: https://issues.apache.org/jira/browse/FLINK-10665 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.7.0 >Reporter: TisonKun >Assignee: TisonKun >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > Port {{YARNSessionFIFOITCase#testJavaAPI}} to new codebase -- This message was sent by Atlassian JIRA (v7.6.3#76005)