[jira] [Commented] (FLINK-11042) testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is an invalid test
[
https://issues.apache.org/jira/browse/FLINK-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755198#comment-16755198
]
Piotr Nowojski commented on FLINK-11042:
I was waiting for someone to review my PR that drops this test. I asked
[~tzulitai] but if you can do it, you could do it as well :)
> testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is an invalid
> test
> ---
>
> Key: FLINK-11042
> URL: https://issues.apache.org/jira/browse/FLINK-11042
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
>Affects Versions: 1.8.0
>Reporter: Piotr Nowojski
>Assignee: Piotr Nowojski
>Priority: Major
> Labels: pull-request-available
>
> main point of testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is
> to fail transaction coordinator (by using
> {{kafkaProducer.getTransactionCoordinatorId();}} ) and we expect that this
> will cause failure of Flink job. However that's not always the case. Maybe
> because transaction coordinator can be re-elected before {{KafkaProducer}}
> even notices it or for whatever the reason, sometimes the failure is not
> happening.
> Because of a bug in the test, if failure hasn't happened, the test will not
> fail.
> Generally speaking this test is invalid and should be dropped.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11042) testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is an invalid test
[
https://issues.apache.org/jira/browse/FLINK-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753779#comment-16753779
]
Dawid Wysakowicz commented on FLINK-11042:
--
What is the plan for this ticket? I've just seen it fail again:
https://api.travis-ci.org/v3/job/483337434/log.txt
> testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is an invalid
> test
> ---
>
> Key: FLINK-11042
> URL: https://issues.apache.org/jira/browse/FLINK-11042
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
>Affects Versions: 1.8.0
>Reporter: Piotr Nowojski
>Assignee: Piotr Nowojski
>Priority: Major
> Labels: pull-request-available
>
> main point of testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is
> to fail transaction coordinator (by using
> {{kafkaProducer.getTransactionCoordinatorId();}} ) and we expect that this
> will cause failure of Flink job. However that's not always the case. Maybe
> because transaction coordinator can be re-elected before {{KafkaProducer}}
> even notices it or for whatever the reason, sometimes the failure is not
> happening.
> Because of a bug in the test, if failure hasn't happened, the test will not
> fail.
> Generally speaking this test is invalid and should be dropped.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11042) testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is an invalid test
[
https://issues.apache.org/jira/browse/FLINK-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704831#comment-16704831
]
ASF GitHub Bot commented on FLINK-11042:
pnowojski opened a new pull request #7206: [FLINK-11042][kafka,tests] Drop
invalid kafka producer tests
URL: https://github.com/apache/flink/pull/7206
Main point of testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify
is to fail transaction coordinator (by using
kafkaProducer.getTransactionCoordinatorId(); ) and we expect that this will
cause failure of Flink job. However that's not always the case. Maybe because
transaction coordinator can be re-elected before KafkaProducer even notices it
or for whatever the reason, sometimes the failure is not happening.
Because of a bug in the test, if failure hasn't happened, the test will not
fail.
Generally speaking this test is invalid and should be dropped.
## Brief change log
besides dropping the tests there are couple of hotfixes (please check
individual commits for more information).
## Verifying this change
This pr is touching only a test code.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is an invalid
> test
> ---
>
> Key: FLINK-11042
> URL: https://issues.apache.org/jira/browse/FLINK-11042
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
>Affects Versions: 1.8.0
>Reporter: Piotr Nowojski
>Assignee: Piotr Nowojski
>Priority: Major
> Labels: pull-request-available
>
> main point of testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is
> to fail transaction coordinator (by using
> {{kafkaProducer.getTransactionCoordinatorId();}} ) and we expect that this
> will cause failure of Flink job. However that's not always the case. Maybe
> because transaction coordinator can be re-elected before {{KafkaProducer}}
> even notices it or for whatever the reason, sometimes the failure is not
> happening.
> Because of a bug in the test, if failure hasn't happened, the test will not
> fail.
> Generally speaking this test is invalid and should be dropped.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
