[jira] [Commented] (FLINK-11357) Check and port LeaderChangeJobRecoveryTest to new code base if necessary
[
https://issues.apache.org/jira/browse/FLINK-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753796#comment-16753796
]
lining commented on FLINK-11357:
Find same test for
this(org.apache.flink.runtime.jobmanager.JobManagerHARecoveryTest#testJobRecoveryWhenLosingLeadership),
should we delete this test case.
> Check and port LeaderChangeJobRecoveryTest to new code base if necessary
>
>
> Key: FLINK-11357
> URL: https://issues.apache.org/jira/browse/FLINK-11357
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Reporter: Till Rohrmann
>Assignee: lining
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Check and port {{LeaderChangeJobRecoveryTest}} to new code base if necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11357) Check and port LeaderChangeJobRecoveryTest to new code base if necessary
[
https://issues.apache.org/jira/browse/FLINK-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752051#comment-16752051
]
lining commented on FLINK-11357:
[~till.rohrmann] LeaderChangeJobRecoveryTest this is many same with
LeaderChangeStateCleanupTest. I will update it after you push the update for
LeaderChangeJobRecoveryTest.
> Check and port LeaderChangeJobRecoveryTest to new code base if necessary
>
>
> Key: FLINK-11357
> URL: https://issues.apache.org/jira/browse/FLINK-11357
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Reporter: Till Rohrmann
>Assignee: lining
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Check and port {{LeaderChangeJobRecoveryTest}} to new code base if necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11357) Check and port LeaderChangeJobRecoveryTest to new code base if necessary
[
https://issues.apache.org/jira/browse/FLINK-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752011#comment-16752011
]
lining commented on FLINK-11357:
Hi, [~till.rohrmann].
org.apache.flink.runtime.dispatcher.DispatcherHATest#testGrantingRevokingLeadership
has tested if change leadership. Can we just delete this test.
> Check and port LeaderChangeJobRecoveryTest to new code base if necessary
>
>
> Key: FLINK-11357
> URL: https://issues.apache.org/jira/browse/FLINK-11357
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Reporter: Till Rohrmann
>Assignee: lining
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Check and port {{LeaderChangeJobRecoveryTest}} to new code base if necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11357) Check and port LeaderChangeJobRecoveryTest to new code base if necessary
[
https://issues.apache.org/jira/browse/FLINK-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748490#comment-16748490
]
lining commented on FLINK-11357:
Hi [~till.rohrmann]
LeaderChangeJobRecoveryTest and LeaderChangeStateCleanupTest both have
createBlockingJob which method is same. Can we move this to one place?
> Check and port LeaderChangeJobRecoveryTest to new code base if necessary
>
>
> Key: FLINK-11357
> URL: https://issues.apache.org/jira/browse/FLINK-11357
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Reporter: Till Rohrmann
>Assignee: lining
>Priority: Major
>
> Check and port {{LeaderChangeJobRecoveryTest}} to new code base if necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11357) Check and port LeaderChangeJobRecoveryTest to new code base if necessary
[
https://issues.apache.org/jira/browse/FLINK-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747605#comment-16747605
]
lining commented on FLINK-11357:
Thanks [~till.rohrmann].
> Check and port LeaderChangeJobRecoveryTest to new code base if necessary
>
>
> Key: FLINK-11357
> URL: https://issues.apache.org/jira/browse/FLINK-11357
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Reporter: Till Rohrmann
>Assignee: lining
>Priority: Major
>
> Check and port {{LeaderChangeJobRecoveryTest}} to new code base if necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11357) Check and port LeaderChangeJobRecoveryTest to new code base if necessary
[
https://issues.apache.org/jira/browse/FLINK-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746381#comment-16746381
]
Till Rohrmann commented on FLINK-11357:
---
Sure go ahead [~lining].
> Check and port LeaderChangeJobRecoveryTest to new code base if necessary
>
>
> Key: FLINK-11357
> URL: https://issues.apache.org/jira/browse/FLINK-11357
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Reporter: Till Rohrmann
>Priority: Major
>
> Check and port {{LeaderChangeJobRecoveryTest}} to new code base if necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11357) Check and port LeaderChangeJobRecoveryTest to new code base if necessary
[
https://issues.apache.org/jira/browse/FLINK-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744638#comment-16744638
]
lining commented on FLINK-11357:
Hi，[~till.rohrmann] can assign this to me.
> Check and port LeaderChangeJobRecoveryTest to new code base if necessary
>
>
> Key: FLINK-11357
> URL: https://issues.apache.org/jira/browse/FLINK-11357
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Reporter: Till Rohrmann
>Priority: Major
>
> Check and port {{LeaderChangeJobRecoveryTest}} to new code base if necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
