[jira] [Commented] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[
https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833789#comment-16833789
]
Jark Wu commented on FLINK-12348:
-
+1 provide methods for frequently used properties.
Regarding to the naming of properties, I think you raised a good point, this is
what I want to discuss next. I think it's nice to follow descriptor properties,
actually we also use this pattern in Blink properties.
Regarding to the hierarchy of properties, we split the options into following
in Blink:
* {{sql.exec.xxx}} for runtime
* {{sql.optimizer.xxx}} for optimizer
* {{sql.resource.xxx}} for resource, e.g. memory, parallelism, cpu
* {{sql.codegen.xxx}} for codegen
I'm not sure there should be a planner hierarchy. IMO, planner is a little
broad for users, it seems that it includes optimizer, codegen, resource, etc..
Maybe we should draft a google doc to list all the properties will be added in
the near future (mostly from Blink planner, shall we go through every property
name from Blink?). So that we can have an overview of properties to have a
better hierarchy.
> Use TableConfig in api module to replace TableConfig in blink-planner module.
> -
>
> Key: FLINK-12348
> URL: https://issues.apache.org/jira/browse/FLINK-12348
> Project: Flink
> Issue Type: Task
> Components: Table SQL / API
>Reporter: Jing Zhang
>Assignee: Jing Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Since TableConfig already moved to API module in
> [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig
> in blink-planner-module should not exist anymore. The issue aims to remove
> the TableConfig in blink-planner-module, use TableConfig in API module
> instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[ https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833738#comment-16833738 ] Timo Walther commented on FLINK-12348: -- Yes, we should only have a single location for those properties. And a string-string map should be used for interoperability with YAML, JSON etc. However, we should provide some methods for setting frequently used properties with nice Javadocs in the string-string map. Setting and getting a timezone is a good example. > Use TableConfig in api module to replace TableConfig in blink-planner module. > - > > Key: FLINK-12348 > URL: https://issues.apache.org/jira/browse/FLINK-12348 > Project: Flink > Issue Type: Task > Components: Table SQL / API >Reporter: Jing Zhang >Assignee: Jing Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Since TableConfig already moved to API module in > [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig > in blink-planner-module should not exist anymore. The issue aims to remove > the TableConfig in blink-planner-module, use TableConfig in API module > instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[ https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833544#comment-16833544 ] Dawid Wysakowicz commented on FLINK-12348: -- I think this is a good thing to have. I also agree we should have only a single place where we store the config values (a.k.a. remove the member variables). So +1 from my side. > Use TableConfig in api module to replace TableConfig in blink-planner module. > - > > Key: FLINK-12348 > URL: https://issues.apache.org/jira/browse/FLINK-12348 > Project: Flink > Issue Type: Task > Components: Table SQL / API >Reporter: Jing Zhang >Assignee: Jing Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Since TableConfig already moved to API module in > [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig > in blink-planner-module should not exist anymore. The issue aims to remove > the TableConfig in blink-planner-module, use TableConfig in API module > instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[ https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833528#comment-16833528 ] Jark Wu commented on FLINK-12348: - Yes, I totally agree with your points [~hequn8128] > Use TableConfig in api module to replace TableConfig in blink-planner module. > - > > Key: FLINK-12348 > URL: https://issues.apache.org/jira/browse/FLINK-12348 > Project: Flink > Issue Type: Task > Components: Table SQL / API >Reporter: Jing Zhang >Assignee: Jing Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Since TableConfig already moved to API module in > [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig > in blink-planner-module should not exist anymore. The issue aims to remove > the TableConfig in blink-planner-module, use TableConfig in API module > instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[ https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833507#comment-16833507 ] Hequn Cheng commented on FLINK-12348: - Hi [~jark], thanks for the detailed description and discussions offline. It's good to make it also configurable from a yaml file. For example, user defined flink platforms can make use of it directly rather than do some wrapping. In order to support it, we may need to solve another problem: if we add a `conf` member in TableConfig, the configurations in `conf` may conflict with the member variable in TableConfig. Take timezone as an example, there is also a member variable in TableConfig. To make it consistent, we may remove the timezone variable and only store it in the `conf`. Configurations except for PlannerConfig can be moved into the `conf` similar to timezone. What's your opinions on it? [~twalthr] [~dawidwys] Best, Hequn > Use TableConfig in api module to replace TableConfig in blink-planner module. > - > > Key: FLINK-12348 > URL: https://issues.apache.org/jira/browse/FLINK-12348 > Project: Flink > Issue Type: Task > Components: Table SQL / API >Reporter: Jing Zhang >Assignee: Jing Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Since TableConfig already moved to API module in > [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig > in blink-planner-module should not exist anymore. The issue aims to remove > the TableConfig in blink-planner-module, use TableConfig in API module > instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[
https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833212#comment-16833212
]
Jark Wu commented on FLINK-12348:
-
Hi [~twalthr], I find that the updates to TableConfig mentioned in FLIP-32 is
mainly for a builder pattern. But the most important change Blink introduced is
making TableConfig configurable using plain key-value pairs (similar to runtime
options in {{flink-conf.yaml}}). So that we can setup a cluster or a job using
yaml files, for example:
{code:java}
sql.timeZone: UTC
sql.codegen.length.max: 64000
{code}
In order to support this feature, we need a member
{{org.apache.flink.configuration.Configuration}} in {{TableConfig}}. And move
{{TableConfigOptions}} into api module. What do you think? [~twalthr]
[~hequn8128] [~dawidwys]
> Use TableConfig in api module to replace TableConfig in blink-planner module.
> -
>
> Key: FLINK-12348
> URL: https://issues.apache.org/jira/browse/FLINK-12348
> Project: Flink
> Issue Type: Task
> Components: Table SQL / API
>Reporter: Jing Zhang
>Assignee: Jing Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Since TableConfig already moved to API module in
> [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig
> in blink-planner-module should not exist anymore. The issue aims to remove
> the TableConfig in blink-planner-module, use TableConfig in API module
> instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[ https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829157#comment-16829157 ] Timo Walther commented on FLINK-12348: -- We also introduced a planner config recently. More internal configuration options could also be moved there. The table config will also receive an update soon as part of the planner interface mentioned in FLIP-32 . > Use TableConfig in api module to replace TableConfig in blink-planner module. > - > > Key: FLINK-12348 > URL: https://issues.apache.org/jira/browse/FLINK-12348 > Project: Flink > Issue Type: Task > Components: Table SQL / API >Reporter: Jing Zhang >Assignee: Jing Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Since TableConfig already moved to API module in > [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig > in blink-planner-module should not exist anymore. The issue aims to remove > the TableConfig in blink-planner-module, use TableConfig in API module > instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-12348) Use TableConfig in api module to replace TableConfig in blink-planner module.
[ https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827800#comment-16827800 ] Jing Zhang commented on FLINK-12348: IMO, `TableConfigOptions` should also exist in API module, although TableConfigOptions now only works for Blink table planner and Blink table runtime. [~jark] What do you think? > Use TableConfig in api module to replace TableConfig in blink-planner module. > - > > Key: FLINK-12348 > URL: https://issues.apache.org/jira/browse/FLINK-12348 > Project: Flink > Issue Type: Task > Components: Table SQL / API >Reporter: Jing Zhang >Assignee: Jing Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Since TableConfig already moved to API module in > [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig > in blink-planner-module should not exist anymore. The issue aims to remove > the TableConfig in blink-planner-module, use TableConfig in API module > instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
