[jira] [Commented] (FLINK-13749) Make Flink client respect classloading policy
[ https://issues.apache.org/jira/browse/FLINK-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981452#comment-16981452 ] Aljoscha Krettek commented on FLINK-13749: -- You're right, I'm adding that. > Make Flink client respect classloading policy > - > > Key: FLINK-13749 > URL: https://issues.apache.org/jira/browse/FLINK-13749 > Project: Flink > Issue Type: Improvement > Components: Command Line Client, Runtime / REST >Reporter: Paul Lin >Assignee: Paul Lin >Priority: Minor > Labels: pull-request-available > Fix For: 1.10.0, 1.8.3, 1.9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, Flink client does not respect the classloading policy and uses > hardcoded parent-first classloader, while the other components like > jobmanager and taskmanager use child-first classloader by default and respect > the classloading options. This makes the client more likely to have > dependency conflicts, especially after we removed the convenient hadoop > binaries (so users need to add hadoop classpath in the client classpath). > So I propose to make Flink client's (including cli and rest handler) > classloading behavior aligned with the other components. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-13749) Make Flink client respect classloading policy
[ https://issues.apache.org/jira/browse/FLINK-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979222#comment-16979222 ] Chesnay Schepler commented on FLINK-13749: -- [~aljoscha] This change implies that the client now uses child-first classloading, correct? If so, we may want to mention that in the release notes. > Make Flink client respect classloading policy > - > > Key: FLINK-13749 > URL: https://issues.apache.org/jira/browse/FLINK-13749 > Project: Flink > Issue Type: Improvement > Components: Command Line Client, Runtime / REST >Reporter: Paul Lin >Assignee: Paul Lin >Priority: Minor > Labels: pull-request-available > Fix For: 1.10.0, 1.8.3, 1.9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, Flink client does not respect the classloading policy and uses > hardcoded parent-first classloader, while the other components like > jobmanager and taskmanager use child-first classloader by default and respect > the classloading options. This makes the client more likely to have > dependency conflicts, especially after we removed the convenient hadoop > binaries (so users need to add hadoop classpath in the client classpath). > So I propose to make Flink client's (including cli and rest handler) > classloading behavior aligned with the other components. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-13749) Make Flink client respect classloading policy
[ https://issues.apache.org/jira/browse/FLINK-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977280#comment-16977280 ] Aljoscha Krettek commented on FLINK-13749: -- Fixed on release-1.8 in 540458e2933e2441847d4813fb6901f08eab346d Fixed on release-1.9 in 0f30c263eebd2fc3ecbeae69a4ce9477e1d5d774 > Make Flink client respect classloading policy > - > > Key: FLINK-13749 > URL: https://issues.apache.org/jira/browse/FLINK-13749 > Project: Flink > Issue Type: Improvement > Components: Command Line Client, Runtime / REST >Reporter: Paul Lin >Assignee: Paul Lin >Priority: Minor > Labels: pull-request-available > Fix For: 1.10.0, 1.8.3, 1.9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, Flink client does not respect the classloading policy and uses > hardcoded parent-first classloader, while the other components like > jobmanager and taskmanager use child-first classloader by default and respect > the classloading options. This makes the client more likely to have > dependency conflicts, especially after we removed the convenient hadoop > binaries (so users need to add hadoop classpath in the client classpath). > So I propose to make Flink client's (including cli and rest handler) > classloading behavior aligned with the other components. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-13749) Make Flink client respect classloading policy
[ https://issues.apache.org/jira/browse/FLINK-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968008#comment-16968008 ] Paul Lin commented on FLINK-13749: -- [~victor-wong] Thanks for your attention. I postponed a bit the progress because the client was under active development. Now that the client is relatively steady, I'll make a PR in a day or two. > Make Flink client respect classloading policy > - > > Key: FLINK-13749 > URL: https://issues.apache.org/jira/browse/FLINK-13749 > Project: Flink > Issue Type: Improvement > Components: Command Line Client, Runtime / REST >Reporter: Paul Lin >Assignee: Paul Lin >Priority: Minor > > Currently, Flink client does not respect the classloading policy and uses > hardcoded parent-first classloader, while the other components like > jobmanager and taskmanager use child-first classloader by default and respect > the classloading options. This makes the client more likely to have > dependency conflicts, especially after we removed the convenient hadoop > binaries (so users need to add hadoop classpath in the client classpath). > So I propose to make Flink client's (including cli and rest handler) > classloading behavior aligned with the other components. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-13749) Make Flink client respect classloading policy
[ https://issues.apache.org/jira/browse/FLINK-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967429#comment-16967429 ] Victor Wong commented on FLINK-13749: - Any progress on this? If the Assignee is busy, I'd love to help:) > Make Flink client respect classloading policy > - > > Key: FLINK-13749 > URL: https://issues.apache.org/jira/browse/FLINK-13749 > Project: Flink > Issue Type: Improvement > Components: Command Line Client, Runtime / REST >Reporter: Paul Lin >Assignee: Paul Lin >Priority: Minor > > Currently, Flink client does not respect the classloading policy and uses > hardcoded parent-first classloader, while the other components like > jobmanager and taskmanager use child-first classloader by default and respect > the classloading options. This makes the client more likely to have > dependency conflicts, especially after we removed the convenient hadoop > binaries (so users need to add hadoop classpath in the client classpath). > So I propose to make Flink client's (including cli and rest handler) > classloading behavior aligned with the other components. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-13749) Make Flink client respect classloading policy
[ https://issues.apache.org/jira/browse/FLINK-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919383#comment-16919383 ] Andrey Zagrebin commented on FLINK-13749: - [~Paul Lin] are you working on the issue? Could you move in progress if you are working on it? > Make Flink client respect classloading policy > - > > Key: FLINK-13749 > URL: https://issues.apache.org/jira/browse/FLINK-13749 > Project: Flink > Issue Type: Improvement > Components: Command Line Client, Runtime / REST >Reporter: Paul Lin >Assignee: Paul Lin >Priority: Minor > > Currently, Flink client does not respect the classloading policy and uses > hardcoded parent-first classloader, while the other components like > jobmanager and taskmanager use child-first classloader by default and respect > the classloading options. This makes the client more likely to have > dependency conflicts, especially after we removed the convenient hadoop > binaries (so users need to add hadoop classpath in the client classpath). > So I propose to make Flink client's (including cli and rest handler) > classloading behavior aligned with the other components. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (FLINK-13749) Make Flink client respect classloading policy
[ https://issues.apache.org/jira/browse/FLINK-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909547#comment-16909547 ] Paul Lin commented on FLINK-13749: -- Please assign this issue to me. Thanks! > Make Flink client respect classloading policy > - > > Key: FLINK-13749 > URL: https://issues.apache.org/jira/browse/FLINK-13749 > Project: Flink > Issue Type: Improvement > Components: Command Line Client, Runtime / REST >Affects Versions: 1.9.0 >Reporter: Paul Lin >Priority: Minor > > Currently, Flink client does not respect the classloading policy and uses > hardcoded parent-first classloader, while the other components like > jobmanager and taskmanager use child-first classloader by default and respect > the classloading options. This makes the client more likely to have > dependency conflicts, especially after we removed the convenient hadoop > binaries (so users need to add hadoop classpath in the client classpath). > So I propose to make Flink client's (including cli and rest handler) > classloading behavior aligned with the other components. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
