[jira] [Commented] (FLINK-14178) maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
[
https://issues.apache.org/jira/browse/FLINK-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940785#comment-16940785
]
Till Rohrmann commented on FLINK-14178:
---
Would it be possible to use {{3.1.1}} instead of {{3.1.0}} [~wangxiyuan]?
> maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
> --
>
> Key: FLINK-14178
> URL: https://issues.apache.org/jira/browse/FLINK-14178
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
>Affects Versions: 2.0.0
>Reporter: wangxiyuan
>Assignee: Dian Fu
>Priority: Minor
> Labels: pull-request-available
> Fix For: 2.0.0
>
> Attachments: debug.log
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> recently, maven-shade-plugin is bumped from 3.0.0 to 3.2.1 by the
> [commit|https://github.com/apache/flink/commit/e7216eebc846a69272c21375af0f4db8009c2e3e].
> While with my test locally on ARM, The Flink build process will be jammed.
> After debugging, I found there is an infinite loop.
> Downgrade maven-shade-plugin to 3.1.0 can solve this problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14178) maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
[ https://issues.apache.org/jira/browse/FLINK-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940628#comment-16940628 ] wangxiyuan commented on FLINK-14178: agree to downgrade it if x86 hit the same issue. > maven-shade-plugin 3.2.1 doesn't work on ARM for Flink > -- > > Key: FLINK-14178 > URL: https://issues.apache.org/jira/browse/FLINK-14178 > Project: Flink > Issue Type: Sub-task > Components: Build System >Affects Versions: 2.0.0 >Reporter: wangxiyuan >Priority: Minor > Labels: pull-request-available > Fix For: 2.0.0 > > Attachments: debug.log > > Time Spent: 10m > Remaining Estimate: 0h > > recently, maven-shade-plugin is bumped from 3.0.0 to 3.2.1 by the > [commit|https://github.com/apache/flink/commit/e7216eebc846a69272c21375af0f4db8009c2e3e]. > While with my test locally on ARM, The Flink build process will be jammed. > After debugging, I found there is an infinite loop. > Downgrade maven-shade-plugin to 3.1.0 can solve this problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-14178) maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
[ https://issues.apache.org/jira/browse/FLINK-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940626#comment-16940626 ] Dian Fu commented on FLINK-14178: - [~sunjincheng121] Downgrading the maven-shade-plugin to 3.1.0 makes sense to me. I'd like to take this ticket and fix it, could you assign this issue to me? > maven-shade-plugin 3.2.1 doesn't work on ARM for Flink > -- > > Key: FLINK-14178 > URL: https://issues.apache.org/jira/browse/FLINK-14178 > Project: Flink > Issue Type: Sub-task > Components: Build System >Affects Versions: 2.0.0 >Reporter: wangxiyuan >Priority: Minor > Fix For: 2.0.0 > > Attachments: debug.log > > > recently, maven-shade-plugin is bumped from 3.0.0 to 3.2.1 by the > [commit|https://github.com/apache/flink/commit/e7216eebc846a69272c21375af0f4db8009c2e3e]. > While with my test locally on ARM, The Flink build process will be jammed. > After debugging, I found there is an infinite loop. > Downgrade maven-shade-plugin to 3.1.0 can solve this problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-14178) maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
[ https://issues.apache.org/jira/browse/FLINK-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940622#comment-16940622 ] sunjincheng commented on FLINK-14178: - Thanks for the discussion [~wangxiyuan] and [~dian.fu]. Due to we fond the e2e test issue in FLINK-14226, So I suggestion try to downgrading the maven-shade-plugin version to 3.1.0. What do you think? > maven-shade-plugin 3.2.1 doesn't work on ARM for Flink > -- > > Key: FLINK-14178 > URL: https://issues.apache.org/jira/browse/FLINK-14178 > Project: Flink > Issue Type: Sub-task > Components: Build System >Affects Versions: 2.0.0 >Reporter: wangxiyuan >Priority: Minor > Fix For: 2.0.0 > > Attachments: debug.log > > > recently, maven-shade-plugin is bumped from 3.0.0 to 3.2.1 by the > [commit|https://github.com/apache/flink/commit/e7216eebc846a69272c21375af0f4db8009c2e3e]. > While with my test locally on ARM, The Flink build process will be jammed. > After debugging, I found there is an infinite loop. > Downgrade maven-shade-plugin to 3.1.0 can solve this problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-14178) maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
[ https://issues.apache.org/jira/browse/FLINK-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937315#comment-16937315 ] wangxiyuan commented on FLINK-14178: Hi [~dian.fu] I have attached the debug file. You can see that from Line79079 with `Dependency-reduced POM written at: /home/zuul/flink/flink-table/flink-sql-parser/target/dependency-reduced-pom.xml`, after this line, there is an infinite loop forever. The behavior is strange and I found a similar [bug|https://www.mail-archive.com/dev@htrace.incubator.apache.org/msg00844.html] But Apache Spark uses 3.2.1 as well and it works well on ARM. It seems that this bug only in flink-sql-parser. Sorry that I'm not sure the deep reason. I'm agree that downgrading to 3.1.0 is not the best way as you mentioned. How about add a new profile section in pom.xml for ARM? It'll not break Flink's default action on X86. And in the future, some ARM specified changes can be added there as well. > maven-shade-plugin 3.2.1 doesn't work on ARM for Flink > -- > > Key: FLINK-14178 > URL: https://issues.apache.org/jira/browse/FLINK-14178 > Project: Flink > Issue Type: Sub-task > Components: Build System >Affects Versions: 2.0.0 >Reporter: wangxiyuan >Priority: Minor > Fix For: 2.0.0 > > Attachments: debug.log > > > recently, maven-shade-plugin is bumped from 3.0.0 to 3.2.1 by the > [commit|https://github.com/apache/flink/commit/e7216eebc846a69272c21375af0f4db8009c2e3e]. > While with my test locally on ARM, The Flink build process will be jammed. > After debugging, I found there is an infinite loop. > Downgrade maven-shade-plugin to 3.1.0 can solve this problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-14178) maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
[ https://issues.apache.org/jira/browse/FLINK-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936693#comment-16936693 ] Dian Fu commented on FLINK-14178: - Hi [~wangxiyuan], Thanks a lot for your great work. The maven-shade-plugin is bumped because it introduces the dependency of Beam for Python UDF support and maven-shade-plugin of version below 3.1.0 does not work well with ASM 6.0 (MSHADE-258) which is dependent by Beam. It bump it directly from 3.0.0 to 3.2.1 because we noticed that profile java11 has upgraded maven-shade-plugin to 3.2.1 as it only supports java11 since [3.2.1|[https://github.com/apache/flink/pull/9294]]. So downgrade maven-shade-plugin to 3.1.0 will not break the functionality of Python UDF and I'm +1 if downgrade is needed. Just want to point out that as maven-shade-plugin only supports java11 since 3.2.1 and it doesn't work on ARM for 3.2.1. It means that it's not possible to build flink on ARM for java11. Could you verify this? > maven-shade-plugin 3.2.1 doesn't work on ARM for Flink > -- > > Key: FLINK-14178 > URL: https://issues.apache.org/jira/browse/FLINK-14178 > Project: Flink > Issue Type: Sub-task > Components: Build System >Affects Versions: 2.0.0 >Reporter: wangxiyuan >Priority: Minor > Fix For: 2.0.0 > > > recently, maven-shade-plugin is bumped from 3.0.0 to 3.2.1 by the > [commit|https://github.com/apache/flink/commit/e7216eebc846a69272c21375af0f4db8009c2e3e]. > While with my test locally on ARM, The Flink build process will be jammed. > After debugging, I found there is an infinite loop. > Downgrade maven-shade-plugin to 3.1.0 can solve this problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
