[jira] [Commented] (FLINK-14179) Wrong description of SqlCommand.SHOW_FUNCTIONS

2019-09-28 Thread Canbin Zheng (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940259#comment-16940259
 ] 

Canbin Zheng commented on FLINK-14179:
--

Thanks [~tison]

> Wrong description of SqlCommand.SHOW_FUNCTIONS
> --
>
> Key: FLINK-14179
> URL: https://issues.apache.org/jira/browse/FLINK-14179
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Client
>Affects Versions: 1.9.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.0
>
> Attachments: image-2019-09-24-10-59-26-286.png, 
> image-2019-09-29-14-29-02-274.png, image-2019-09-29-14-29-54-861.png, 
> image-2019-09-29-14-34-45-151.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently '*SHOW FUNCTIONS*' lists not only user-defined functions, but also 
> system-defined ones, the description {color:#172b4d}*'Shows all registered 
> user-defined functions.'* not correctly depicts this functionality. I think 
> we can change the description to '*Shows all system-defined and user-defined 
> functions.*'{color}
>  
> {color:#172b4d}!image-2019-09-24-10-59-26-286.png|width=640,height=191!{color}
> {color:#172b4d}!image-2019-09-29-14-34-45-151.png|width=561,height=465!{color}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14179) Wrong description of SqlCommand.SHOW_FUNCTIONS

2019-09-28 Thread Zili Chen (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940254#comment-16940254
 ] 

Zili Chen commented on FLINK-14179:
---

Hi [~felixzheng] I've assigned the issue to you. Will give it a review now.

> Wrong description of SqlCommand.SHOW_FUNCTIONS
> --
>
> Key: FLINK-14179
> URL: https://issues.apache.org/jira/browse/FLINK-14179
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Client
>Affects Versions: 1.9.0
>Reporter: Canbin Zheng
>Assignee: Canbin Zheng
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.0
>
> Attachments: image-2019-09-24-10-59-26-286.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently '*SHOW FUNCTIONS*' lists not only user-defined functions, but also 
> system-defined ones, the description {color:#172b4d}*'Shows all registered 
> user-defined functions.'* not correctly depicts this functionality. I think 
> we can change the description to '*Shows all system-defined and user-defined 
> functions.*'{color}
>  
> {color:#172b4d}!image-2019-09-24-10-59-26-286.png!{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14179) Wrong description of SqlCommand.SHOW_FUNCTIONS

2019-09-28 Thread Canbin Zheng (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940248#comment-16940248
 ] 

Canbin Zheng commented on FLINK-14179:
--

[~Tison] [~jark] It's a quite minor change, could any take a look to merge then 
close this ticket.

> Wrong description of SqlCommand.SHOW_FUNCTIONS
> --
>
> Key: FLINK-14179
> URL: https://issues.apache.org/jira/browse/FLINK-14179
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Client
>Affects Versions: 1.9.0
>Reporter: Canbin Zheng
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.0
>
> Attachments: image-2019-09-24-10-59-26-286.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently '*SHOW FUNCTIONS*' lists not only user-defined functions, but also 
> system-defined ones, the description {color:#172b4d}*'Shows all registered 
> user-defined functions.'* not correctly depicts this functionality. I think 
> we can change the description to '*Shows all system-defined and user-defined 
> functions.*'{color}
>  
> {color:#172b4d}!image-2019-09-24-10-59-26-286.png!{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)