[jira] [Commented] (FLINK-14211) Add jobManager address configuration for SqlClient

2019-10-06 Thread zhangwei (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945567#comment-16945567
 ] 

zhangwei commented on FLINK-14211:
--

sql-client did not add addressOption, so jobmanager should not work in 
sql-client

[https://github.com/apache/flink/blob/a110cec19c5770fadfc460a8ef4d351a3593190a/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L119-L136]
{code:java}
public CliFrontend(
Configuration configuration,
List> customCommandLines) {
this.configuration = Preconditions.checkNotNull(configuration);
this.customCommandLines = 
Preconditions.checkNotNull(customCommandLines);


FileSystem.initialize(configuration, 
PluginUtils.createPluginManagerFromRootFolder(configuration));


this.customCommandLineOptions = new Options();


for (CustomCommandLine customCommandLine : 
customCommandLines) {

customCommandLine.addGeneralOptions(customCommandLineOptions);

customCommandLine.addRunOptions(customCommandLineOptions);
}


this.clientTimeout = 
AkkaUtils.getClientTimeout(this.configuration);
this.defaultParallelism = 
configuration.getInteger(CoreOptions.DEFAULT_PARALLELISM);
}
{code}
[https://github.com/apache/flink/blob/a110cec19c5770fadfc460a8ef4d351a3593190a/flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java#L620-L628]
{code:java}
private static Options 
collectCommandLineOptions(List> commandLines) {
final Options customOptions = new Options();
for (CustomCommandLine customCommandLine : commandLines) {
customCommandLine.addRunOptions(customOptions);
}
return CliFrontendParser.mergeOptions(
CliFrontendParser.getRunCommandOptions(),
customOptions);
}
{code}

> Add jobManager address configuration for SqlClient
> --
>
> Key: FLINK-14211
> URL: https://issues.apache.org/jira/browse/FLINK-14211
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Client
>Affects Versions: 1.9.0
>Reporter: zhangwei
>Priority: Trivial
>
> Add jobmanager option in deployment configuration, allow SQL clients to 
> submit jobs to the remote flink cluster
> {code:java}
> deployment:
>   # general cluster communication timeout in ms
>   response-timeout: 5000
>   # (optional) address from cluster to gateway
>   gateway-address: ""
>   # (optional) port from cluster to gateway
>   gateway-port: 0
>   # (optional) jobmanager address
>   jobmanager: 127.0.0.1:8081
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14211) Add jobManager address configuration for SqlClient

2019-10-04 Thread Timo Walther (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944562#comment-16944562
 ] 

Timo Walther commented on FLINK-14211:
--

[~arugal] most of the deployment parameters are the ones also used for the 
Flink CLI: 
https://ci.apache.org/projects/flink/flink-docs-master/ops/config.html
If this works for you, can you close this issue or open a PR for documentation?

> Add jobManager address configuration for SqlClient
> --
>
> Key: FLINK-14211
> URL: https://issues.apache.org/jira/browse/FLINK-14211
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Client
>Affects Versions: 1.9.0
>Reporter: zhangwei
>Priority: Trivial
>
> Add jobmanager option in deployment configuration, allow SQL clients to 
> submit jobs to the remote flink cluster
> {code:java}
> deployment:
>   # general cluster communication timeout in ms
>   response-timeout: 5000
>   # (optional) address from cluster to gateway
>   gateway-address: ""
>   # (optional) port from cluster to gateway
>   gateway-port: 0
>   # (optional) jobmanager address
>   jobmanager: 127.0.0.1:8081
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)