[jira] [Commented] (FLINK-1430) Add test for streaming scala api completeness
[ https://issues.apache.org/jira/browse/FLINK-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562464#comment-14562464 ] Márton Balassi commented on FLINK-1430: --- Hey, [~qmlmoon] are you working on this issue currently or is it OK if I take this over? > Add test for streaming scala api completeness > - > > Key: FLINK-1430 > URL: https://issues.apache.org/jira/browse/FLINK-1430 > Project: Flink > Issue Type: Test > Components: Streaming >Affects Versions: 0.9 >Reporter: Márton Balassi >Assignee: Mingliang Qi > > Currently the completeness of the streaming scala api is not tested. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1430) Add test for streaming scala api completeness
[ https://issues.apache.org/jira/browse/FLINK-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567401#comment-14567401 ] ASF GitHub Bot commented on FLINK-1430: --- GitHub user mbalassi opened a pull request: https://github.com/apache/flink/pull/753 [FLINK-1430] [streaming] Scala API completeness for streaming Added the necessary checks and missing methods for streaming. Created an abstract base class for these completeness tests to have the base functionality in a central place. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mbalassi/flink flink-1430 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/753.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #753 commit 50c818d6d28c33546546812c78db7f47c1a32447 Author: mbalassi Date: 2015-06-01T14:56:15Z [FLINK-1430] [streaming] Scala API completeness for streaming > Add test for streaming scala api completeness > - > > Key: FLINK-1430 > URL: https://issues.apache.org/jira/browse/FLINK-1430 > Project: Flink > Issue Type: Test > Components: Streaming >Affects Versions: 0.9 >Reporter: Márton Balassi >Assignee: Márton Balassi > > Currently the completeness of the streaming scala api is not tested. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1430) Add test for streaming scala api completeness
[ https://issues.apache.org/jira/browse/FLINK-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567410#comment-14567410 ] ASF GitHub Bot commented on FLINK-1430: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/753#issuecomment-107569766 +1 looks good to merge :smile: > Add test for streaming scala api completeness > - > > Key: FLINK-1430 > URL: https://issues.apache.org/jira/browse/FLINK-1430 > Project: Flink > Issue Type: Test > Components: Streaming >Affects Versions: 0.9 >Reporter: Márton Balassi >Assignee: Márton Balassi > > Currently the completeness of the streaming scala api is not tested. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1430) Add test for streaming scala api completeness
[ https://issues.apache.org/jira/browse/FLINK-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568874#comment-14568874 ] ASF GitHub Bot commented on FLINK-1430: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/753 > Add test for streaming scala api completeness > - > > Key: FLINK-1430 > URL: https://issues.apache.org/jira/browse/FLINK-1430 > Project: Flink > Issue Type: Test > Components: Streaming >Affects Versions: 0.9 >Reporter: Márton Balassi >Assignee: Márton Balassi > > Currently the completeness of the streaming scala api is not tested. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1430) Add test for streaming scala api completeness
[ https://issues.apache.org/jira/browse/FLINK-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291921#comment-14291921 ] Mingliang Qi commented on FLINK-1430: - I saw some methods like setConfig, getConfig, getStreamGraph in StreamExecutionEnvironment, which are included in the batch scala api but not in stream scala api. Should we just exclude these in the test? Another one missing is printToErr in DataStream class. > Add test for streaming scala api completeness > - > > Key: FLINK-1430 > URL: https://issues.apache.org/jira/browse/FLINK-1430 > Project: Flink > Issue Type: Test > Components: Streaming >Affects Versions: 0.9 >Reporter: Márton Balassi >Assignee: Mingliang Qi > > Currently the completeness of the streaming scala api is not tested. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1430) Add test for streaming scala api completeness
[ https://issues.apache.org/jira/browse/FLINK-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371256#comment-14371256 ] Stephan Ewen commented on FLINK-1430: - The completeness test is to ensure that the Java and Scala API are in sync, not the Batch and the Streaming API. So, I think we should include these utility methods that you mentioned. > Add test for streaming scala api completeness > - > > Key: FLINK-1430 > URL: https://issues.apache.org/jira/browse/FLINK-1430 > Project: Flink > Issue Type: Test > Components: Streaming >Affects Versions: 0.9 >Reporter: Márton Balassi >Assignee: Mingliang Qi > > Currently the completeness of the streaming scala api is not tested. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
