[jira] [Commented] (FLINK-14482) Bump up rocksdb version to support WriteBufferManager

2019-11-20 Thread Yu Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978966#comment-16978966
 ] 

Yu Li commented on FLINK-14482:
---

Change the JIRA type to Improvement and decouple it from FLINK-7289 per the 
above discussions.

> Bump up rocksdb version to support WriteBufferManager
> -
>
> Key: FLINK-14482
> URL: https://issues.apache.org/jira/browse/FLINK-14482
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / State Backends
>Reporter: Yun Tang
>Assignee: Yun Tang
>Priority: Major
> Fix For: 1.11.0
>
>
> Current rocksDB-5.17.2 does not support write buffer manager well, we need to 
> bump rocksdb version to support that feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14482) Bump up rocksdb version to support WriteBufferManager

2019-10-29 Thread Till Rohrmann (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962130#comment-16962130
 ] 

Till Rohrmann commented on FLINK-14482:
---

Ok, I agree. Thanks for explanation [~yunta].

> Bump up rocksdb version to support WriteBufferManager
> -
>
> Key: FLINK-14482
> URL: https://issues.apache.org/jira/browse/FLINK-14482
> Project: Flink
>  Issue Type: Sub-task
>  Components: Runtime / State Backends
>Reporter: Yun Tang
>Assignee: Yun Tang
>Priority: Major
> Fix For: 1.11.0
>
>
> Current rocksDB-5.17.2 does not support write buffer manager well, we need to 
> bump rocksdb version to support that feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14482) Bump up rocksdb version to support WriteBufferManager

2019-10-27 Thread Yun Tang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960649#comment-16960649
 ] 

Yun Tang commented on FLINK-14482:
--

[~trohrmann] Yes, we first plan to upgrade the base RocksDB version of FRocksDB 
but found there existed some performance regression. Until now, I think we 
might still have to remain previous base RocksDB version and cherry-pick 
write-buffer manager feature code in Flink-1.10

>From my point of view, I think this issue is target for Flink-1.11 for the 
>future and still need to maintain it as {{open}}.

> Bump up rocksdb version to support WriteBufferManager
> -
>
> Key: FLINK-14482
> URL: https://issues.apache.org/jira/browse/FLINK-14482
> Project: Flink
>  Issue Type: Sub-task
>  Components: Runtime / State Backends
>Reporter: Yun Tang
>Assignee: Yun Tang
>Priority: Major
> Fix For: 1.11.0
>
>
> Current rocksDB-5.17.2 does not support write buffer manager well, we need to 
> bump rocksdb version to support that feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14482) Bump up rocksdb version to support WriteBufferManager

2019-10-25 Thread Till Rohrmann (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959725#comment-16959725
 ] 

Till Rohrmann commented on FLINK-14482:
---

Wait, this is actually already described in FLINK-14483. Then I guess we can 
close this issue, right?

> Bump up rocksdb version to support WriteBufferManager
> -
>
> Key: FLINK-14482
> URL: https://issues.apache.org/jira/browse/FLINK-14482
> Project: Flink
>  Issue Type: Sub-task
>  Components: Runtime / State Backends
>Reporter: Yun Tang
>Assignee: Yun Tang
>Priority: Major
> Fix For: 1.11.0
>
>
> Current rocksDB-5.17.2 does not support write buffer manager well, we need to 
> bump rocksdb version to support that feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14482) Bump up rocksdb version to support WriteBufferManager

2019-10-25 Thread Till Rohrmann (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959722#comment-16959722
 ] 

Till Rohrmann commented on FLINK-14482:
---

I guess this JIRA needs to be updated in order to reflect the current solution 
approach to release an updated FRocksDB version where we cherry pick the 
relevant commits.

> Bump up rocksdb version to support WriteBufferManager
> -
>
> Key: FLINK-14482
> URL: https://issues.apache.org/jira/browse/FLINK-14482
> Project: Flink
>  Issue Type: Sub-task
>  Components: Runtime / State Backends
>Reporter: Yun Tang
>Assignee: Yun Tang
>Priority: Major
> Fix For: 1.11.0
>
>
> Current rocksDB-5.17.2 does not support write buffer manager well, we need to 
> bump rocksdb version to support that feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14482) Bump up rocksdb version to support WriteBufferManager

2019-10-22 Thread Yun Tang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956736#comment-16956736
 ] 

Yun Tang commented on FLINK-14482:
--

At first, we plan to bump the base rocksDB version from 5.17.2 to 5.18.3 to 
support write buffer manager feature. However, when we test with flink's 
[benchmark|https://github.com/dataArtisans/flink-benchmarks], and we found all 
test cases behave with performance regression from 1% ~ 9%, more details could 
refer to rocksDB's [issue-5774|https://github.com/facebook/rocksdb/issues/5774].

Until now, even we could reproduce this with RocksDB built-in db_bench, there 
still no exact answer for this problem.

> Bump up rocksdb version to support WriteBufferManager
> -
>
> Key: FLINK-14482
> URL: https://issues.apache.org/jira/browse/FLINK-14482
> Project: Flink
>  Issue Type: Sub-task
>  Components: Runtime / State Backends
>Reporter: Yun Tang
>Priority: Major
> Fix For: 1.11.0
>
>
> Current rocksDB-5.17.2 does not support write buffer manager well, we need to 
> bump rocksdb version to support that feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)